From 8caafdc53c8bae361c2c08556cfec577cba89e6c Mon Sep 17 00:00:00 2001 From: kleines Date: Mon, 20 Apr 2020 14:42:36 +0200 Subject: [PATCH 01/12] Initial commit --- solution/tc_project_app/GlobalTextList.TcGTLO | 75 ++----------------- .../Visualization Manager.TcVMO | 2 + solution/tc_project_app/tc_mca_std_lib | 2 +- .../tc_project_app/tc_project_app.plcproj | 3 + 4 files changed, 11 insertions(+), 71 deletions(-) diff --git a/solution/tc_project_app/GlobalTextList.TcGTLO b/solution/tc_project_app/GlobalTextList.TcGTLO index 21a3034..0610c38 100644 --- a/solution/tc_project_app/GlobalTextList.TcGTLO +++ b/solution/tc_project_app/GlobalTextList.TcGTLO @@ -10,31 +10,11 @@ "%2.2f" - - "878" - "%d" - - - - "706" - "%i" - - "940" "%x" - - "703" - "Acknowledge" - - - - "710" - "Active:" - - "952" "actPos" @@ -65,6 +45,11 @@ "bBwEnabled" + + "225" + "bCommandAborted" + + "946" "bDone" @@ -100,21 +85,6 @@ "bHomed" - - "947" - "bResetDone" - - - - "944" - "bWarning" - - - - "704" - "Clear All" - - "104" "ENABLE" @@ -140,26 +110,6 @@ "errID" - - "701" - "Error #" - - - - "705" - "Error #:" - - - - "702" - "Error Log" - - - - "707" - "Errors:" - - "955" "fAcceleration" @@ -180,11 +130,6 @@ "fRatio" - - "708" - "Free Entries:" - - "954" "fVelocity" @@ -215,11 +160,6 @@ "homeSensorPos" - - "711" - "Inactive:" - - "116" "jogBw" @@ -260,11 +200,6 @@ "nIndex" - - "709" - "Overflows:" - - "942" "reset" diff --git a/solution/tc_project_app/Visualization Manager.TcVMO b/solution/tc_project_app/Visualization Manager.TcVMO index e63f527..c8abbf3 100644 --- a/solution/tc_project_app/Visualization Manager.TcVMO +++ b/solution/tc_project_app/Visualization Manager.TcVMO @@ -37,6 +37,7 @@ {00000000-0000-0000-0000-000000000000} true true + false "" @@ -511,6 +512,7 @@ + {925c2b24-84d1-469a-954d-7af8b99219ef} {f905b871-af16-47c5-a6ef-0a0918a8b009} {d3706fa7-8257-48b3-af0a-cab0afb4dc49} diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 08a5fd1..950a864 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 08a5fd1399ee7f333765229a2737919377ea0e6e +Subproject commit 950a8649955feb3d9098fee8eb1d786451ae9447 diff --git a/solution/tc_project_app/tc_project_app.plcproj b/solution/tc_project_app/tc_project_app.plcproj index 23aa3e4..517f340 100644 --- a/solution/tc_project_app/tc_project_app.plcproj +++ b/solution/tc_project_app/tc_project_app.plcproj @@ -57,6 +57,9 @@ Code + + Code + Code From d55cae194f306e74b3b0493d21e0a15303fec95b Mon Sep 17 00:00:00 2001 From: kleines Date: Mon, 27 Apr 2020 15:05:41 +0200 Subject: [PATCH 02/12] improved handling of reset and jogging --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 950a864..87a35dc 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 950a8649955feb3d9098fee8eb1d786451ae9447 +Subproject commit 87a35dc4c0869c485279a35cd2509df0ba83d4f4 From c2cc2f0705a5f552fc7b5232e2830887fd54819a Mon Sep 17 00:00:00 2001 From: kleines Date: Mon, 4 May 2020 11:29:19 +0200 Subject: [PATCH 03/12] removed inconsitency regarding reset --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 87a35dc..e63ebde 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 87a35dc4c0869c485279a35cd2509df0ba83d4f4 +Subproject commit e63ebdeecfb1b4b363dbdd84480feae06c72506e From e2321a2b9c0a3d8b5d08a2df1165becca8220e85 Mon Sep 17 00:00:00 2001 From: kleines Date: Tue, 5 May 2020 17:26:10 +0200 Subject: [PATCH 04/12] added new homing code from MBP-131 --- solution.sln | 16 ----- solution/tc_project_app/GlobalTextList.TcGTLO | 60 +++++++++++++++++++ solution/tc_project_app/tc_mca_std_lib | 2 +- .../tc_project_app/tc_project_app.plcproj | 6 +- 4 files changed, 64 insertions(+), 20 deletions(-) diff --git a/solution.sln b/solution.sln index 9459e68..be04ac6 100644 --- a/solution.sln +++ b/solution.sln @@ -33,22 +33,6 @@ Global {9CF97348-B9D3-4938-B1F2-5F0B0B6AA66A}.Release|TwinCAT RT (x64).Build.0 = Release|TwinCAT RT (x64) {9CF97348-B9D3-4938-B1F2-5F0B0B6AA66A}.Release|TwinCAT RT (x86).ActiveCfg = Release|TwinCAT RT (x86) {9CF97348-B9D3-4938-B1F2-5F0B0B6AA66A}.Release|TwinCAT RT (x86).Build.0 = Release|TwinCAT RT (x86) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT CE7 (ARMV7).ActiveCfg = Debug|TwinCAT CE7 (ARMV7) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT CE7 (ARMV7).Build.0 = Debug|TwinCAT CE7 (ARMV7) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT OS (ARMT2).ActiveCfg = Debug|TwinCAT OS (ARMT2) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT OS (ARMT2).Build.0 = Debug|TwinCAT OS (ARMT2) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT RT (x64).ActiveCfg = Debug|TwinCAT RT (x64) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT RT (x64).Build.0 = Debug|TwinCAT RT (x64) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT RT (x86).ActiveCfg = Debug|TwinCAT RT (x86) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Debug|TwinCAT RT (x86).Build.0 = Debug|TwinCAT RT (x86) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT CE7 (ARMV7).ActiveCfg = Release|TwinCAT CE7 (ARMV7) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT CE7 (ARMV7).Build.0 = Release|TwinCAT CE7 (ARMV7) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT OS (ARMT2).ActiveCfg = Release|TwinCAT OS (ARMT2) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT OS (ARMT2).Build.0 = Release|TwinCAT OS (ARMT2) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT RT (x64).ActiveCfg = Release|TwinCAT RT (x64) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT RT (x64).Build.0 = Release|TwinCAT RT (x64) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT RT (x86).ActiveCfg = Release|TwinCAT RT (x86) - {F935F1DE-0753-4702-B418-1DC0ED040A4D}.Release|TwinCAT RT (x86).Build.0 = Release|TwinCAT RT (x86) {FB261665-FD20-4BF2-97F8-2854C82B752D}.Debug|TwinCAT CE7 (ARMV7).ActiveCfg = Debug|TwinCAT CE7 (ARMV7) {FB261665-FD20-4BF2-97F8-2854C82B752D}.Debug|TwinCAT CE7 (ARMV7).Build.0 = Debug|TwinCAT CE7 (ARMV7) {FB261665-FD20-4BF2-97F8-2854C82B752D}.Debug|TwinCAT OS (ARMT2).ActiveCfg = Debug|TwinCAT OS (ARMT2) diff --git a/solution/tc_project_app/GlobalTextList.TcGTLO b/solution/tc_project_app/GlobalTextList.TcGTLO index 0610c38..85e9493 100644 --- a/solution/tc_project_app/GlobalTextList.TcGTLO +++ b/solution/tc_project_app/GlobalTextList.TcGTLO @@ -85,6 +85,56 @@ "bHomed" + + "944" + "bWarning" + + + + "986" + "ehomeDirect" + + + + "198" + "eHomeToEncPulse_Bwd" + + + + "510" + "eHomeToEncPulse_Fwd" + + + + "287" + "eHomeToEncPulse_viaBwdLimit" + + + + "683" + "eHomeToEncPulse_viaFwdLimit" + + + + "312" + "eHomeToLimit_Bwd" + + + + "635" + "eHomeToLimit_Fwd" + + + + "150" + "eHomeToRef_Bwd" + + + + "861" + "eHomeToRef_Fwd" + + "104" "ENABLE" @@ -120,6 +170,16 @@ "fDeceleration" + + "531" + "fHomeFinishDistance" + + + + "613" + "fHomePosition" + + "957" "fPosition" diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index e63ebde..9815816 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit e63ebdeecfb1b4b363dbdd84480feae06c72506e +Subproject commit 98158162d852df88051cc64e166c45c8d1c5f1cc diff --git a/solution/tc_project_app/tc_project_app.plcproj b/solution/tc_project_app/tc_project_app.plcproj index 517f340..e802ca0 100644 --- a/solution/tc_project_app/tc_project_app.plcproj +++ b/solution/tc_project_app/tc_project_app.plcproj @@ -93,10 +93,10 @@ Code - + Code - + Code @@ -131,6 +131,7 @@ + @@ -139,7 +140,6 @@ - From 2e497bbf4254c5cdecef8296d32331b612fa4b9f Mon Sep 17 00:00:00 2001 From: kleines Date: Tue, 5 May 2020 18:59:16 +0200 Subject: [PATCH 05/12] corrected white spaces --- solution/tc_project_app/GlobalTextList.TcGTLO | 7 ++++++- solution/tc_project_app/tc_mca_std_lib | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/solution/tc_project_app/GlobalTextList.TcGTLO b/solution/tc_project_app/GlobalTextList.TcGTLO index 85e9493..4012065 100644 --- a/solution/tc_project_app/GlobalTextList.TcGTLO +++ b/solution/tc_project_app/GlobalTextList.TcGTLO @@ -45,6 +45,11 @@ "bBwEnabled" + + "633" + "bCoammandAborted" + + "225" "bCommandAborted" @@ -87,7 +92,7 @@ "944" - "bWarning" + "bCommandAborted" diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 9815816..868d8f5 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 98158162d852df88051cc64e166c45c8d1c5f1cc +Subproject commit 868d8f576a5aa93c4a3a969e615a10b96b5ddc29 From 7724dbee1a531c89d62384c1901453b7ccb6b69b Mon Sep 17 00:00:00 2001 From: kleines Date: Tue, 2 Jun 2020 17:03:28 +0200 Subject: [PATCH 06/12] did changes according Federicos comments to the pull request. Added code from MBP-100. --- solution/tc_project_app/GlobalTextList.TcGTLO | 20 +++++++++++++++++++ solution/tc_project_app/tc_mca_std_lib | 2 +- .../tc_project_app/tc_project_app.plcproj | 3 +++ 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/solution/tc_project_app/GlobalTextList.TcGTLO b/solution/tc_project_app/GlobalTextList.TcGTLO index 82986d0..c059fa7 100644 --- a/solution/tc_project_app/GlobalTextList.TcGTLO +++ b/solution/tc_project_app/GlobalTextList.TcGTLO @@ -10,6 +10,11 @@ "%2.2f" + + "543" + "%2.4f" + + "940" "%x" @@ -165,6 +170,11 @@ "errID" + + "768" + "eWriteParameter" + + "955" "fAcceleration" @@ -200,11 +210,21 @@ "fRatio" + + "781" + "fReadAxisParameter" + + "954" "fVelocity" + + "688" + "fWriteAxisParameter" + + "299" "gearIn" diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index d289e6d..c9ffae6 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit d289e6d1684edfc7414c1d660000bc856d7dbe59 +Subproject commit c9ffae6164a23a3412d62f02a90a807a22e904e3 diff --git a/solution/tc_project_app/tc_project_app.plcproj b/solution/tc_project_app/tc_project_app.plcproj index 35a95a7..edfc340 100644 --- a/solution/tc_project_app/tc_project_app.plcproj +++ b/solution/tc_project_app/tc_project_app.plcproj @@ -30,6 +30,9 @@ Code + + Code + Code From 518156b387c24fe218a235e9c522afc92a73cfbc Mon Sep 17 00:00:00 2001 From: kleines Date: Tue, 2 Jun 2020 17:50:59 +0200 Subject: [PATCH 07/12] added changes according Simons suggestions in MBP-116 with bxxxx helper variables. --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index c9ffae6..20ef5b5 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit c9ffae6164a23a3412d62f02a90a807a22e904e3 +Subproject commit 20ef5b5988e893d8bcecc90654926850eab2beac From b49c9f61016cc353bf66cd56d2ab1b679991bf92 Mon Sep 17 00:00:00 2001 From: kleines Date: Thu, 4 Jun 2020 17:22:05 +0200 Subject: [PATCH 08/12] removed busy check for fbReadParameters --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 20ef5b5..311a6be 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 20ef5b5988e893d8bcecc90654926850eab2beac +Subproject commit 311a6be50d0a408bb6702cb40d1e9c246136c2d8 From c72741a8b86d213b7834d9cdcec480b48bd767fa Mon Sep 17 00:00:00 2001 From: kleines Date: Thu, 4 Jun 2020 18:24:18 +0200 Subject: [PATCH 09/12] corrected white space errors --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 28e6f65..ec0227a 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 28e6f656815f53f962544a1c7ded51af3e7b5d91 +Subproject commit ec0227a94eed02a002476987f98c59acb09e442d From 5d79e74e6ca3f334a2a07e8ce5d88efbc2cda345 Mon Sep 17 00:00:00 2001 From: kleines Date: Tue, 16 Jun 2020 12:56:52 +0200 Subject: [PATCH 10/12] changed bBUSY to bBusy --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index ec0227a..3cd9c3f 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit ec0227a94eed02a002476987f98c59acb09e442d +Subproject commit 3cd9c3f92b6818c8878f4ec1d10665a8341cbe45 From 064d2c1728b3e8b7de8852998dbb360a90a3ba35 Mon Sep 17 00:00:00 2001 From: kleines Date: Thu, 18 Jun 2020 18:37:43 +0200 Subject: [PATCH 11/12] did some minor editorial changes --- .../Test/common/FB_tcUNIT_common.TcPOU | 122 +++++++++--------- solution/tc_project_app/tc_mca_std_lib | 2 +- 2 files changed, 62 insertions(+), 62 deletions(-) diff --git a/solution/tc_project_app/Test/common/FB_tcUNIT_common.TcPOU b/solution/tc_project_app/Test/common/FB_tcUNIT_common.TcPOU index 5c7c306..29730bc 100644 --- a/solution/tc_project_app/Test/common/FB_tcUNIT_common.TcPOU +++ b/solution/tc_project_app/Test/common/FB_tcUNIT_common.TcPOU @@ -13,37 +13,37 @@ END_VAR]]> - + - + - + - + @@ -60,28 +60,28 @@ END_VAR +GVL.astAxes[nAxisIndex].stConfig.fVelocity := tcUNIT_GVL.fDEFAULT_TARGET_VELOCITY; +GVL.astAxes[nAxisIndex].stConfig.fAcceleration := tcUNIT_GVL.fDEFAULT_TARGET_ACCELERATION; +GVL.astAxes[nAxisIndex].stConfig.fDeceleration := tcUNIT_GVL.fDEFAULT_TARGET_DECCELERATION; +GVL.astAxes[nAxisIndex].stConfig.fOverride := tcUNIT_GVL.fDEFAULT_TARGET_OVERRIDE; +GVL.astAxes[nAxisIndex].stConfig.fPosition := tcUNIT_GVL.fDEFAULT_POSITION;]]> - + +GVL.astAxes[nAxisIndex].stConfig.fVelocity := fTargetVelocity; +GVL.astAxes[nAxisIndex].stConfig.fAcceleration := fTargetAcceleration; +GVL.astAxes[nAxisIndex].stConfig.fDeceleration := fTargetDeceleration; +GVL.astAxes[nAxisIndex].stConfig.fPosition := fTargetPosition;]]> - @@ -158,39 +158,39 @@ END_FOR]]> +GVL.astAxes[nAxisIndex].stInputs.bLimitBwd := FALSE; +GVL.astAxes[nAxisIndex].stInputs.bLimitFwd := FALSE; +GVL.astAxes[nAxisIndex].stInputs.bHomeSensor := FALSE;]]> diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 3cd9c3f..09df352 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 3cd9c3f92b6818c8878f4ec1d10665a8341cbe45 +Subproject commit 09df35232ce29e4ac286712b4664a9cf5babf344 From 211968a18f374b67f585688ed4a30bc7dfd0308f Mon Sep 17 00:00:00 2001 From: kleines Date: Mon, 22 Jun 2020 12:18:36 +0200 Subject: [PATCH 12/12] do not set nResetErrorID to 0 if an error in fbReset occurs --- solution/tc_project_app/tc_mca_std_lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solution/tc_project_app/tc_mca_std_lib b/solution/tc_project_app/tc_mca_std_lib index 09df352..14f8d01 160000 --- a/solution/tc_project_app/tc_mca_std_lib +++ b/solution/tc_project_app/tc_mca_std_lib @@ -1 +1 @@ -Subproject commit 09df35232ce29e4ac286712b4664a9cf5babf344 +Subproject commit 14f8d0185726c02fbec683577613f64e87485d9c