Add method to create larch type data group to phoenix_bec.scripts.phoenix, and data conversion to group for linescan data

phoenix_bec/bec_ipython_client/startup/post_startup.py

@@ -93,6 +93,7 @@ def ph_reload(line):
     print('from phoenix_bec.scripts import phoenix as PH')
     print('phoenix = PH.PhoenixBL()')
     phoenix = PH.PhoenixBL()
+
     #ph_config=PH.PhoenixConfighelper()
 #enddef
 

phoenix_bec/device_configs/phoenix_devices.yaml

@@ -4,7 +4,7 @@
 #
 #
 ####################################################:
-TTL:
+PH_TTL:
   description: PHOENIX TTL trigger
   deviceClass: phoenix_bec.devices.phoenix_trigger.PhoenixTrigger
   deviceConfig:
@@ -15,9 +15,59 @@ TTL:
   - phoenix_devices.yaml
   onFailure: buffer
   enabled: true
-  readoutPriority: async
+  readoutPriority: monitored
   softwareTrigger: false
 
+
+PH_Dummy:
+  description: PHOENIX DUMMY DET
+  deviceClass: phoenix_bec.devices.dummy_devices.Dummy_PSIDetector
+  deviceConfig:
+    prefix: 'X07MB-PC-PSCAN:'
+    name: 'Dummy_Detector_PSI_Detector'
+  deviceTags:
+  - phoenix
+  - TTL Trigger
+  - phoenix_devices.yaml
+  - reads channel X07MB-PC-PSCAN.P-P0D0 from DAQ GUI
+  onFailure: buffer
+  enabled: true
+  readoutPriority: monitored
+  softwareTrigger: false
+
+
+
+
+#Dummy_DET:
+#  description: PHOENIX TTL trigger
+#  deviceClass: phoenix_bec.devices.phoenix_trigger.PhoenixTrigger
+#  deviceConfig:
+#    prefix: 'X07MB-PC-PSCAN:'
+#  deviceTags:
+#  - phoenix
+#  - TTL Trigger
+#  - phoenixdevices
+#  onFailure: buffer
+#  enabled: true
+#  readoutPriority: monitored
+#  softwareTrigger: false
+
+#Dummy_DET2:
+#  description: Dummy for psi detector fo testing of algorithm only
+#  deviceClass: phoenix_bec.devices.dummy_devices.Dummy_PSIDetector
+#  deviceConfig:
+#    prefix: 'X07MB-PC-PSCAN:'
+#  deviceTags:
+#  - phoenix
+#  - Dummy_Dummy_PSIDetector
+#  - phoenix_devices.yaml
+#  onFailure: buffer
+#  enabled: true
+#  readoutPriority: monitored
+#  softwareTrigger: false
+
+
+
 ############################
 #
 # MOTORS ES1

phoenix_bec/devices/__init__.py

@@ -1 +1,2 @@
-from .phoenix_trigger import PhoenixTrigger
+from .phoenix_trigger import PhoenixTrigger
+from .dummy_devices import Dummy_PSIDetector

phoenix_bec/devices/dummy_devices.py

@@ -0,0 +1,490 @@
+"""
+This is a copy of psi_detecto_base.py
+with added print sigbnals to understand how it functions
+
+"""
+
+import os
+import threading
+import time
+import traceback
+
+from bec_lib import messages
+from bec_lib.endpoints import MessageEndpoints
+from bec_lib.file_utils import FileWriter
+from bec_lib.logger import bec_logger
+from ophyd import Component, Device, DeviceStatus, Kind
+from ophyd.device import Staged
+
+from ophyd_devices.sim.sim_signals import SetableSignal
+from ophyd_devices.utils import bec_utils
+from ophyd_devices.utils.bec_scaninfo_mixin import BecScaninfoMixin
+from ophyd_devices.utils.errors import DeviceStopError, DeviceTimeoutError
+from ophyd_devices.interfaces.base_classes.psi_detector_base import PSIDetectorBase, CustomDetectorMixin
+
+from ophyd import Component as Cpt
+from ophyd import FormattedComponent as FCpt
+from ophyd import Device, EpicsSignal, EpicsSignalRO
+
+
+logger = bec_logger.logger
+
+
+
+class LogTime():
+
+    def __init__(self):
+        self.t0=time.process_time()
+
+    def p_s(self,x):
+        now=time.process_time()
+        delta=now-self.t0
+        m=str(delta)+' sec '+x
+        logger.success(m)
+        self.t0=now
+
+ll=LogTime()
+
+
+class DetectorInitError(Exception):
+    """Raised when initiation of the device class fails,
+    due to missing device manager or not started in sim_mode."""
+
+
+class SetupDummy(CustomDetectorMixin):
+    """
+    Mixin class for custom detector logic
+
+    This class is used to implement BL specific logic for the detector.
+    It is used in the PSIDetectorBase class.
+
+    For the integration of a new detector, the following functions should
+    help with integrating functionality, but additional ones can be added.
+
+    Check PSIDetectorBase for the functions that are called during relevant function calls of
+    stage, unstage, trigger, stop and _init.
+    """
+
+    def __init__(self, *_args, parent: Device = None, **_kwargs) -> None:
+        self.parent = parent
+
+    def on_init(self) -> None:
+        """
+    def on_stage(self) -> None:e is writing data on disk, this step should include publishing
+        a file_event and file_message to BEC to inform the system where the data is written to.
+
+        IMPORTANT:
+        It must be safe to assume that the device is ready for the scan
+        to start immediately once this function is finished.
+        """
+
+    def on_unstage(self) -> None:
+        """
+        Specify actions to be executed during unstage.
+
+        This step should include checking if the acqusition was successful,
+        and publishing the file location and file event message,
+        with flagged done to BEC.
+        """
+
+    def on_stop(self) -> None:
+        """
+        Specify actions to be executed during stop.
+        This must also set self.parent.stopped to True.
+
+        This step should include stopping the detector and backend service.
+        """
+
+    def on_trigger(self) -> None | DeviceStatus:
+        """
+        Specify actions to be executed upon receiving trigger signal.
+        Return a DeviceStatus object or None
+        """
+
+    def on_pre_scan(self) -> None:
+        """
+        Specify actions to be executed right before a scan starts.
+
+        Only use if needed, and it is recommended to keep this function as short/fast as possible.
+        """
+
+    def on_complete(self) -> None | DeviceStatus:
+        """
+        Specify actions to be executed when the scan is complete.
+
+        This can for instance be to check with the detector and backend if all data is written succsessfully.
+        """
+
+    def publish_file_location(self, done: bool, successful: bool, metadata: dict = None) -> None:
+        """
+        Publish the filepath to REDIS.
+
+        We publish two events here:
+        - file_event: event for the filewriter
+        - public_file: event for any secondary service (e.g. radial integ code)
+
+        Args:
+            done (bool): True if scan is finished
+            successful (bool): True if scan was successful
+            metadata (dict): additional metadata to publish
+        """
+        if metadata is None:
+            metadata = {}
+
+        msg = messages.FileMessage(
+            file_path=self.parent.filepath.get(),
+            done=done,
+            successful=successful,
+            metadata=metadata,
+        )
+        pipe = self.parent.connector.pipeline()
+        self.parent.connector.set_and_publish(
+            MessageEndpoints.public_file(self.parent.scaninfo.scan_id, self.parent.name),
+            msg,
+            pipe=pipe,
+        )
+        self.parent.connector.set_and_publish(
+            MessageEndpoints.file_event(self.parent.name), msg, pipe=pipe
+        )
+        pipe.execute()
+
+    def wait_for_signals(
+        self,
+        signal_conditions: list[tuple],
+        timeout: float,
+        check_stopped: bool = False,
+        interval: float = 0.05,
+        all_signals: bool = False,
+    ) -> bool:
+        """
+        Convenience wrapper to allow waiting for signals to reach a certain condition.
+        For EPICs PVs, an example usage is pasted at the bottom.
+
+        Args:
+            signal_conditions (list[tuple]): tuple of executable calls for conditions (get_current_state, condition) to check
+            timeout (float): timeout in seconds
+            interval (float): interval in seconds
+            all_signals (bool): True if all signals should be True, False if any signal should be True
+
+        Returns:
+            bool: True if all signals are in the desired state, False if timeout is reached
+
+            >>> Example usage for EPICS PVs:
+            >>> self.wait_for_signals(signal_conditions=[(self.acquiring.get, False)], timeout=5, interval=0.05, check_stopped=True, all_signals=True)
+        """
+
+        timer = 0
+        while True:
+            checks = [
+                get_current_state() == condition
+                for get_current_state, condition in signal_conditions
+            ]
+            if check_stopped is True and self.parent.stopped is True:
+                return False
+            if (all_signals and all(checks)) or (not all_signals and any(checks)):
+                return True
+            if timer > timeout:
+                return False
+            time.sleep(interval)
+            timer += interval
+
+    def wait_with_status(
+        self,
+        signal_conditions: list[tuple],
+        timeout: float,
+        check_stopped: bool = False,
+        interval: float = 0.05,
+        all_signals: bool = False,
+        exception_on_timeout: Exception = None,
+    ) -> DeviceStatus:
+        """Utility function to wait for signals in a thread.
+        Returns a DevicesStatus object that resolves either to set_finished or set_exception.
+        The DeviceStatus is attached to the parent device, i.e. the detector object inheriting from PSIDetectorBase.
+
+        Usage:
+        This function should be used to wait for signals to reach a certain condition, especially in the context of
+        on_trigger and on_complete. If it is not used, functions may block and slow down the performance of BEC.
+        It will return a DeviceStatus object that is to be returned from the function. Once the conditions are met,
+        the DeviceStatus will be set to set_finished in case of success or set_exception in case of a timeout or exception.
+        The exception can be specified with the exception_on_timeout argument. The default exception is a TimeoutError.
+
+        Args:
+            signal_conditions (list[tuple]): tuple of executable calls for conditions (get_current_state, condition) to check
+            timeout (float): timeout in seconds
+            check_stopped (bool): True if stopped flag should be checked
+            interval (float): interval in seconds
+            all_signals (bool): True if all signals should be True, False if any signal should be True
+            exception_on_timeout (Exception): Exception to raise on timeout
+
+        Returns:
+            DeviceStatus: DeviceStatus object that resolves either to set_finished or set_exception
+        """
+        if exception_on_timeout is None:
+            exception_on_timeout = DeviceTimeoutError(
+                f"Timeout error for {self.parent.name} while waiting for signals {signal_conditions}"
+            )
+
+        status = DeviceStatus(self.parent)
+
+        # utility function to wrap the wait_for_signals function
+        def wait_for_signals_wrapper(
+            status: DeviceStatus,
+            signal_conditions: list[tuple],
+            timeout: float,
+            check_stopped: bool,
+            interval: float,
+            all_signals: bool,
+            exception_on_timeout: Exception,
+        ):
+            """Convenient wrapper around wait_for_signals to set status based on the result.
+
+            Args:
+                status (DeviceStatus): DeviceStatus object to be set
+                signal_conditions (list[tuple]): tuple of executable calls for conditions (get_current_state, condition) to check
+                timeout (float): timeout in seconds
+                check_stopped (bool): True if stopped flag should be checked
+                interval (float): interval in seconds
+                all_signals (bool): True if all signals should be True, False if any signal should be True
+                exception_on_timeout (Exception): Exception to raise on timeout
+            """
+            try:
+                result = self.wait_for_signals(
+                    signal_conditions, timeout, check_stopped, interval, all_signals
+                )
+                if result:
+                    status.set_finished()
+                else:
+                    if self.parent.stopped:
+                        # INFO This will execute a callback to the parent device.stop() method
+                        status.set_exception(exc=DeviceStopError(f"{self.parent.name} was stopped"))
+                    else:
+                        # INFO This will execute a callback to the parent device.stop() method
+                        status.set_exception(exc=exception_on_timeout)
+            # pylint: disable=broad-except
+            except Exception as exc:
+                content = traceback.format_exc()
+                logger.warning(
+                    f"Error in wait_for_signals in {self.parent.name}; Traceback: {content}"
+                )
+                # INFO This will execute a callback to the parent device.stop() method
+                status.set_exception(exc=exc)
+
+        thread = threading.Thread(
+            target=wait_for_signals_wrapper,
+            args=(
+                status,
+                signal_conditions,
+                timeout,
+                check_stopped,
+                interval,
+                all_signals,
+                exception_on_timeout,
+            ),
+            daemon=True,
+        )
+        thread.start()
+        return status
+
+
+class Dummy_PSIDetector(PSIDetectorBase):
+    """
+    Abstract base class for SLS detectors
+
+    Class attributes:
+        custom_prepare_cls (object): class for custom prepare logic (BL specific)
+
+    Args:
+        prefix (str): EPICS PV prefix for component (optional)
+        name (str): name of the device, as will be reported via read()
+        kind (str): member of class 'ophydobj.Kind', defaults to Kind.normal
+                    omitted -> reado_PSIDetectorBase
+    """
+
+    filepath = Component(SetableSignal, value="", kind=Kind.config)
+
+    custom_prepare_cls =  SetupDummy
+
+    #prefix=X07MB-PC-PSCAN
+
+
+    D  = Cpt(EpicsSignal, 'P-P0D0')  # cont on / off
+
+
+    def __init__(self, prefix="", *, name, kind=None, parent=None, device_manager=None, **kwargs):
+        super().__init__(prefix=prefix, name=name, kind=kind, parent=parent, **kwargs)
+        ll.p_s('Dummy_device   Dummy_PSIDetector.__init__ ')
+        self.stopped = False
+        self.name = name
+        self.service_cfg = None
+        self.scaninfo = None
+        self.filewriter = None
+        if not issubclass(self.custom_prepare_cls, CustomDetectorMixin):
+            raise DetectorInitError("Custom prepare class must be subclass of CustomDetectorMixin")
+        self.custom_prepare = self.custom_prepare_cls(parent=self, **kwargs)
+
+        if device_manager:
+            self._update_service_config()
+            self.device_manager = device_manager
+        else:
+            self.device_manager = bec_utils.DMMock()
+            base_path = kwargs["basepath"] if "basepath" in kwargs else "."
+            self.service_cfg = {"base_path": os.path.abspath(base_path)}
+
+        self.connector = self.device_manager.connector
+        self._update_scaninfo()
+        self._update_filewriter()
+        self._init()
+        ll.p_s('Dummy_device   Dummy_PSIDetector.__init__ .. done ')
+
+
+    def _update_filewriter(self) -> None:
+        """Update filewriter with service config"""
+        ll.p_s('Dummy_device   Dummy_PSIDetector._update_filewriter')
+        self.filewriter = FileWriter(service_config=self.service_cfg, connector=self.connector)
+        ll.p_s('Dummy_device   Dummy_PSIDetector._update_filewriter .. done ')
+
+    def _update_scaninfo(self) -> None:
+        """Update scaninfo from BecScaninfoMixing
+        This depends on device manager and operation/sim_mode
+        """
+        ll.p_s('Dummy_device   Dummy_PSIDetector._update_scaninfo')
+
+        self.scaninfo = BecScaninfoMixin(self.device_manager)
+        self.scaninfo.load_scan_metadata()
+        ll.p_s('Dummy_device   Dummy_PSIDetector._update_scaninfo .. done ')
+
+    def _update_service_config(self) -> None:
+        """Update service config from BEC service config
+
+        If bec services are not running and SERVICE_CONFIG is NONE, we fall back to the current directory.
+        """
+        # pylint: disable=import-outside-toplevel
+
+        from bec_lib.bec_service import SERVICE_CONFIG
+        ll.p_s('Dummy_device   Dummy_PSIDetector._update_service_config')
+
+        if SERVICE_CONFIG:
+            self.service_cfg = SERVICE_CONFIG.config["service_config"]["file_writer"]
+            return
+        self.service_cfg = {"base_path": os.path.abspath(".")}
+        ll.p_s('Dummy_device   Dummy_PSIDetector._update_service_config  .. done')
+
+    def check_scan_id(self) -> None:
+        """Checks if scan_id has changed and set stopped flagged to True if it has."""
+        ll.p_s('Dummy_device   Dummy_PSIDetector.check_scan_id')
+
+        old_scan_id = self.scaninfo.scan_id
+        self.scaninfo.load_scan_metadata()
+        if self.scaninfo.scan_id != old_scan_id:
+            self.stopped = True
+        ll.p_s('Dummy_device   Dummy_PSIDetector.check_scan_id .. done ')
+
+
+    def _init(self) -> None:
+        """Initialize detector, filewriter and set default parameters"""
+        ll.p_s('Dummy_device   Dummy_PSIDetector._init')
+
+        self.custom_prepare.on_init()
+        ll.p_s('Dummy_device   Dummy_PSIDetector._init    ... done ')
+
+
+    def stage(self) -> list[object]:
+        """
+        Stage device in preparation for a scan.
+        First we check if the device is already staged. Stage is idempotent,
+        if staged twice it should raise (we let ophyd.Device handle the raise here).
+        We reset the stopped flag and get the scaninfo from BEC, before calling custom_prepare.on_stage.
+
+        Returns:
+            list(object): list of objects that were staged
+
+        """
+        ll.p_s('Dummy_device   Dummy_PSIDetector.stage')
+
+        if self._staged != Staged.no:
+            return super().stage()
+        self.stopped = False
+        self.scaninfo.load_scan_metadata()
+        self.custom_prepare.on_stage()
+        ll.p_s('Dummy_device   Dummy_PSIDetector.stage    done ')
+
+
+        return super().stage()
+
+    def pre_scan(self) -> None:
+        """Pre-scan logic.
+
+        This function will be called from BEC directly before the scan core starts, and should only implement
+        time-critical actions. Therefore, it should also be kept as short/fast as possible.
+        I.e. Arming a detector in case there is a risk of timing out.
+        """
+        ll.p_s('Dummy_device   Dummy_PSIDetector.pre_scan')
+
+        self.custom_prepare.on_pre_scan()
+        ll.p_s('Dummy_device   Dummy_PSIDetector.pre_scan .. done ')
+
+
+    def trigger(self) -> DeviceStatus:
+        """Trigger the detector, called from BEC."""
+
+        # pylint: disable=assignment-from-no-return
+        ll.p_s('Dummy_device   Dummy_PSIDetector.trigger')
+
+        status = self.custom_prepare.on_trigger()
+        if isinstance(status, DeviceStatus):
+            return status
+        ll.p_s('Dummy_device   Dummy_PSIDetector.trigger.. done ')
+
+        return super().trigger()
+
+    def complete(self) -> None:
+        """Complete the acquisition, called from BEC.
+
+        This function is called after the scan is complete, just before unstage.
+        We can check here with the data backend and detector if the acquisition successfully finished.
+
+        Actions are implemented in custom_prepare.on_complete since they are beamline specific.
+        """
+        # pylint: disable=assignment-from-no-return
+        ll.p_s('Dummy_device   Dummy_PSIDetector.complete')
+
+        status = self.custom_prepare.on_complete()
+        if isinstance(status, DeviceStatus):
+            return status
+        status = DeviceStatus(self)
+        status.set_finished()
+        ll.p_s('Dummy_device   Dummy_PSIDetector.complete ... done ')
+
+        return status
+
+    def unstage(self) -> list[object]:
+        """
+        Unstage device after a scan.
+
+        We first check if the scanID has changed, thus, the scan was unexpectedly interrupted but the device was not stopped.
+        If that is the case, the stopped flag is set to True, which will immediately unstage the device.
+
+        Custom_prepare.on_unstage is called to allow for BL specific logic to be executed.
+
+        Returns:
+            list(object): list of objects that were unstaged
+        """
+        ll.p_s('Dummy_device   Dummy_PSIDetector.unstage')
+        self.check_scan_id()
+        self.custom_prepare.on_unstage()
+        self.stopped = False
+        ll.p_s('Dummy_device   Dummy_PSIDetector.unstage .. done')
+
+        return super().unstage()
+
+    def stop(self, *, success=False) -> None:
+        """
+        Stop the scan, with camera and file writer
+
+        """
+        ll.p_s('Dummy_device   Dummy_PSIDetector.stop')
+        self.custom_prepare.on_stop()
+        super().stop(success=success)
+        self.stopped = True
+        ll.p_s('Dummy_device   Dummy_PSIDetector.stop ... done')
+

phoenix_bec/local_scripts/PhoenixTemplate.py

@@ -26,17 +26,36 @@ phoenix.add_phoenix_config()
 time.sleep(1)
 
 
+s1=scans.line_scan(dev.ScanX,0,0.1,steps=4,exp_time=.2,relative=False,delay=2)
 
-#s1=scans.line_scan(dev.ScanX,0,0.1,steps=4,exp_time=1,relative=False,delay=2)
+s2=scans.phoenix_line_scan(dev.ScanX,0,0.002,steps=4,exp_time=.2,relative=False,delay=2)
 
-s2=scans.phoenix_line_scan(dev.ScanX,0,0.002,steps=4,exp_time=.01,relative=False,delay=2)
+res1 = s1.scan.to_pandas()
+re1  = res1.to_numpy()
+w1=PH.PhGroup('Bec Linescan')
+w1.linescan2group(s1)
+
+print('res1')
+print(res1)
+print('as numpy')
+print('re1')
 
 
+res2 = s2.scan.to_pandas()
+re2  = res2.to_numpy()
+w2=PH.PhGroup('PHOENIX Linescan')
+w2.linescan2group(s2)
+
+print('res2')
+print(res2)
+print('as numpy')
+print('re2')
 
 
-"""
+print (s1)
 print('---------------------------------')
 
+"""
 # scan will not diode
 print(' SCAN DO NOT READ DIODE ')
 dev.PH_curr_conf.readout_priority='baseline'  # do not read detector
@@ -49,9 +68,8 @@ print('elapsed time',(tf-ti)/1e9)
 print(' SCAN READ DIODE ')s is not installed on test system
 ScanX_conf,0,0.002,steps=11,exp_time=.3,relative=False,delay=2)
 
-"""
+
-"""
+#next lines do not work as pandas is not installed on test system
-next lines do not work as pandas is not installed on test system
 
 res1 = s1.scan.to_pandas()
 re1  = res1.to_numpy()
@@ -62,4 +80,5 @@ print('Scan2 at pandas ')
 print(res2)
 print('Scan2 as numpy ')
 print(res2)
-"""
+
+"""

phoenix_bec/local_scripts/test.py

@@ -0,0 +1,3 @@
+import phoenix_bec.scripts.phoenix as PH
+w=PH.PhGroup('labelName')
+w.linescan2group(s1)

phoenix_bec/scans/__init__.py

@@ -1 +1 @@
-from .phoenix_scans import PhoenixLineScan
+from .phoenix_scans import PhoenixLineScan

phoenix_bec/scripts/phoenix.py

@@ -83,3 +83,121 @@ class PhoenixBL():
         print(self.path_phoenix_bec)
         os.system('cat '+self.path_phoenix_bec+'phoenix_bec/scripts/Current_setup.txt')
 
+
+
+
+
+class PhGroup():
+    """
+    Class to create data groups
+    with attributes prvidws as string
+
+    call by
+
+    ww=MakeGroup('YourName')
+
+    it creates a group
+    with default attributes
+
+    ww.GroupName='YourName'
+
+    To add further data use for example by
+
+    ww.newtag=67
+
+    or use meth
+
+
+    """
+
+    def __init__(self,description):
+
+
+        setattr(self,'description',description)
+        # atribute 'label' for compatibility woith La groups...
+        setattr(self,'label',description)
+        #if type(NameTag)==list:
+        #    for i in NameTag:
+        #        setattr(self,i,None)
+        #    #endfor
+        #else:
+        #    setattr(self,NameTag,None)
+        #endif
+
+    def add(self,NameTag,content):
+        """
+        Add tags to group...
+
+        Parameters
+        ----------
+        NameTag : TYPE
+            DESCRIPTION.
+        content : TYPE
+            DESCRIPTION.
+
+        Returns
+        -------
+        None.
+
+        """
+
+        setattr(self,NameTag,content)
+
+    def keys(self):
+
+        """
+        Method gets all atributes, which are not methods
+        and which do not start with __
+
+
+        Returns
+        -------
+        box : TYPE
+            DESCRIPTION.
+
+        """
+        box=[]
+
+        for i in self.__dir__():
+            if '__' not in i:
+                #print(i)
+                if str(type(self.__getattribute__(i))) != "<class 'method'>":
+                    box.append(i)
+            #endif
+        #endfor
+        return box
+
+
+    def linescan2group(self,this_scan):
+        print('keys')
+        print(this_scan.scan.data.keys())
+        for outer_key in this_scan.scan.data.keys():
+            print('outer_key',outer_key)
+            n_outer  = len(this_scan.scan.data.keys())
+            for inner_key in this_scan.scan.data[outer_key].keys():
+                print('inner_key',inner_key)
+                # calculate nunber of points
+                n_inner = len(this_scan.scan.data[outer_key][inner_key].keys())
+                value     = np.zeros(n_inner)
+                timestamp = np.zeros(n_inner)
+                for i in range(n_inner):
+                    try:
+                        value[i]     = this_scan.scan.data[outer_key][inner_key][i]['value']
+                    except:
+                        value=None
+                    try:
+                        timestamp[i] = this_scan.scan.data[outer_key][inner_key][i]['timestamp']
+                    except:
+                        timestamp[i]=None
+                    #endfor
+                    self.add(inner_key+'_'+ outer_key+'_val',value)
+                    self.add(inner_key+'_'+ outer_key+'_ts',timestamp)
+        #endfor
+    #enddef
+
+
+
+
+
+
+