From fa32b4234b786d93ddf872c7a8220f2d0518b465 Mon Sep 17 00:00:00 2001
From: appel_c <christian.appel@psi.ch>
Date: Thu, 17 Oct 2024 07:16:29 +0200
Subject: [PATCH] refactor: cleanup sim module namespace; closes #80

---
 ophyd_devices/sim/sim_data.py       | 28 +---------------------------
 ophyd_devices/sim/sim_positioner.py |  2 +-
 2 files changed, 2 insertions(+), 28 deletions(-)

diff --git a/ophyd_devices/sim/sim_data.py b/ophyd_devices/sim/sim_data.py
index 39478e2..f5532cd 100644
--- a/ophyd_devices/sim/sim_data.py
+++ b/ophyd_devices/sim/sim_data.py
@@ -88,16 +88,7 @@ class SimulatedDataBase(ABC):
     - update_sim_state:             update the simulated state of the device
     """
 
-    # USER_ACCESS = ["params", "select_model", "get_models", "show_all"]
-    # TODO remove
-    USER_ACCESS = [
-        "params",
-        "select_model",
-        "get_models",
-        "show_all",
-        "sim_select_model",
-        "sim_params",
-    ]
+    USER_ACCESS = ["params", "select_model", "get_models", "show_all"]
 
     def __init__(self, *args, parent=None, **kwargs) -> None:
         """
@@ -131,23 +122,6 @@ class SimulatedDataBase(ABC):
             return method(*args, **kwargs)
         raise SimulatedDataException(f"Method {method} is not available for {self.parent.name}")
 
-    # TODO remove after refactoring code in main
-    def sim_select_model(self, model: str) -> None:
-        """Select the active simulation model."""
-        self.select_model(model)
-
-    @property
-    def sim_params(self) -> None:
-        """Set the parameters for the active simulation model."""
-        return self.params
-
-    @sim_params.setter
-    def sim_params(self, params: dict):
-        """Set the parameters for the active simulation model."""
-        self.params = params
-
-    # TODO remove after refactoring code in main
-
     def select_model(self, model: str) -> None:
         """
         Method to select the active simulation model.
diff --git a/ophyd_devices/sim/sim_positioner.py b/ophyd_devices/sim/sim_positioner.py
index fdda85f..9318405 100644
--- a/ophyd_devices/sim/sim_positioner.py
+++ b/ophyd_devices/sim/sim_positioner.py
@@ -42,7 +42,7 @@ class SimPositioner(Device, PositionerBase):
     """
 
     # Specify which attributes are accessible via BEC client
-    USER_ACCESS = ["sim", "readback", "dummy_controller", "registered_proxies"]
+    USER_ACCESS = ["sim", "readback", "registered_proxies"]
 
     sim_cls = SimulatedPositioner