bec/ophyd_devices
0
0
Fork 0
mirror of https://github.com/bec-project/ophyd_devices.git synced 2025-06-06 03:40:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Signal type fix

Browse Source
This commit is contained in:
gac-x06da 2025-03-14 16:08:34 +01:00 committed by mohacsi_i
parent 5b60842eda
commit d516cc01b5
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ophyd_devices/__init__.py
View File

@ -20,3 +20,5 @@ from .devices.softpositioner import SoftPositioner
from .utils.bec_device_base import BECDeviceBase
from .utils.dynamic_pseudo import ComputedSignal
from .utils.static_device_test import launch
from .devices.psi_motor import EpicsMotorMR, EpicsMotorEC

19
ophyd_devices/devices/psi_motor.py
View File

@ -50,9 +50,7 @@ class EpicsMotorMR(EpicsMotor):
# Warn if EPIC motorRecord claims an error (it's not easy to reset)
status = self.motor_status.get()
if status:
self.log.warning(
f"EPICS MotorRecord is in alarm state {status}, ophyd will raise"
)
self.log.warning(f"EPICS MotorRecord is in alarm state {status}, ophyd will raise")
# Warn if trying to move beyond an active limit
# NOTE: VME limit switches active only in the direction of travel (or disconnected)
# NOTE: SoftMotor limits are not propagated at all
@ -83,7 +81,7 @@ class EpicsMotorEC(EpicsMotorMR):
USER_ACCESS = ["reset"]
motor_enable_readback = Component(EpicsSignalRO, "-EnaAct", auto_monitor=True, kind=Kind.normal)
motor_enable = Component(
EpicsSignalRO,
EpicsSignal,
"-EnaCmd-RB",
write_pv="-EnaCmd",
put_complete=True,
@ -132,13 +130,12 @@ class EpicsMotorEC(EpicsMotorMR):
Common error causes:
-------------------------
- MAX_POSITION_LAG_EXCEEDED : The PID tuning is wrong, tolerance is too
low, acceleration is too high, scaling is off, or the motor
lacks torque.
- MAX_VELOCITY_EXCEEDED : PID is wrong or the motor is sticking-slipping
- BOTH_LIMITS_ACTIVE : The motors are probably not connected
- HW_ERROR : Tricky one, usually the drive power supply is cut due to
fuse or safety, might need to push physical buttons.
- MAX_POSITION_LAG_EXCEEDED : The PID tuning is wrong, tolerance is too low, acceleration
is too high, scaling is off, or the motor lacks torque.
- MAX_VELOCITY_EXCEEDED : PID is wrong or the motor is sticking-slipping.
- BOTH_LIMITS_ACTIVE : The motors are probably not connected.
- HW_ERROR : Tricky one, usually the drive power supply is cut due to fuse or safety. You
might need to push physical buttons.
"""
# Reset the error
self.error_reset.set(1, settle_time=0.2).wait()