bec/ophyd_devices
0
0
Fork 0
mirror of https://github.com/bec-project/ophyd_devices.git synced 2025-06-23 11:27:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: fix bug in usage of mock for tests

Browse Source
This commit is contained in:
appel_c
2023-12-12 10:56:25 +01:00
parent 31b964663c
commit c732855314
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/test_delay_generator_csaxs.py
View File

@ -161,7 +161,7 @@ def test_on_pre_scan(mock_DDGSetup, scaninfo, ddg_config_defaults, ddg_config_sc
# Call the function you want to test # Call the function you want to test
mock_DDGSetup.on_pre_scan() mock_DDGSetup.on_pre_scan()
if ddg_config_scan["premove_trigger"]: if ddg_config_scan["premove_trigger"]:
assert mock_DDGSetup.parent.trigger_shot.put.called_once_with(1) mock_DDGSetup.parent.trigger_shot.put.assert_called_once_with(1)
@pytest.mark.parametrize("source", ["SINGLE_SHOT", "EXT_RISING_EDGE"]) @pytest.mark.parametrize("source", ["SINGLE_SHOT", "EXT_RISING_EDGE"])
@ -177,11 +177,11 @@ def test_on_trigger(mock_DDGSetup, scaninfo, ddg_config_defaults, ddg_config_sca
# Call the function you want to test # Call the function you want to test
mock_DDGSetup.parent.source.name = "source" mock_DDGSetup.parent.source.name = "source"
mock_DDGSetup.parent.source.read.return_value = { mock_DDGSetup.parent.source.read.return_value = {
mock_DDGSetup.parent.source.name: {"value": source} mock_DDGSetup.parent.source.name: {"value": getattr(TriggerSource, source)}
} }
mock_DDGSetup.on_trigger() mock_DDGSetup.on_trigger()
if source == "SINGLE_SHOT": if source == "SINGLE_SHOT":
assert mock_DDGSetup.parent.trigger_shot.put.called_once_with(1) mock_DDGSetup.parent.trigger_shot.put.assert_called_once_with(1)
def test_initialize_default_parameter( def test_initialize_default_parameter(
@ -249,7 +249,7 @@ def test_prepare_ddg(
mock_DDGSetup.parent.all_delay_pairs = channel_pairs["all_delay_pairs"] mock_DDGSetup.parent.all_delay_pairs = channel_pairs["all_delay_pairs"]
mock_DDGSetup.prepare_ddg() mock_DDGSetup.prepare_ddg()
assert mock_DDGSetup.parent.set_trigger.called_once_with( mock_DDGSetup.parent.set_trigger.assert_called_once_with(
getattr(TriggerSource, ddg_config_scan["set_trigger_source"]) getattr(TriggerSource, ddg_config_scan["set_trigger_source"])
) )
if scaninfo["scan_type"] == "step": if scaninfo["scan_type"] == "step":
@ -283,15 +283,18 @@ def test_prepare_ddg(
delay_burst = ddg_config_defaults["delay_burst"] delay_burst = ddg_config_defaults["delay_burst"]
num_burst_cycle = scaninfo["num_points"] + ddg_config_defaults["additional_triggers"] num_burst_cycle = scaninfo["num_points"] + ddg_config_defaults["additional_triggers"]
assert mock_DDGSetup.parent.burst_enable.called_once_with( # mock_DDGSetup.parent.burst_enable.assert_called_once_with(
mock.call(num_burst_cycle, delay_burst, total_exposure, config="first") # mock.call(num_burst_cycle, delay_burst, total_exposure, config="first")
# )
mock_DDGSetup.parent.burst_enable.assert_called_once_with(
num_burst_cycle, delay_burst, total_exposure, config="first"
) )
if not ddg_config_scan["trigger_width"]: if not ddg_config_scan["trigger_width"]:
calls = mock.call("width", exp_time) call = mock.call("width", exp_time)
assert mock_DDGSetup.parent.set_channels.has_calls(calls) assert call in mock_DDGSetup.parent.set_channels.mock_calls
else: else:
calls = mock.call("width", ddg_config_scan["trigger_width"]) call = mock.call("width", ddg_config_scan["trigger_width"])
assert mock_DDGSetup.parent.set_channels.has_calls(calls) assert call in mock_DDGSetup.parent.set_channels.mock_calls
if ddg_config_scan["set_high_on_exposure"]: if ddg_config_scan["set_high_on_exposure"]:
calls = [ calls = [
mock.call("width", value, channels=[channel]) mock.call("width", value, channels=[channel])
@ -300,4 +303,5 @@ def test_prepare_ddg(
) )
if value != 0 if value != 0
] ]
assert mock_DDGSetup.parent.set_channels.has_calls(calls) if calls:
assert all(calls in mock_DDGSetup.parent.set_channels.mock_calls)