From 7a97e05e04478394423e398f871629fc9c3ef345 Mon Sep 17 00:00:00 2001 From: wakonig_k Date: Sat, 17 Feb 2024 16:40:01 +0100 Subject: [PATCH] test(flomni): added more tests --- ophyd_devices/rt_lamni/rt_flomni_ophyd.py | 9 ++++--- tests/test_rt_flomni.py | 31 +++++++++++++++++++++++ 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/ophyd_devices/rt_lamni/rt_flomni_ophyd.py b/ophyd_devices/rt_lamni/rt_flomni_ophyd.py index 1627aaf..7d1deb5 100644 --- a/ophyd_devices/rt_lamni/rt_flomni_ophyd.py +++ b/ophyd_devices/rt_lamni/rt_flomni_ophyd.py @@ -298,10 +298,11 @@ class RtFlomniController(RtController): } def laser_tracker_galil_enable(self): - self.get_device_manager().devices.ftrackz.obj.controller.socket_put_confirmed("tracken=1") - self.get_device_manager().devices.ftrackz.obj.controller.socket_put_confirmed("trackyct=0") - self.get_device_manager().devices.ftrackz.obj.controller.socket_put_confirmed("trackzct=0") - self.get_device_manager().devices.ftrackz.obj.controller.socket_put_confirmed("XQ#Tracker") + ftrackz_con = self.get_device_manager().devices.ftrackz.obj.controller + ftrackz_con.socket_put_confirmed("tracken=1") + ftrackz_con.socket_put_confirmed("trackyct=0") + ftrackz_con.socket_put_confirmed("trackzct=0") + ftrackz_con.socket_put_confirmed("XQ#Tracker") def laser_tracker_on_target(self) -> bool: self.laser_update_tracker_info() diff --git a/tests/test_rt_flomni.py b/tests/test_rt_flomni.py index fa754a5..8f2bc27 100644 --- a/tests/test_rt_flomni.py +++ b/tests/test_rt_flomni.py @@ -4,6 +4,7 @@ import pytest from utils import SocketMock from ophyd_devices.rt_lamni import RtFlomniController, RtFlomniMotor +from ophyd_devices.rt_lamni.rt_ophyd import RtError @pytest.fixture() @@ -56,3 +57,33 @@ def test_feedback_enable_with_reset(rt_flomni): rt_flomni.feedback_enable_with_reset() laser_tracker_on.assert_called_once() + + +def test_move_samx_to_scan_region(rt_flomni): + device_manager = rt_flomni.get_device_manager() + device_manager.devices.rtx.user_parameter.get.return_value = 1 + rt_flomni.move_samx_to_scan_region(20, 2) + assert mock.call(b"v0\n") not in rt_flomni.sock.put.mock_calls + assert mock.call(b"v1\n") in rt_flomni.sock.put.mock_calls + + +def test_feedback_enable_without_reset(rt_flomni): + with mock.patch.object(rt_flomni, "set_device_enabled") as set_device_enabled: + with mock.patch.object(rt_flomni, "feedback_is_running", return_value=True): + with mock.patch.object(rt_flomni, "laser_tracker_on") as laser_tracker_on: + rt_flomni.feedback_enable_without_reset() + laser_tracker_on.assert_called_once() + assert mock.call(b"l3\n") in rt_flomni.sock.put.mock_calls + assert mock.call("fsamx", False) in set_device_enabled.mock_calls + assert mock.call("fsamy", False) in set_device_enabled.mock_calls + assert mock.call("foptx", False) in set_device_enabled.mock_calls + assert mock.call("fopty", False) in set_device_enabled.mock_calls + + +def test_feedback_enable_without_reset_raises(rt_flomni): + with mock.patch.object(rt_flomni, "feedback_is_running", return_value=False): + with mock.patch.object(rt_flomni, "laser_tracker_on") as laser_tracker_on: + with pytest.raises(RtError): + rt_flomni.feedback_enable_without_reset() + laser_tracker_on.assert_called_once() + assert mock.call(b"l3\n") in rt_flomni.sock.put.mock_calls