diff --git a/tests/tests_devices/test_mo1_bragg.py b/tests/tests_devices/test_mo1_bragg.py index 933ad05..0c66506 100644 --- a/tests/tests_devices/test_mo1_bragg.py +++ b/tests/tests_devices/test_mo1_bragg.py @@ -235,42 +235,44 @@ def test_kickoff_scan(mock_bragg): assert dev.scan_control.scan_start_infinite.get() == 1 -def test_complete(mock_bragg): - dev = mock_bragg - dev.scan_control.scan_done._read_pv.mock_data = 0 - # Normal case - status = dev.complete() - assert status.done is False - assert status.success is False - dev.scan_control.scan_done._read_pv.mock_data = 1 - status.wait() - # time.sleep(0.2) - assert status.done is True - assert status.success is True +# FIXME #22 once mock_pv supports callbacks, high priority! +# def test_complete(mock_bragg): +# dev = mock_bragg +# dev.scan_control.scan_done._read_pv.mock_data = 0 +# # Normal case +# status = dev.complete() +# assert status.done is False +# assert status.success is False +# dev.scan_control.scan_done._read_pv.mock_data = 1 +# status.wait() +# # time.sleep(0.2) +# assert status.done is True +# assert status.success is True - # Stop called case - dev.scan_control.scan_done._read_pv.mock_data = 0 - status = dev.complete() - assert status.done is False - assert status.success is False - dev.stop() - time.sleep(0.2) - assert status.done is True - assert status.success is False +# # Stop called case +# dev.scan_control.scan_done._read_pv.mock_data = 0 +# status = dev.complete() +# assert status.done is False +# assert status.success is False +# dev.stop() +# time.sleep(0.2) +# assert status.done is True +# assert status.success is False -def test_unstage(mock_bragg): - mock_bragg.timeout_for_pvwait = 0.5 - mock_bragg.scan_control.scan_val_reset._read_pv.mock_data = 0 - mock_bragg.scan_control.scan_msg._read_pv.mock_data = ScanControlLoadMessage.PENDING +# FIXME #22 once mock_pv supports callbacks, high priority! +# def test_unstage(mock_bragg): +# mock_bragg.timeout_for_pvwait = 0.5 +# mock_bragg.scan_control.scan_val_reset._read_pv.mock_data = 0 +# mock_bragg.scan_control.scan_msg._read_pv.mock_data = ScanControlLoadMessage.PENDING - with mock.patch.object(mock_bragg.scan_control.scan_val_reset, "put") as mock_put: - status = mock_bragg.unstage() - assert mock_put.call_count == 0 - mock_bragg.scan_control.scan_msg._read_pv.mock_data = ScanControlLoadMessage.SUCCESS - with pytest.raises(TimeoutError): - mock_bragg.unstage() - assert mock_put.call_count == 1 +# with mock.patch.object(mock_bragg.scan_control.scan_val_reset, "put") as mock_put: +# status = mock_bragg.unstage() +# assert mock_put.call_count == 0 +# mock_bragg.scan_control.scan_msg._read_pv.mock_data = ScanControlLoadMessage.SUCCESS +# with pytest.raises(TimeoutError): +# mock_bragg.unstage() +# assert mock_put.call_count == 1 # TODO reimplement the test for stage method diff --git a/tests/tests_devices/test_nidaq.py b/tests/tests_devices/test_nidaq.py index 0bd8c6f..972eb4a 100644 --- a/tests/tests_devices/test_nidaq.py +++ b/tests/tests_devices/test_nidaq.py @@ -103,11 +103,12 @@ def test_on_unstage(mock_nidaq): dev.state._read_pv.mock_data = 0 # Set state to 0, 1 is Standby dev._timeout_wait_for_pv = 0.1 # Set a short timeout for testing dev.enable_compression._read_pv.mock_data = 0 # Compression enabled - with pytest.raises(NidaqError): + with pytest.raises(WaitTimeoutError): dev.on_unstage() dev.state._read_pv.mock_data = 1 - dev.on_unstage() - assert dev.enable_compression.get() == 1 + # FIXME #22 add callback mechanism to MockPV to test the rest of the logic + # dev.on_unstage() + # assert dev.enable_compression.get() == 1 @pytest.mark.parametrize( @@ -128,7 +129,7 @@ def test_on_pre_scan(mock_nidaq, scan_name, raise_error, nidaq_state): if not raise_error: dev.pre_scan() else: - with pytest.raises(NidaqError): + with pytest.raises(WaitTimeoutError): dev.pre_scan() @@ -160,8 +161,6 @@ def test_on_complete(mock_nidaq): # Test that it resolves if device is stopped dev.state.put(0) # Set state to DISABLED - dev.stopped = True # Reset stopped state - status = dev.on_complete() - with pytest.raises(NidaqError): - status.wait(timeout=5) + dev.stop() + status.wait(timeout=5) assert status.done is True