x01dcandClaude Sonnet 5
5e26b86d03
Restores the legacy spec behavior of drawing a fresh random offset (uniform in [0, step)) per call and shifting the sampling lattice by it before the FOV crop check -- decorrelates position-tied reconstruction errors that otherwise accumulate into ring artifacts across a ptycho-tomography series. Applied identically to all three generators (get_flomni_fermat_spiral_pos, get_omny_fermat_spiral_pos, get_lamni_fermat_spiral_pos), same scalar offset for x and y, matching the historical spec. New `seed` parameter (default None = fresh randomization) allows deterministic/reproducible calls. The four call sites that predict Fermat point counts ahead of a real scan (flomni.py/lamni.py's _expected_fermat_position_count(), tomo_params.py's _compute_fermat_positions_flomni/_lamni) now pin seed=0 so their own estimates stay reproducible across repeated calls; their docstrings note the real scan's count can differ by a point or two near the threshold due to the randomization. Updated the affected tests to compare against a matching seed=0 instead of an independent random draw. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lx3KffiFyyDMKT8vvPENUW
Getting Started with Testing using pytest
BEC is using the pytest framework. It can be installed via
pip install pytest
in your python environment.
We note that pytest is part of the optional-dependencies [dev] of the plugin package.
Introduction
Tests in this package should be stored in the tests directory.
We suggest to sort tests of different submodules, i.e. scans or devices in the respective folder structure, and to folow a naming convention of <test_module_name.py>.
It is mandatory for test files to begin with test_ for pytest to discover them.
To run all tests, navigate to the directory of the plugin from the command line, and run the command
pytest -v --random-order ./tests
Note, the python environment needs to be active.
The additional arg -v allows pytest to run in verbose mode which provides more detailed information about the tests being run.
The argument --random-order instructs pytest to run the tests in random order, which is the default in the CI pipelines.
Test examples
Writing tests can be quite specific for the given function. We recommend writing tests as isolated as possible, i.e. try to test single functions instead of full classes. A very useful class to enable isolated testing is MagicMock. In addition, we also recommend to take a look at the How-to guides from pytest.