x01dcandClaude Sonnet 5
2eaa609d29
write_to_scilog()/write_pdf_report() used the old bec.logbook/client.logbook. send_logbook_message() API, which has no "is scilog even configured" check. Confirmed live: on a session without scilog credentials (this dev deployment has no /etc/bec/secrets/.scilog.env at all), send() blocks indefinitely instead of failing fast -- a real tomo_scan() hung inside _write_subtomo_to_scilog() for 29+ minutes during Phase 1 live testing. flomni already migrated off this API to bec.messaging.scilog, which gates every send behind scilog._enabled (published from the deployment's actual scilog config) -- per Mirko's direction, ported the same mechanism to both OMNY call sites, matching flomni's write_pdf_report()/_scilog_write() exactly rather than merely adding an active_account check. Added 3 unit tests locking in the _enabled gate (skip when disabled, send when enabled, tolerate a send() exception). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLrD7sVYGLAzsQjLVJpCgt
Getting Started with Testing using pytest
BEC is using the pytest framework. It can be installed via
pip install pytest
in your python environment.
We note that pytest is part of the optional-dependencies [dev] of the plugin package.
Introduction
Tests in this package should be stored in the tests directory.
We suggest to sort tests of different submodules, i.e. scans or devices in the respective folder structure, and to folow a naming convention of <test_module_name.py>.
It is mandatory for test files to begin with test_ for pytest to discover them.
To run all tests, navigate to the directory of the plugin from the command line, and run the command
pytest -v --random-order ./tests
Note, the python environment needs to be active.
The additional arg -v allows pytest to run in verbose mode which provides more detailed information about the tests being run.
The argument --random-order instructs pytest to run the tests in random order, which is the default in the CI pipelines.
Test examples
Writing tests can be quite specific for the given function. We recommend writing tests as isolated as possible, i.e. try to test single functions instead of full classes. A very useful class to enable isolated testing is MagicMock. In addition, we also recommend to take a look at the How-to guides from pytest.