fix(LamNI): ensure OSA is out before requesting the FZP-centre click
Both align() and find_rotation_center() moved the FZP in and immediately asked the operator to click its centre, but only confirmed OSA was out afterwards (via loptics_out(), which runs after that click). If OSA was left in from a previous scan setup, it would still be in the beam path during the FZP reference click. Add an explicit losa_out() call right before lfzp_in() in both procedures; it's a cheap, skip-if-already-out no-op otherwise. Found while testing find_rotation_center() against the simulated LamNI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -155,6 +155,7 @@ def _make_calibration_align(client):
|
||||
align.lamni.xeyegui = mock.MagicMock()
|
||||
align.lamni.lfzp_in = mock.MagicMock()
|
||||
align.lamni.loptics_out = mock.MagicMock()
|
||||
align.lamni.losa_out = mock.MagicMock()
|
||||
align.lamni.lamnigui_show_xeyealign = mock.MagicMock()
|
||||
# Replace the real Scans proxy (which would try to talk to a live scan
|
||||
# server) with a plain mock -- these tests only care that
|
||||
|
||||
Reference in New Issue
Block a user