From f88dfc8f1bbc0819736a4f32bf21682366fd3437 Mon Sep 17 00:00:00 2001 From: appel_c Date: Fri, 11 Apr 2025 18:50:24 +0200 Subject: [PATCH] refactor: add pragma no cover to various TYPE_CHECKING --- bec_widgets/utils/bec_dispatcher.py | 2 +- bec_widgets/utils/colors.py | 2 +- bec_widgets/utils/rpc_server.py | 2 +- bec_widgets/widgets/containers/dock/dock.py | 2 +- .../widgets/editors/scan_metadata/_metadata_widgets.py | 2 +- bec_widgets/widgets/editors/scan_metadata/_util.py | 2 +- bec_widgets/widgets/editors/scan_metadata/scan_metadata.py | 2 +- .../widgets/services/bec_status_box/bec_status_box.py | 2 +- .../services/device_browser/device_item/device_item.py | 2 +- bec_widgets/widgets/utility/logpanel/logpanel.py | 5 ++++- tests/unit_tests/test_device_browser.py | 2 +- 11 files changed, 14 insertions(+), 11 deletions(-) diff --git a/bec_widgets/utils/bec_dispatcher.py b/bec_widgets/utils/bec_dispatcher.py index 1a647584..d92d77ea 100644 --- a/bec_widgets/utils/bec_dispatcher.py +++ b/bec_widgets/utils/bec_dispatcher.py @@ -16,7 +16,7 @@ from qtpy.QtCore import Signal as pyqtSignal logger = bec_logger.logger -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from bec_lib.endpoints import EndpointInfo from bec_widgets.utils.rpc_server import RPCServer diff --git a/bec_widgets/utils/colors.py b/bec_widgets/utils/colors.py index e07d0aed..412bbc12 100644 --- a/bec_widgets/utils/colors.py +++ b/bec_widgets/utils/colors.py @@ -11,7 +11,7 @@ from pydantic_core import PydanticCustomError from qtpy.QtGui import QColor from qtpy.QtWidgets import QApplication -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from bec_qthemes._main import AccentColors diff --git a/bec_widgets/utils/rpc_server.py b/bec_widgets/utils/rpc_server.py index 0db34b0b..c6ee70d1 100644 --- a/bec_widgets/utils/rpc_server.py +++ b/bec_widgets/utils/rpc_server.py @@ -19,7 +19,7 @@ from bec_widgets.utils import BECDispatcher from bec_widgets.utils.bec_connector import BECConnector from bec_widgets.utils.error_popups import ErrorPopupUtility -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from bec_lib import messages from qtpy.QtCore import QObject else: diff --git a/bec_widgets/widgets/containers/dock/dock.py b/bec_widgets/widgets/containers/dock/dock.py index 9dc0da24..20b74c42 100644 --- a/bec_widgets/widgets/containers/dock/dock.py +++ b/bec_widgets/widgets/containers/dock/dock.py @@ -15,7 +15,7 @@ from bec_widgets.utils.container_utils import WidgetContainerUtils logger = bec_logger.logger -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from qtpy.QtWidgets import QWidget from bec_widgets.widgets.containers.dock.dock_area import BECDockArea diff --git a/bec_widgets/widgets/editors/scan_metadata/_metadata_widgets.py b/bec_widgets/widgets/editors/scan_metadata/_metadata_widgets.py index d0297105..8b48a639 100644 --- a/bec_widgets/widgets/editors/scan_metadata/_metadata_widgets.py +++ b/bec_widgets/widgets/editors/scan_metadata/_metadata_widgets.py @@ -33,7 +33,7 @@ from bec_widgets.widgets.editors.scan_metadata._util import ( field_precision, ) -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from pydantic.fields import FieldInfo logger = bec_logger.logger diff --git a/bec_widgets/widgets/editors/scan_metadata/_util.py b/bec_widgets/widgets/editors/scan_metadata/_util.py index 8009c34a..dfe373de 100644 --- a/bec_widgets/widgets/editors/scan_metadata/_util.py +++ b/bec_widgets/widgets/editors/scan_metadata/_util.py @@ -9,7 +9,7 @@ from annotated_types import Ge, Gt, Le, Lt from bec_lib.logger import bec_logger from pydantic_core import PydanticUndefined -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from pydantic.fields import FieldInfo logger = bec_logger.logger diff --git a/bec_widgets/widgets/editors/scan_metadata/scan_metadata.py b/bec_widgets/widgets/editors/scan_metadata/scan_metadata.py index 7bd5038c..0dc8207d 100644 --- a/bec_widgets/widgets/editors/scan_metadata/scan_metadata.py +++ b/bec_widgets/widgets/editors/scan_metadata/scan_metadata.py @@ -29,7 +29,7 @@ from bec_widgets.widgets.editors.scan_metadata.additional_metadata_table import AdditionalMetadataTable, ) -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from pydantic.fields import FieldInfo logger = bec_logger.logger diff --git a/bec_widgets/widgets/services/bec_status_box/bec_status_box.py b/bec_widgets/widgets/services/bec_status_box/bec_status_box.py index e003694e..ff21b85f 100644 --- a/bec_widgets/widgets/services/bec_status_box/bec_status_box.py +++ b/bec_widgets/widgets/services/bec_status_box/bec_status_box.py @@ -16,7 +16,7 @@ from bec_widgets.utils.bec_widget import BECWidget from bec_widgets.utils.compact_popup import CompactPopupWidget from bec_widgets.widgets.services.bec_status_box.status_item import StatusItem -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from bec_lib.client import BECClient # TODO : Put normal imports back when Pydantic gets faster diff --git a/bec_widgets/widgets/services/device_browser/device_item/device_item.py b/bec_widgets/widgets/services/device_browser/device_item/device_item.py index 2571b27a..4d0f4186 100644 --- a/bec_widgets/widgets/services/device_browser/device_item/device_item.py +++ b/bec_widgets/widgets/services/device_browser/device_item/device_item.py @@ -7,7 +7,7 @@ from qtpy.QtCore import QMimeData, Qt from qtpy.QtGui import QDrag from qtpy.QtWidgets import QApplication, QHBoxLayout, QLabel, QWidget -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from qtpy.QtGui import QMouseEvent logger = bec_logger.logger diff --git a/bec_widgets/widgets/utility/logpanel/logpanel.py b/bec_widgets/widgets/utility/logpanel/logpanel.py index 9ada1872..a8299dd9 100644 --- a/bec_widgets/widgets/utility/logpanel/logpanel.py +++ b/bec_widgets/widgets/utility/logpanel/logpanel.py @@ -8,7 +8,7 @@ import re from collections import deque from functools import partial, reduce from re import Pattern -from typing import Literal +from typing import TYPE_CHECKING, Literal from bec_lib.client import BECClient from bec_lib.connector import ConnectorBase @@ -52,6 +52,9 @@ from bec_widgets.widgets.utility.logpanel._util import ( simple_color_format, ) +if TYPE_CHECKING: # pragma: no cover + from PySide6.QtCore import SignalInstance + logger = bec_logger.logger MODULE_PATH = os.path.dirname(os.path.dirname(os.path.dirname(__file__))) diff --git a/tests/unit_tests/test_device_browser.py b/tests/unit_tests/test_device_browser.py index 1a4ce4a1..b7559e4d 100644 --- a/tests/unit_tests/test_device_browser.py +++ b/tests/unit_tests/test_device_browser.py @@ -8,7 +8,7 @@ from bec_widgets.widgets.services.device_browser.device_browser import DeviceBro from .client_mocks import mocked_client -if TYPE_CHECKING: +if TYPE_CHECKING: # pragma: no cover from qtpy.QtWidgets import QListWidgetItem from bec_widgets.widgets.services.device_browser import DeviceItem