bec/bec_widgets
0
0
Fork 0
mirror of https://github.com/bec-project/bec_widgets.git synced 2025-07-14 11:41:49 +02:00
Code Activity

fix: add missing close() call, ensure jupyter console client.shutdown() is called in closeEvent

Browse Source
This commit is contained in:
guijar_m
2024-07-12 14:50:38 +02:00
parent c7feb6952d
commit e52ee2604c
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bec_widgets/examples/jupyter_console/jupyter_console_window.py
View File

@ -175,12 +175,11 @@ class JupyterConsoleWindow(QWidget): # pragma: no cover:
def closeEvent(self, event): def closeEvent(self, event):
"""Override to handle things when main window is closed.""" """Override to handle things when main window is closed."""
self.dock.clear_all()
self.dock.cleanup() self.dock.cleanup()
self.dock.close() self.dock.close()
self.figure.clear_all()
self.figure.cleanup() self.figure.cleanup()
self.figure.close() self.figure.close()
self.console.close()
super().closeEvent(event) super().closeEvent(event)

6
bec_widgets/widgets/jupyter_console/jupyter_console.py
View File

@ -10,6 +10,7 @@ class BECJupyterConsole(RichJupyterWidget): # pragma: no cover:
super().__init__() super().__init__()
self.inprocess = None self.inprocess = None
self.client = None
self.kernel_manager, self.kernel_client = self._init_kernel(inprocess=inprocess) self.kernel_manager, self.kernel_client = self._init_kernel(inprocess=inprocess)
self.set_default_style("linux") self.set_default_style("linux")
@ -60,6 +61,11 @@ class BECJupyterConsole(RichJupyterWidget): # pragma: no cover:
self.kernel_client.stop_channels() self.kernel_client.stop_channels()
self.kernel_manager.shutdown_kernel() self.kernel_manager.shutdown_kernel()
def closeEvent(self, event):
self.shutdown_kernel()
if self.client:
self.client.shutdown()
if __name__ == "__main__": # pragma: no cover if __name__ == "__main__": # pragma: no cover
import sys import sys