From c70ddb3cb19fecf7ce14b551d7d265e2e0cff357 Mon Sep 17 00:00:00 2001
From: wyzula-jan <133381102+wyzula-jan@users.noreply.github.com>
Date: Sun, 19 Nov 2023 19:24:01 +0100
Subject: [PATCH] feat: editor.py added splitter between editor and terminal

---
 bec_widgets/widgets/editor/editor.py   | 13 ++++++++++---
 bec_widgets/widgets/toolbar/toolbar.py | 18 ++++++++++++++----
 2 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/bec_widgets/widgets/editor/editor.py b/bec_widgets/widgets/editor/editor.py
index 8f0ac676..651b42dc 100644
--- a/bec_widgets/widgets/editor/editor.py
+++ b/bec_widgets/widgets/editor/editor.py
@@ -1,6 +1,8 @@
 import subprocess
 
 import qdarktheme
+from qtpy.QtCore import Qt
+from qtpy.QtWidgets import QSplitter
 from qtpy.Qsci import QsciScintilla, QsciLexerPython
 from qtpy.QtCore import QFile, QTextStream, Signal, QThread
 from qtpy.QtGui import QColor, QFont
@@ -58,9 +60,14 @@ class BECEditor(QWidget):
             self.toolbar = ModularToolBar(self)
             self.layout.addWidget(self.toolbar)
 
-        self.layout.addWidget(self.toolbar)
-        self.layout.addWidget(self.editor)
-        self.layout.addWidget(self.terminal)
+        # Initialize the splitter
+        self.splitter = QSplitter(Qt.Orientation.Vertical, self)
+        self.splitter.addWidget(self.editor)
+        self.splitter.addWidget(self.terminal)
+        # self.splitter.setSizes([400, 100]) #todo optional to set sizes
+
+        # Add Splitter to layout
+        self.layout.addWidget(self.splitter)
         self.setLayout(self.layout)
 
         self.setupEditor()
diff --git a/bec_widgets/widgets/toolbar/toolbar.py b/bec_widgets/widgets/toolbar/toolbar.py
index 775f4ccf..7e3d94be 100644
--- a/bec_widgets/widgets/toolbar/toolbar.py
+++ b/bec_widgets/widgets/toolbar/toolbar.py
@@ -1,6 +1,7 @@
 from abc import ABC, abstractmethod
 
-from qtpy.QtWidgets import QToolBar
+from qtpy.QtCore import QSize
+from qtpy.QtWidgets import QToolBar, QStyle, QApplication
 from qtpy.QtCore import QTimer
 from qtpy.QtGui import QAction
 from qtpy.QtWidgets import QWidget
@@ -14,21 +15,27 @@ class ToolBarAction(ABC):
 
 class OpenFileAction:  # (ToolBarAction):
     def create(self, target: QWidget):
-        action = QAction("Open File", target)
+        icon = QApplication.style().standardIcon(QStyle.StandardPixmap.SP_DialogOpenButton)
+        action = QAction(icon, "Open File", target)
+        # action = QAction("Open File", target)
         action.triggered.connect(target.openFile)
         return action
 
 
 class SaveFileAction:
     def create(self, target):
-        action = QAction("Save File", target)
+        icon = QApplication.style().standardIcon(QStyle.StandardPixmap.SP_DialogSaveButton)
+        action = QAction(icon, "Save File", target)
+        # action = QAction("Save File", target)
         action.triggered.connect(target.saveFile)
         return action
 
 
 class RunScriptAction:
     def create(self, target):
-        action = QAction("Run Script", target)
+        icon = QApplication.style().standardIcon(QStyle.StandardPixmap.SP_MediaPlay)
+        action = QAction(icon, "Run Script", target)
+        # action = QAction("Run Script", target)
         action.triggered.connect(target.runScript)
         return action
 
@@ -42,6 +49,9 @@ class ModularToolBar(QToolBar):
             # BECMonitor: [SomeOtherAction(), AnotherAction()],  # Example for another widget
         }
         self.setStyleSheet("QToolBar { background: transparent; }")
+        # Set the icon size for the toolbar
+        self.setIconSize(QSize(20, 20))
+
         if self.auto_init:
             QTimer.singleShot(0, self.auto_detect_and_populate)