From a3d4f5ac4bc52acfed2791a1724fade6972ed320 Mon Sep 17 00:00:00 2001 From: wakonig_k Date: Wed, 7 Aug 2024 11:15:14 +0200 Subject: [PATCH] fix(website): fixed teardown of website widgets --- bec_widgets/widgets/website/website.py | 6 ++++++ tests/unit_tests/test_vscode_widget.py | 4 ++-- tests/unit_tests/test_website_widget.py | 2 -- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/bec_widgets/widgets/website/website.py b/bec_widgets/widgets/website/website.py index a23a4e80..be3044ba 100644 --- a/bec_widgets/widgets/website/website.py +++ b/bec_widgets/widgets/website/website.py @@ -64,6 +64,12 @@ class WebsiteWidget(BECWidget, QWebEngineView): """ QWebEngineView.forward(self) + def cleanup(self): + """ + Cleanup the widget + """ + self.page().deleteLater() + if __name__ == "__main__": import sys diff --git a/tests/unit_tests/test_vscode_widget.py b/tests/unit_tests/test_vscode_widget.py index 82c770f2..c8d07e1b 100644 --- a/tests/unit_tests/test_vscode_widget.py +++ b/tests/unit_tests/test_vscode_widget.py @@ -14,9 +14,9 @@ from .client_mocks import mocked_client def vscode_widget(qtbot, mocked_client): with mock.patch("bec_widgets.widgets.vscode.vscode.subprocess.Popen") as mock_popen: widget = VSCodeEditor(client=mocked_client) - # qtbot.addWidget(widget) + qtbot.addWidget(widget) + qtbot.waitExposed(widget) yield widget - # widget.close() def test_vscode_widget(qtbot, vscode_widget): diff --git a/tests/unit_tests/test_website_widget.py b/tests/unit_tests/test_website_widget.py index 16028913..5ee1ac6b 100644 --- a/tests/unit_tests/test_website_widget.py +++ b/tests/unit_tests/test_website_widget.py @@ -12,8 +12,6 @@ def website_widget(qtbot, mocked_client): qtbot.addWidget(widget) qtbot.waitExposed(widget) yield widget - widget.page().deleteLater() - qtbot.wait(1000) def test_website_widget_set_url(website_widget):