From 91050e88aea2fdcb479fef2bf7e14a24dcb668ba Mon Sep 17 00:00:00 2001 From: wyzula-jan Date: Wed, 14 Jan 2026 17:16:01 +0100 Subject: [PATCH] refactor(advanced_dock_area): change remove_widget to delete --- bec_widgets/cli/client.py | 12 ++++++------ .../advanced_dock_area/advanced_dock_area.py | 2 +- .../containers/advanced_dock_area/basic_dock_area.py | 6 +++--- tests/unit_tests/test_advanced_dock_area.py | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/bec_widgets/cli/client.py b/bec_widgets/cli/client.py index 6568ad9d..a224c2a0 100644 --- a/bec_widgets/cli/client.py +++ b/bec_widgets/cli/client.py @@ -182,7 +182,7 @@ class AdvancedDockArea(RPCBase): """ @rpc_call - def remove_widget(self, object_name: "str") -> "bool": + def delete(self, object_name: "str") -> "bool": """ Remove a widget from the dock area by its object name. @@ -196,7 +196,7 @@ class AdvancedDockArea(RPCBase): ValueError: If no widget with the given object name is found. Example: - >>> dock_area.remove_widget("my_widget") + >>> dock_area.delete("my_widget") True """ @@ -1207,7 +1207,7 @@ class DockAreaWidget(RPCBase): """ @rpc_call - def remove_widget(self, object_name: "str") -> "bool": + def delete(self, object_name: "str") -> "bool": """ Remove a widget from the dock area by its object name. @@ -1221,7 +1221,7 @@ class DockAreaWidget(RPCBase): ValueError: If no widget with the given object name is found. Example: - >>> dock_area.remove_widget("my_widget") + >>> dock_area.delete("my_widget") True """ @@ -2895,7 +2895,7 @@ class MonacoDock(RPCBase): """ @rpc_call - def remove_widget(self, object_name: "str") -> "bool": + def delete(self, object_name: "str") -> "bool": """ Remove a widget from the dock area by its object name. @@ -2909,7 +2909,7 @@ class MonacoDock(RPCBase): ValueError: If no widget with the given object name is found. Example: - >>> dock_area.remove_widget("my_widget") + >>> dock_area.delete("my_widget") True """ diff --git a/bec_widgets/widgets/containers/advanced_dock_area/advanced_dock_area.py b/bec_widgets/widgets/containers/advanced_dock_area/advanced_dock_area.py index 5b8edd4e..d913df00 100644 --- a/bec_widgets/widgets/containers/advanced_dock_area/advanced_dock_area.py +++ b/bec_widgets/widgets/containers/advanced_dock_area/advanced_dock_area.py @@ -100,7 +100,7 @@ class AdvancedDockArea(DockAreaWidget): "workspace_is_locked", "attach_all", "delete_all", - "remove_widget", + "delete", "set_layout_ratios", "describe_layout", "mode", diff --git a/bec_widgets/widgets/containers/advanced_dock_area/basic_dock_area.py b/bec_widgets/widgets/containers/advanced_dock_area/basic_dock_area.py index 5822f501..a3e71b0c 100644 --- a/bec_widgets/widgets/containers/advanced_dock_area/basic_dock_area.py +++ b/bec_widgets/widgets/containers/advanced_dock_area/basic_dock_area.py @@ -54,7 +54,7 @@ class DockAreaWidget(BECWidget, QWidget): "widget_list", "attach_all", "delete_all", - "remove_widget", + "delete", "set_layout_ratios", "describe_layout", "print_layout_structure", @@ -1377,7 +1377,7 @@ class DockAreaWidget(BECWidget, QWidget): ) @SafeSlot(str) - def remove_widget(self, object_name: str) -> bool: + def delete(self, object_name: str) -> bool: """ Remove a widget from the dock area by its object name. @@ -1391,7 +1391,7 @@ class DockAreaWidget(BECWidget, QWidget): ValueError: If no widget with the given object name is found. Example: - >>> dock_area.remove_widget("my_widget") + >>> dock_area.delete("my_widget") True """ dock_map = self.dock_map() diff --git a/tests/unit_tests/test_advanced_dock_area.py b/tests/unit_tests/test_advanced_dock_area.py index d7abcefa..0430af7d 100644 --- a/tests/unit_tests/test_advanced_dock_area.py +++ b/tests/unit_tests/test_advanced_dock_area.py @@ -293,7 +293,7 @@ class TestBasicDockArea: assert "panel_two" in basic_dock_area.dock_map() # Remove panel_one - result = basic_dock_area.remove_widget("panel_one") + result = basic_dock_area.delete("panel_one") qtbot.wait(100) assert result is True