bec/bec_widgets
0
0
Fork 0
mirror of https://github.com/bec-project/bec_widgets.git synced 2025-07-14 03:31:50 +02:00
Code Activity

fix(bec_figure): waveforms can be initialised from the config; widgets are deleteLater after removal

Browse Source
This commit is contained in:
wyzula_j
2024-06-27 11:03:29 +02:00
parent c6a14c0768
commit 78673ea11a
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bec_widgets/widgets/figure/figure.py
View File

@ -364,6 +364,7 @@ class BECFigure(BECConnector, pg.GraphicsLayoutWidget):
label: str | None = None, label: str | None = None,
validate: bool = True, validate: bool = True,
dap: str | None = None, dap: str | None = None,
config: dict | None = None, # TODO make logic more transparent
**axis_kwargs, **axis_kwargs,
) -> BECWaveform: ) -> BECWaveform:
""" """
@ -383,11 +384,16 @@ class BECFigure(BECConnector, pg.GraphicsLayoutWidget):
label(str): The label of the curve. label(str): The label of the curve.
validate(bool): If True, validate the device names and entries. validate(bool): If True, validate the device names and entries.
dap(str): The DAP model to use for the curve. dap(str): The DAP model to use for the curve.
config(dict): Recreates the whole BECWaveform widget from provided configuration.
**axis_kwargs: Additional axis properties to set on the widget after creation. **axis_kwargs: Additional axis properties to set on the widget after creation.
Returns: Returns:
BECWaveform: The waveform plot widget. BECWaveform: The waveform plot widget.
""" """
if config is not None:
waveform = self.add_plot(config=config, **axis_kwargs)
return waveform
waveform = WidgetContainerUtils.find_first_widget_by_class( waveform = WidgetContainerUtils.find_first_widget_by_class(
self._widgets, BECWaveform, can_fail=True self._widgets, BECWaveform, can_fail=True
) )
@ -756,6 +762,7 @@ class BECFigure(BECConnector, pg.GraphicsLayoutWidget):
self._reindex_grid() self._reindex_grid()
if widget_id in self.config.widgets: if widget_id in self.config.widgets:
self.config.widgets.pop(widget_id) self.config.widgets.pop(widget_id)
widget.deleteLater()
else: else:
raise ValueError(f"Widget with ID '{widget_id}' does not exist.") raise ValueError(f"Widget with ID '{widget_id}' does not exist.")