From 7484f5160c8c6d632fd27996035ff6c0dda2e657 Mon Sep 17 00:00:00 2001 From: wyzula-jan Date: Sun, 22 Jun 2025 18:04:19 +0200 Subject: [PATCH] fix(launch_window): number of remaining connections extended to 4 --- bec_widgets/applications/launch_window.py | 2 +- tests/end-2-end/test_rpc_widgets_e2e.py | 2 +- tests/unit_tests/test_launch_window.py | 38 +++++++++++++++++++++++ 3 files changed, 40 insertions(+), 2 deletions(-) diff --git a/bec_widgets/applications/launch_window.py b/bec_widgets/applications/launch_window.py index 56c13b8e..99cf7c8f 100644 --- a/bec_widgets/applications/launch_window.py +++ b/bec_widgets/applications/launch_window.py @@ -542,7 +542,7 @@ class LaunchWindow(BECMainWindow): remaining_connections = [ connection for connection in connections.values() if connection.parent_id != self.gui_id ] - return len(remaining_connections) <= 2 + return len(remaining_connections) <= 4 def _turn_off_the_lights(self, connections: dict): """ diff --git a/tests/end-2-end/test_rpc_widgets_e2e.py b/tests/end-2-end/test_rpc_widgets_e2e.py index 175e642d..97f54380 100644 --- a/tests/end-2-end/test_rpc_widgets_e2e.py +++ b/tests/end-2-end/test_rpc_widgets_e2e.py @@ -79,7 +79,7 @@ def test_available_widgets(qtbot, connected_client_gui_obj): gui = connected_client_gui_obj dock_area = gui.bec # Number of top level widgets, should be 4 - top_level_widgets_count = 8 + top_level_widgets_count = 12 assert len(gui._server_registry) == top_level_widgets_count # Number of widgets with parent_id == None, should be 2 widgets = [ diff --git a/tests/unit_tests/test_launch_window.py b/tests/unit_tests/test_launch_window.py index 4cad21e5..e8298829 100644 --- a/tests/unit_tests/test_launch_window.py +++ b/tests/unit_tests/test_launch_window.py @@ -109,6 +109,25 @@ def test_launch_window_launch_plugin_auto_update(bec_launch_window): "dock_area": mock.MagicMock(), "scan_progress": mock.MagicMock(), }, + False, + ), + ( + { + "launcher": mock.MagicMock(), + "dock_area": mock.MagicMock(), + "scan_progress_simple": mock.MagicMock(), + "scan_progress_full": mock.MagicMock(), + }, + False, + ), + ( + { + "launcher": mock.MagicMock(), + "dock_area": mock.MagicMock(), + "scan_progress_simple": mock.MagicMock(), + "scan_progress_full": mock.MagicMock(), + "hover_widget": mock.MagicMock(), + }, True, ), ], @@ -147,6 +166,25 @@ def test_gui_server_turns_off_the_lights(bec_launch_window, connections, hide): "dock_area": mock.MagicMock(), "scan_progress": mock.MagicMock(), }, + True, + ), + ( + { + "launcher": mock.MagicMock(), + "dock_area": mock.MagicMock(), + "scan_progress_simple": mock.MagicMock(), + "scan_progress_full": mock.MagicMock(), + }, + True, + ), + ( + { + "launcher": mock.MagicMock(), + "dock_area": mock.MagicMock(), + "scan_progress_simple": mock.MagicMock(), + "scan_progress_full": mock.MagicMock(), + "hover_widget": mock.MagicMock(), + }, False, ), ],