From 677550931b28fbf35fd55880bf6e001f7351b99b Mon Sep 17 00:00:00 2001 From: wyzula-jan Date: Wed, 28 Jan 2026 10:00:12 +0100 Subject: [PATCH] fix(ring): minor general fixes --- .../widgets/progress/ring_progress_bar/ring.py | 5 +++-- .../ring_progress_bar/ring_progress_settings_cards.py | 11 +++++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/bec_widgets/widgets/progress/ring_progress_bar/ring.py b/bec_widgets/widgets/progress/ring_progress_bar/ring.py index 649954b5..e0417b7b 100644 --- a/bec_widgets/widgets/progress/ring_progress_bar/ring.py +++ b/bec_widgets/widgets/progress/ring_progress_bar/ring.py @@ -40,7 +40,7 @@ class ProgressbarConfig(ConnectionConfig): line_width: int = Field(20, description="Line widths for the progress bars.") start_position: int = Field( 90, - description="Start position for the progress bars in degrees. Default is 90 degrees - corespons to " + description="Start position for the progress bars in degrees. Default is 90 degrees - corresponds to " "the top of the ring.", ) min_value: int | float = Field(0, description="Minimum value for the progress bars.") @@ -495,7 +495,8 @@ class Ring(BECConnector, QWidget): self._hover_animation.setEndValue(1.0 if hovered else 0.0) self._hover_animation.start() - def convert_color(self, color: str | tuple | QColor) -> QColor: + @staticmethod + def convert_color(color: str | tuple | QColor) -> QColor: """ Convert the color to QColor diff --git a/bec_widgets/widgets/progress/ring_progress_bar/ring_progress_settings_cards.py b/bec_widgets/widgets/progress/ring_progress_bar/ring_progress_settings_cards.py index e3c0a999..20d90164 100644 --- a/bec_widgets/widgets/progress/ring_progress_bar/ring_progress_settings_cards.py +++ b/bec_widgets/widgets/progress/ring_progress_bar/ring_progress_settings_cards.py @@ -63,7 +63,8 @@ class RingCardWidget(QFrame): self.mode_combo.setCurrentText(self._get_display_mode_string(self.ring.config.mode)) self._set_widget_mode_enabled(self.ring.config.mode) - def _get_theme_color(self, color_name: str) -> QColor | None: + @staticmethod + def _get_theme_color(color_name: str) -> QColor | None: app = QApplication.instance() if not app: return @@ -249,12 +250,13 @@ class RingCardWidget(QFrame): def _on_signal_changed(self, signal: str): device = self.ui.device_combo_box.currentText() signal = self.ui.signal_combo_box.get_signal_name() - if not device or device not in self.container.bec_dispatcher.client.device_manager.devices: + if not device or device not in self.ring.bec_dispatcher.client.device_manager.devices: return self.ring.set_update("device", device=device, signal=signal) self.ring.config.signal = signal - def _unify_mode_string(self, mode: str) -> str: + @staticmethod + def _unify_mode_string(mode: str) -> str: """Convert mode string to a unified format""" mode = mode.lower() if mode == "scan progress": @@ -263,7 +265,8 @@ class RingCardWidget(QFrame): return "device" return mode - def _get_display_mode_string(self, mode: str) -> str: + @staticmethod + def _get_display_mode_string(mode: str) -> str: """Convert mode string to display format""" match mode: case "manual":