From 5de8804da1e41eafad2472344904b3324438c13b Mon Sep 17 00:00:00 2001
From: wakonig_k <klaus.wakonig@psi.ch>
Date: Sun, 7 Jul 2024 11:21:01 +0200
Subject: [PATCH] test(vscode): improved vscode test

---
 tests/unit_tests/test_vscode_widget.py | 34 +++++++++++++-------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/tests/unit_tests/test_vscode_widget.py b/tests/unit_tests/test_vscode_widget.py
index 641b3777..fbcf0509 100644
--- a/tests/unit_tests/test_vscode_widget.py
+++ b/tests/unit_tests/test_vscode_widget.py
@@ -25,25 +25,25 @@ def test_vscode_widget(qtbot, vscode_widget):
 def test_start_server(qtbot, mocked_client):
 
     with mock.patch("bec_widgets.widgets.vscode.vscode.subprocess.Popen") as mock_popen:
-        mock_process = mock.Mock()
-        mock_process.stdout.fileno.return_value = 1
-        mock_process.poll.return_value = None
-        mock_process.stdout.read.return_value = (
-            f"available at http://{VSCodeEditor.host}:{VSCodeEditor.port}?tkn={VSCodeEditor.token}"
-        )
-        mock_popen.return_value = mock_process
+        with mock.patch("bec_widgets.widgets.vscode.vscode.select.select") as mock_select:
+            mock_process = mock.Mock()
+            mock_process.stdout.fileno.return_value = 1
+            mock_process.poll.return_value = None
+            mock_process.stdout.read.return_value = f"available at http://{VSCodeEditor.host}:{VSCodeEditor.port}?tkn={VSCodeEditor.token}"
+            mock_popen.return_value = mock_process
+            mock_select.return_value = [[mock_process.stdout], [], []]
 
-        widget = VSCodeEditor(client=mocked_client)
+            widget = VSCodeEditor(client=mocked_client)
 
-        mock_popen.assert_called_once_with(
-            shlex.split(
-                f"code serve-web --port {widget.port} --connection-token={widget.token} --accept-server-license-terms"
-            ),
-            text=True,
-            stdout=subprocess.PIPE,
-            stderr=subprocess.DEVNULL,
-            preexec_fn=os.setsid,
-        )
+            mock_popen.assert_called_once_with(
+                shlex.split(
+                    f"code serve-web --port {widget.port} --connection-token={widget.token} --accept-server-license-terms"
+                ),
+                text=True,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.DEVNULL,
+                preexec_fn=os.setsid,
+            )
 
 
 @pytest.fixture