0
0
mirror of https://github.com/bec-project/bec_widgets.git synced 2025-07-14 11:41:49 +02:00

refactor: test_bec_monitor.py and test_config_dialog.py cleaned up

This commit is contained in:
wyzula-jan
2023-10-30 17:39:19 +01:00
committed by wyzula_j
parent 3866d7ce4d
commit 3a4cbb1bb6
2 changed files with 13 additions and 20 deletions

View File

@ -6,8 +6,6 @@ from unittest.mock import MagicMock
from bec_widgets.widgets import BECMonitor from bec_widgets.widgets import BECMonitor
# current_path = os.path.dirname(__file__)
def load_test_config(config_name): def load_test_config(config_name):
"""Helper function to load config from yaml file.""" """Helper function to load config from yaml file."""

View File

@ -6,24 +6,15 @@ from PyQt5.QtWidgets import QTabWidget, QTableWidgetItem
from bec_widgets.widgets import ConfigDialog from bec_widgets.widgets import ConfigDialog
current_path = os.path.dirname(__file__)
def load_test_config(config_name):
def load_config(config_path):
"""Helper function to load config from yaml file.""" """Helper function to load config from yaml file."""
config_path = os.path.join(os.path.dirname(__file__), "test_configs", f"{config_name}.yaml")
with open(config_path, "r") as f: with open(config_path, "r") as f:
config = yaml.safe_load(f) config = yaml.safe_load(f)
return config return config
# load saved configurations from .yaml files
config_device = load_config(os.path.join(current_path, "test_configs/config_device.yaml"))
config_device_no_entry = load_config(
os.path.join(current_path, "test_configs/config_device_no_entry.yaml")
)
config_scan = load_config(os.path.join(current_path, "test_configs/config_scan.yaml"))
@pytest.fixture(scope="function") @pytest.fixture(scope="function")
def config_dialog(qtbot): def config_dialog(qtbot):
widget = ConfigDialog() widget = ConfigDialog()
@ -32,8 +23,9 @@ def config_dialog(qtbot):
yield widget yield widget
@pytest.mark.parametrize("config", [config_device, config_scan]) @pytest.mark.parametrize("config_name", ["config_device", "config_scan"])
def test_load_config(config_dialog, config): def test_load_config(config_dialog, config_name):
config = load_test_config(config_name)
config_dialog.load_config(config) config_dialog.load_config(config)
assert ( assert (
@ -45,14 +37,15 @@ def test_load_config(config_dialog, config):
@pytest.mark.parametrize( @pytest.mark.parametrize(
"config, scan_mode", "config_name, scan_mode",
[ [
(config_device, False), ("config_device", False),
(config_scan, True), ("config_scan", True),
(config_device_no_entry, False), ("config_device_no_entry", False),
], ],
) )
def test_initialization(config_dialog, config, scan_mode): def test_initialization(config_dialog, config_name, scan_mode):
config = load_test_config(config_name)
config_dialog.load_config(config) config_dialog.load_config(config)
assert isinstance(config_dialog, ConfigDialog) assert isinstance(config_dialog, ConfigDialog)
@ -79,6 +72,7 @@ def test_initialization(config_dialog, config, scan_mode):
def test_edit_and_apply_config(config_dialog): def test_edit_and_apply_config(config_dialog):
config_device = load_test_config("config_device")
config_dialog.load_config(config_device) config_dialog.load_config(config_device)
config_dialog.comboBox_appearance.setCurrentText("white") config_dialog.comboBox_appearance.setCurrentText("white")
@ -93,6 +87,7 @@ def test_edit_and_apply_config(config_dialog):
def test_edit_and_apply_config_scan_mode(config_dialog): def test_edit_and_apply_config_scan_mode(config_dialog):
config_scan = load_test_config("config_scan")
config_dialog.load_config(config_scan) config_dialog.load_config(config_scan)
config_dialog.comboBox_appearance.setCurrentText("white") config_dialog.comboBox_appearance.setCurrentText("white")