refactor: set downsampling to auto=True, method 'peak', activate clipToView for (Async)-Curves and fix ViewAll hook from pg.view_box menu

tests/end-2-end/test_plotting_framework_e2e.py

@@ -113,6 +113,51 @@ def test_rpc_waveform_scan(qtbot, bec_client_lib, connected_client_gui_obj):
     assert plt_data["bpm4d-bpm4d"]["y"] == last_scan_data["bpm4d"]["bpm4d"].val
 
 
+def test_async_plotting(qtbot, bec_client_lib, connected_client_gui_obj):
+    gui = connected_client_gui_obj
+    dock = gui.bec
+
+    client = bec_client_lib
+    dev = client.device_manager.devices
+    scans = client.scans
+    queue = client.queue
+
+    # Test add
+    dev.waveform.sim.select_model("GaussianModel")
+    dev.waveform.sim.params = {"amplitude": 1000, "center": 4000, "sigma": 300}
+    dev.waveform.async_update.put("add")
+    dev.waveform.waveform_shape.put(10000)
+    wf = dock.new("wf_dock").new("Waveform")
+    curve = wf.plot(y_name="waveform")
+
+    status = scans.line_scan(dev.samx, -5, 5, steps=10, exp_time=0.05, relative=False)
+    status.wait()
+
+    # Wait for the scan to finish and the data to be available in history
+    # Wait until scan_id is in history
+    def _wait_for_scan_in_hisotry():
+        if len(client.history) == 0:
+            return False
+        # Once items appear in storage, the last one hast to be the one we just scanned
+        return client.history[-1].metadata.bec["scan_id"] == status.scan.scan_id
+
+    qtbot.waitUntil(_wait_for_scan_in_hisotry, timeout=10000)
+    last_scan_data = client.history[-1]
+    # check plotted data
+    x_data, y_data = curve.get_data()
+    assert np.array_equal(x_data, np.linspace(0, len(y_data) - 1, len(y_data)))
+    assert np.array_equal(
+        y_data, last_scan_data.devices.waveform.get("waveform_waveform", {}).read().get("value", [])
+    )
+
+    # Check displayed data
+    x_data_display, y_data_display = curve._get_displayed_data()
+    # Should be not more than 1% difference, actually be closer but this might be flaky
+    assert np.isclose(x_data_display[-1], x_data[-1], rtol=0.01)
+    # Downsampled data should be smaller than original data
+    assert len(y_data_display) < len(y_data)
+
+
 def test_rpc_image(qtbot, bec_client_lib, connected_client_gui_obj):
     gui = connected_client_gui_obj
     dock = gui.bec

tests/unit_tests/test_waveform_next_gen.py

@@ -595,13 +595,15 @@ def test_on_async_readback_add_update(qtbot, mocked_client, x_mode):
     c.setData([], [])
 
     # Test large updates, limit 1000 to deactivate symbols, downsampling for 8000 should be factor 2.
-    waveform_shape = 12000
-    for ii in range(12):
+    waveform_shape = 100000
+    n_cycles = 10
+    for ii in range(n_cycles):
         msg = {
             "signals": {
                 "async_device": {
-                    "value": np.array(range(1000)),
-                    "timestamp": (ii + 1) * np.linspace(0, 1000 - 1, 1000),
+                    "value": np.array(range(waveform_shape // n_cycles)),
+                    "timestamp": (ii + 1)
+                    * np.linspace(0, waveform_shape // n_cycles - 1, waveform_shape // n_cycles),
                 }
             }
         }
@@ -615,9 +617,7 @@ def test_on_async_readback_add_update(qtbot, mocked_client, x_mode):
     assert c.opts["symbol"] == None
     # Get displayed data
     displayed_x, displayed_y = c.getData()
-    assert len(displayed_y) == waveform_shape / 2
-    assert len(displayed_x) == waveform_shape / 2
-    assert displayed_x[-1] == waveform_shape - 1  # Should be the correct index stil.
+    assert len(displayed_y) == len(displayed_x)
 
     ############# Test replace ################
     waveform_shape = 10