From 04f1ff4fe7869215f010bf73f7271e063e21f2a2 Mon Sep 17 00:00:00 2001 From: wakonig_k Date: Wed, 10 Dec 2025 10:34:27 +0100 Subject: [PATCH] fix(devices): minor fix to comply with new config helper in bec_lib --- bec_widgets/widgets/services/device_browser/device_browser.py | 4 +++- .../device_browser/device_item/device_config_dialog.py | 2 +- tests/unit_tests/test_device_config_form_dialog.py | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/bec_widgets/widgets/services/device_browser/device_browser.py b/bec_widgets/widgets/services/device_browser/device_browser.py index 55a06668..9b28607c 100644 --- a/bec_widgets/widgets/services/device_browser/device_browser.py +++ b/bec_widgets/widgets/services/device_browser/device_browser.py @@ -55,7 +55,9 @@ class DeviceBrowser(BECWidget, QWidget): ) -> None: super().__init__(parent=parent, client=client, gui_id=gui_id, config=config, **kwargs) self.get_bec_shortcuts() - self._config_helper = ConfigHelper(self.client.connector, self.client._service_name) + self._config_helper = ConfigHelper( + self.client.connector, self.client._service_name, self.client.device_manager + ) self._q_threadpool = QThreadPool() self.ui = None self.init_ui() diff --git a/bec_widgets/widgets/services/device_browser/device_item/device_config_dialog.py b/bec_widgets/widgets/services/device_browser/device_item/device_config_dialog.py index 3964bf71..1ffd8fbb 100644 --- a/bec_widgets/widgets/services/device_browser/device_item/device_config_dialog.py +++ b/bec_widgets/widgets/services/device_browser/device_item/device_config_dialog.py @@ -65,7 +65,7 @@ class DeviceConfigDialog(BECWidget, QDialog): self._initial_config = {} super().__init__(parent=parent, **kwargs) self._config_helper = config_helper or ConfigHelper( - self.client.connector, self.client._service_name + self.client.connector, self.client._service_name, self.client.device_manager ) self._device = device self._action: Literal["update", "add"] = action diff --git a/tests/unit_tests/test_device_config_form_dialog.py b/tests/unit_tests/test_device_config_form_dialog.py index e176da5b..4e64e80a 100644 --- a/tests/unit_tests/test_device_config_form_dialog.py +++ b/tests/unit_tests/test_device_config_form_dialog.py @@ -134,7 +134,7 @@ def test_update_cycle(update_dialog, qtbot): "deviceClass": "TestDevice", "deviceConfig": {"param1": "val1"}, "readoutPriority": "monitored", - "description": None, + "description": "", "readOnly": False, "softwareTrigger": False, "onFailure": "retry",