8949a63189
Merge pull request 'Fix memory leak in streak finder' (#3) from ext-dorofe_e/dap:cbd_bugfix into main
23983ddd6f
Merge pull request 'Streak Finder algorithm for CBD experiment' (#2) from ext-dorofe_e/dap:chapman into main
193f531d5c
Correct setting name for mask form file dataset; prepend all strak-finder-specific settings names with sf; Make streak-finder mask optional now that we have mask from file
The new version looks great. Please merge it into the PR.
I have only one small request, but I somehow cannot comment on the commit 🙄
mask_dataset = results.get("mask_ds",…
The current additional mask logic is flat-out 💩. No question there.
I have it specifically on my list to merge it with the OTHER additional mask that we have in the DAQ: https://github.com/pau…
Ah! Now I get the idea!
I think the canonical way of doing this is: https://docs.h5py.org/en/stable/high/dataset.html#h5py.Dataset.astype
I would guess that your version is no extra copy…
Ah, yes, that was clear :)
The reason I got confused is that for such a case, I would use np.array (i.e., the definite-copy version). np.asarray is the copy-if-needed version that you'd…
I kinda feel this would be nicer to read:
Why this maybe-copy?
Same as above: drop [].