augustin_s augustin_s
0 Followers · 1 Following
  • Joined on 2025-02-24
Repositories
12
 Projects Packages Code Public Activity Starred Repositories
augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

You are changing the mask in place.

augustin_s suggested changes for ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments
augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

Please change this to:

augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

Just for my eye, I'd change this to:

augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

Same as above:

augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

Isn't this the same as:

augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

Umm, this is odd 😆 Why not:

augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

I have not seen this before. Is there an advantage over:

augustin_s commented on pull request ext-dorofe_e/dap#1 2025-07-10 19:13:19 +02:00
DAP branch including streak finder analysis for Convergent-Beam diffraction experiments

Small useless optimization, but also nicer to read: You can drop the [] and use a generator expression.

augustin_s pushed to master at slic/slic 2025-07-09 21:25:56 +02:00
0a65a754a1 break entry columns after 10 entries
augustin_s pushed to master at slic/slic 2025-07-09 18:04:56 +02:00
34e0ad0190 typo
augustin_s pushed to master at slic/slic 2025-07-09 18:03:28 +02:00
2b763a5970 skip unknown parameters
augustin_s pushed to main at sf-daq/dap 2025-07-08 18:58:55 +02:00
da8141b687 convert numpy bool_ scalar to python bool
augustin_s pushed to main at sf-daq/dap 2025-07-08 16:05:25 +02:00
9bfe0cc8c5 changed gitlab -> gitea
augustin_s pushed to main at sf-daq/dap 2025-07-08 15:52:52 +02:00
7d5a0f7ad8 disable deprecated APIs in NumPy (from before version 1.7) to silence warning
augustin_s pushed to main at sf-daq/dap 2025-07-08 11:36:07 +02:00
157b7bad8c typo
augustin_s pushed to master at slic/slic 2025-07-08 10:58:14 +02:00
8b4ded4584 adjust for SPI v2
augustin_s pushed to main at sf-daq/dap 2025-07-08 08:54:41 +02:00
e984b336a0 SPI v2
augustin_s pushed to main at SwissFEL/unarchived_data_fix 2025-06-30 18:54:20 +02:00
ca8557f69e made pattern raw string
augustin_s pushed to master at SwissFEL/stand 2025-06-24 19:13:20 +02:00
9a2cffb720 currently need v0.x, but v0.3.5 was yanked from pypi