raise Warning() -> warnings.warn()

scilog/scilog.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 import functools
+import warnings
 
 from .authmixin import AuthError, HEADER_JSON
 from .httpclient import HttpClient
@@ -9,17 +10,17 @@ from .snippet import Snippet, Basesnippet, Paragraph
 def pinned_to_logbook(logbook_keys):
     def pinned_to_logbook_inner(func):
         @functools.wraps(func)
-        def pinned_to_logbook_call(*args, **kwargs):
+        def pinned_to_logbook_call(log, *args, **kwargs):
-            if isinstance(args[0].logbook, Basesnippet):
+            if not isinstance(log.logbook, Basesnippet):
+                warnings.warn("No logbook selected.")
+            else:
                 for key in logbook_keys:
-                    if key not in kwargs.keys():
+                    if key not in kwargs:
                         if key == "parentId":
-                            kwargs[key] = args[0].logbook.id
+                            kwargs[key] = log.logbook.id
                         else:
-                            kwargs[key] = getattr(args[0].logbook, key)
+                            kwargs[key] = getattr(log.logbook, key)
-            else:
+            return func(log, *args, **kwargs)
-                raise Warning("No logbook selected.")
-            return func(*args, **kwargs)
         return pinned_to_logbook_call
     return pinned_to_logbook_inner