LMU/musrfit
5
1 Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 6 Activity

musrt0 -g does not work with global block #20

New Issue
Closed
opened 2026-10-11 11:13:16 +02:00 by salman · 1 comment
salman commented 2026-10-11 11:13:16 +02:00
Member
Copy link
Copy source

musrt0 --getT0FromPromptPeak (-g) is supposed to get t0 from the prompt peak and write the result in the msr file. If a RUN block contains no t0 line and no fit line, then t0 is silently discarded: only the file timestamp changes. Same issue affects addt0, background, and data.

To reproduce

  1. Take an MSR whose fit range is defined only in the GLOBAL block (RUN blocks have no fit line)
  2. Run: musrt0 -g
  3. Result: .msr/.mlog timestamps change, but no t0 line is added.
  4. Control: add a fit line to each RUN block, rerun -g -> t0 line is written correctly.

Opencode diagnosis:
In WriteMsrLogFile the missing-tag flush (t0TagMissing/addt0TagMissing/backgroundTagMissing/dataTagMissing) is emitted only inside the fit branch (PMsrHandler.cpp ~1069-1120). There is no flush at end of a RUN block nor when the next RUN line is seen (runNo++ at ~568). Hence for RUN blocks without a fit line the programmatically set values are never written.
Proposed fix:
Flush missing t0/addt0/background/data tags at the end of each RUN block (and at EOF), independent of the presence of a fit line.

musrt0 <msr> --getT0FromPromptPeak (-g) is supposed to get t0 from the prompt peak and write the result in the msr file. If a RUN block contains no t0 line and no fit line, then t0 is silently discarded: only the file timestamp changes. Same issue affects addt0, background, and data. To reproduce 1. Take an MSR whose fit range is defined only in the GLOBAL block (RUN blocks have no fit line) 2. Run: musrt0 <msr> -g 3. Result: .msr/.mlog timestamps change, but no t0 line is added. 4. Control: add a fit line to each RUN block, rerun -g -> t0 line is written correctly. Opencode diagnosis: In WriteMsrLogFile the missing-tag flush (t0TagMissing/addt0TagMissing/backgroundTagMissing/dataTagMissing) is emitted only inside the fit branch (PMsrHandler.cpp ~1069-1120). There is no flush at end of a RUN block nor when the next RUN line is seen (runNo++ at ~568). Hence for RUN blocks without a fit line the programmatically set values are never written. Proposed fix: Flush missing t0/addt0/background/data tags at the end of each RUN block (and at EOF), independent of the presence of a fit line.
salman added the bug label 2026-10-11 11:13:40 +02:00
suter_a commented 2026-10-13 09:12:22 +02:00
Owner
Copy link
Copy source

sha 7b8574b3ee fixes the issue

sha 7b8574b3eef90d fixes the issue
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
feature request
to-be-checked
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
heiss_m (heiss_m) janka_g (janka_g) krieger_j (krieger_j) lmu-gitea mathis_s (mathis_s) mueller_r4 (mueller_r4) prokscha (prokscha) raselli (raselli) salman (salman) soederqvist_a (soederqvist_a) suter_a (suter_a) wall_e (wall_e) wollra_j (wollra_j)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LMU/musrfit#20