From e525abe61409132f3801e6481e2b5595e1252c81 Mon Sep 17 00:00:00 2001
From: Andreas Suter <andreas.suter@psi.ch>
Date: Mon, 19 May 2025 13:29:54 +0200
Subject: [PATCH] simplify git-revision.h generation.

---
 CMakeLists.txt                                | 13 ++++++++
 cmake/configure_musrfit_version_file.cmake.in | 30 -----------------
 src/CMakeLists.txt                            | 32 -------------------
 src/git_revision.sh                           | 20 ++++++------
 4 files changed, 22 insertions(+), 73 deletions(-)
 delete mode 100644 cmake/configure_musrfit_version_file.cmake.in

diff --git a/CMakeLists.txt b/CMakeLists.txt
index de00f5af..21c153bf 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -224,6 +224,19 @@ else ()
   set(IS_GIT_REPO 0)
 endif ()
 
+#--- start create git-revision.h ----------------------------------------------
+if (IS_GIT_REPO)
+  execute_process(COMMAND sh ${CMAKE_SOURCE_DIR}/src/git_revision.sh)
+
+  set(HAVE_GIT_REV_H "-DHAVE_GIT_REV_H")  
+  set(GIT_REV_H "git-revision.h")
+else (IS_GIT_REPO)
+  set(HAVE_GIT_REV_H "")  
+  set(GIT_REV_H "")
+endif (IS_GIT_REPO)
+
+#--- end create git-revision.h ------------------------------------------------
+
 #--- rpath related things -----------------------------------------------------
 # use, i.e. don't skip the full RPATH for the build tree
 set(CMAKE_SKIP_BUILD_RPATH FALSE)
diff --git a/cmake/configure_musrfit_version_file.cmake.in b/cmake/configure_musrfit_version_file.cmake.in
deleted file mode 100644
index ba51025a..00000000
--- a/cmake/configure_musrfit_version_file.cmake.in
+++ /dev/null
@@ -1,30 +0,0 @@
-# configure_musrfit_version_file.cmake.in:
-set(SRC_DIR "@CMAKE_SOURCE_DIR@")
-set(BIN_DIR "@CMAKE_CURRENT_BINARY_DIR@")
-
-# Set variables
-set(CMAKE_INSTALL_PREFIX "@CMAKE_INSTALL_PREFIX@")
-set(MUSRFIT_VERSION "@MUSRFIT_VERSION@")
-
-# Get the current working branch
-execute_process(
-  COMMAND git rev-parse --abbrev-ref HEAD
-  WORKING_DIRECTORY ${SRC_DIR}
-  OUTPUT_VARIABLE GIT_BRANCH
-  OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-
-# Get the latest abbreviated commit hash of the working branch
-execute_process(
-  COMMAND git log -1 --pretty="%h, %ci"
-  WORKING_DIRECTORY ${SRC_DIR}
-  OUTPUT_VARIABLE GIT_CURRENT_SHA1
-  OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-
-configure_file(
-  ${SRC_DIR}/cmake/git-revision.h.in
-  ${BIN_DIR}/git-revision.h
-  @ONLY
-)
-# EOF
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 3bbf50a9..6e1b1ab8 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -22,38 +22,6 @@ if (nexus)
 endif (nexus)
 set(MUSRFIT_LIBS ${MUSRFIT_LIBS} PMusr)
 
-#--- start create git-revision.h ----------------------------------------------
-if (IS_GIT_REPO)
-  configure_file(
-    ${CMAKE_SOURCE_DIR}/cmake/configure_musrfit_version_file.cmake.in
-    ${CMAKE_CURRENT_BINARY_DIR}/configure_musrfit_version_file.cmake
-    @ONLY
-  )
-
-  add_custom_command(
-    OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/git-revision.h
-    COMMAND ${CMAKE_COMMAND} -P
-      ${CMAKE_CURRENT_BINARY_DIR}/configure_musrfit_version_file.cmake
-    DEPENDS
-      ${CMAKE_CURRENT_BINARY_DIR}/configure_musrfit_version_file.cmake
-      ${CMAKE_SOURCE_DIR}/cmake/git-revision.h.in
-    COMMENT "Configuring git-revision.h"
-    VERBATIM
-  )
-
-  add_custom_target(
-    configure_musrfit_version ALL
-    DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/git-revision.h
-  )
-  set(HAVE_GIT_REV_H "-DHAVE_GIT_REV_H")  
-  set(GIT_REV_H "git-revision.h")
-else (IS_GIT_REPO)
-  set(HAVE_GIT_REV_H "")  
-  set(GIT_REV_H "")
-endif (IS_GIT_REPO)
-
-#--- end create git-revision.h ------------------------------------------------
-
 #--- add all executables ------------------------------------------------------
 add_executable(addRun ${GIT_REV_H} addRun.cpp)
 target_compile_options(addRun BEFORE PRIVATE "-DHAVE_CONFIG_H" "${HAVE_GIT_REV_H}")
diff --git a/src/git_revision.sh b/src/git_revision.sh
index 5c706d27..51252fb6 100755
--- a/src/git_revision.sh
+++ b/src/git_revision.sh
@@ -1,21 +1,19 @@
 #!/bin/bash
 
-echo "Generating header for git hash" $1 $2
-GIT_HEADER="$1/$2"
-if [ -z "$2" ]; then
-        GIT_HEADER="$1/git-revision.h"
-fi
+echo "-- Generating header for git hash"
+GIT_HEADER="src/git-revision.h"
 
 GIT_BRANCH=`git rev-parse --abbrev-ref HEAD`
 
 GIT_VERSION=`git log -n 1 --pretty=format:"%ad - %h"`
-if grep --quiet "$GIT_VERSION" $GIT_HEADER; then
-        echo "No need to generate new $GIT_HEADER - git hash is unchanged"
-        exit 0;
+if [ "$(grep -ics "$GIT_VERSION" $GIT_HEADER)" = 1 ] 
+then
+   echo "-- No need to generate new $GIT_HEADER - git hash is unchanged"
+   exit 0;
 fi
 
-echo "git branch is  : " $GIT_BRANCH
-echo "git version is : " $GIT_VERSION
+echo "-- git branch is  : " $GIT_BRANCH
+echo "-- git version is : " $GIT_VERSION
 
 echo "#ifndef GIT_VERSION_H" > $GIT_HEADER
 echo "#define GIT_VERSION_H" >> $GIT_HEADER
@@ -25,4 +23,4 @@ echo "#define GIT_CURRENT_SHA1 \"$GIT_VERSION\"" >> $GIT_HEADER
 echo "" >> $GIT_HEADER
 echo "#endif //GIT_VERSION_H" >> $GIT_HEADER
 
-echo "file is generated into" $GIT_HEADER
+echo "-- file is generated into" $GIT_HEADER