From 4136806847b47e062a00e41c50f1921d141214aa Mon Sep 17 00:00:00 2001
From: Andreas Suter <andreas.suter@psi.ch>
Date: Wed, 11 Feb 2026 16:05:02 +0100
Subject: [PATCH] better hdf4/5 include handling.

---
 CMakeLists.txt                    |  1 -
 src/CMakeLists.txt                |  3 ++-
 src/classes/CMakeLists.txt        |  3 ++-
 src/external/nexus/CMakeLists.txt | 10 +++++-----
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4ceb6b0b2..ccdf77a4e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -243,7 +243,6 @@ if (nexus)
       message(FATAL_ERROR "HDF4 library not found. Please install libhdf4-dev or hdf-devel")
     endif()
 
-    include_directories(${HDF4_INCLUDE_DIRS})
     add_definitions(-DHAVE_HDF4)
   endif (HAVE_HDF4)  
   add_definitions(-DPNEXUS_ENABLED)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 12267f70a..3486ac8de 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -50,7 +50,8 @@ target_compile_options(dump_header BEFORE PRIVATE "-DHAVE_CONFIG_H" "${HAVE_GIT_
 target_include_directories(dump_header 
   BEFORE PRIVATE 
     $<BUILD_INTERFACE:${Boost_INCLUDE_DIRS}>
-    $<BUILD_INTERFACE:${NEXUS_INCLUDE_DIR}>
+    $<BUILD_INTERFACE:${HDF4_INCLUDE_DIRS}>
+    $<BUILD_INTERFACE:${HDF5_INCLUDE_DIRS}>
     $<BUILD_INTERFACE:${CMAKE_BINARY_DIR}>
     $<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/src>
     $<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/src/include>
diff --git a/src/classes/CMakeLists.txt b/src/classes/CMakeLists.txt
index dad742b61..7a5681711 100644
--- a/src/classes/CMakeLists.txt
+++ b/src/classes/CMakeLists.txt
@@ -131,7 +131,8 @@ target_include_directories(
   PMusr BEFORE PRIVATE
     $<BUILD_INTERFACE:${Boost_INCLUDE_DIR}>
     $<BUILD_INTERFACE:${FFTW3_INCLUDE}> 
-    $<BUILD_INTERFACE:${NEXUS_INCLUDE_DIR}>
+    $<BUILD_INTERFACE:${HDF4_INCLUDE_DIRS}>
+    $<BUILD_INTERFACE:${HDF5_INCLUDE_DIRS}>
     $<BUILD_INTERFACE:${MUSRFIT_INC}>
     $<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/src/external/MusrRoot>
     $<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/src/external/TLemRunHeader>
diff --git a/src/external/nexus/CMakeLists.txt b/src/external/nexus/CMakeLists.txt
index 140a82b1d..ba6790bdc 100644
--- a/src/external/nexus/CMakeLists.txt
+++ b/src/external/nexus/CMakeLists.txt
@@ -1,7 +1,5 @@
 # - PNeXus library ------------------------------------------------------------
 
-include_directories(${NEXUS_INCLUDE_DIR}) # to get the nexus headers
-
 #--- create pkg-config info ---------------------------------------------------
 set(prefix "${CMAKE_INSTALL_PREFIX}")   
 set(exec_prefix "\$\{prefix\}")
@@ -23,8 +21,10 @@ set_target_properties(PNeXus
 )
 
 #--- make sure that the include directory is found ----------------------------
-target_include_directories(
-  PNeXus BEFORE PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
+target_include_directories(PNeXus 
+  BEFORE PRIVATE $<BUILD_INTERFACE:${HDF4_INCLUDE_DIRS}>
+  BEFORE PRIVATE $<BUILD_INTERFACE:${HDF5_INCLUDE_DIRS}>
+  BEFORE PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
 )
 
 #--- add library dependencies -------------------------------------------------
@@ -33,7 +33,7 @@ if (HAVE_HDF4)
 else (HAVE_HDF4)   
   set(HDF_LIBS ${HDF5_LIBRARIES})
 endif (HAVE_HDF4)
-message(STATUS "++>> HDF_LIBS: ${HDF_LIBS}")
+message(STATUS "as35> HDF_LIBS: ${HDF_LIBS}")
 target_link_libraries(PNeXus ${HDF_LIBS} ${ROOT_LIBRARIES})
 
 #--- install PNeXus solib -----------------------------------------------------