From bdbb79e131a92f072d88c627e52d490dc4a95738 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mose=20M=C3=BCller?= Date: Tue, 3 Oct 2023 16:14:58 +0200 Subject: [PATCH] feat: removing "install_signal_handlers" method from protocol (would have been overwritten anyway) --- src/pydase/server/server.py | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/src/pydase/server/server.py b/src/pydase/server/server.py index f31d526..c394cea 100644 --- a/src/pydase/server/server.py +++ b/src/pydase/server/server.py @@ -28,9 +28,8 @@ class AdditionalServerProtocol(Protocol): This protocol sets the standard for how additional servers should be implemented to ensure compatibility with the main Server class. The protocol requires that - any server implementing it should have an __init__ method for initialization, a - serve method for starting the server, and an install_signal_handlers method for - setting up signal handlers. + any server implementing it should have an __init__ method for initialization and a + serve method for starting the server. Parameters: ----------- @@ -62,12 +61,6 @@ class AdditionalServerProtocol(Protocol): """ ... - def install_signal_handlers(self) -> None: - """Sets up signal handlers for the server. This method is used to define how the - server should respond to various system signals, such as SIGINT and SIGTERM. - """ - ... - class AdditionalServer(TypedDict): """ @@ -257,13 +250,6 @@ class Server: info=self._info, **server["kwargs"], ) - try: - addin_server.install_signal_handlers = lambda: None # type: ignore - except Exception: - logger.debug( - "Additional server does not have a method called " - "'install_signal_handlers'." - ) server_name = ( addin_server.__module__ + "." + addin_server.__class__.__name__