From 8971cebfcdbc5bae3455c5beb32e64eb57bd84e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mose=20M=C3=BCller?= Date: Tue, 5 Mar 2024 13:24:15 +0100 Subject: [PATCH] adds todos --- src/pydase/data_service/data_service_observer.py | 2 ++ src/pydase/utils/serializer.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/pydase/data_service/data_service_observer.py b/src/pydase/data_service/data_service_observer.py index aeabfef..ef4e85d 100644 --- a/src/pydase/data_service/data_service_observer.py +++ b/src/pydase/data_service/data_service_observer.py @@ -44,6 +44,8 @@ class DataServiceObserver(PropertyObserver): self._update_cache_value(full_access_path, value, cached_value_dict) + # TODO: get the cached value again -> _update_cache_value already put the + # right thing into the cache for callback in self._notification_callbacks: callback(full_access_path, value, cached_value_dict) diff --git a/src/pydase/utils/serializer.py b/src/pydase/utils/serializer.py index 32b30ce..4f136f8 100644 --- a/src/pydase/utils/serializer.py +++ b/src/pydase/utils/serializer.py @@ -273,6 +273,8 @@ def set_nested_value_by_path( value_type = serialized_value.pop("type") if "readonly" in current_dict and current_dict["type"] != "method": current_dict["type"] = value_type + # TODO: this does not yet remove keys that are not present in the serialized new + # value current_dict.update(serialized_value)