ITQC/pydase
9
0
Fork 0
mirror of https://github.com/tiqi-group/pydase.git synced 2026-02-08 11:48:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

removes _warn_on_type_change from DataService setattr

Browse Source 
Adding keys to dictionaries trigger this warning, so I would consider
this warning to not be useful any more.
This commit is contained in:
Mose Müller
2025-08-28 13:22:31 +02:00
parent 71e29c890e
commit 51d6189002
1 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/pydase/data_service/data_service.py
View File

@@ -12,7 +12,6 @@ from pydase.observer_pattern.observable.observable import (
from pydase.utils.helpers import ( from pydase.utils.helpers import (
get_class_and_instance_attributes, get_class_and_instance_attributes,
is_descriptor, is_descriptor,
is_property_attribute,
) )
from pydase.utils.serialization.serializer import ( from pydase.utils.serialization.serializer import (
Serializer, Serializer,
@@ -28,9 +27,6 @@ class DataService(AbstractDataService):
self.__check_instance_classes() self.__check_instance_classes()
def __setattr__(self, name: str, value: Any, /) -> None: def __setattr__(self, name: str, value: Any, /) -> None:
# Check and warn for unexpected type changes in attributes
self._warn_on_type_change(name, value)
# every class defined by the user should inherit from DataService if it is # every class defined by the user should inherit from DataService if it is
# assigned to a public attribute # assigned to a public attribute
if not name.startswith("_") and not inspect.isfunction(value): if not name.startswith("_") and not inspect.isfunction(value):
@@ -39,21 +35,6 @@ class DataService(AbstractDataService):
# Set the attribute # Set the attribute
super().__setattr__(name, value) super().__setattr__(name, value)
def _warn_on_type_change(self, attr_name: str, new_value: Any) -> None:
if is_property_attribute(self, attr_name):
return
current_value = getattr(self, attr_name, None)
if self._is_unexpected_type_change(current_value, new_value):
logger.warning(
"Type of '%s' changed from '%s' to '%s'. This may have unwanted "
"side effects! Consider setting it to '%s' directly.",
attr_name,
type(current_value).__name__,
type(new_value).__name__,
type(current_value).__name__,
)
def _is_unexpected_type_change(self, current_value: Any, new_value: Any) -> bool: def _is_unexpected_type_change(self, current_value: Any, new_value: Any) -> bool:
return ( return (
isinstance(current_value, float) and not isinstance(new_value, float) isinstance(current_value, float) and not isinstance(new_value, float)