ITQC/pydase
24
0
Fork 0
mirror of https://github.com/tiqi-group/pydase.git synced 2025-06-12 07:57:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: property callback issues, implemented new tests

Browse Source
This commit is contained in:
Mose Müller
2023-08-02 12:06:19 +02:00
parent ae8be562db
commit 319a62bb01
2 changed files with 107 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/pyDataInterface/data_service/data_service.py
View File

@ -122,8 +122,20 @@ class DataService(rpyc.Service):
)
if isinstance(attr_value, property):
dependencies = attr_value.fget.__code__.co_names # type: ignore
source_code_string = inspect.getsource(attr_value.fget) # type: ignore
for dependency in dependencies:
# check if the dependencies are attributes of obj
# This doesn't have to be the case like, for example, here:
# >>> @property
# >>> def power(self) -> float:
# >>> return self.class_attr.voltage * self.current
#
# The dependencies for this property are:
# ('class_attr', 'voltage', 'current')
if f"self.{dependency}" not in source_code_string:
continue
# use `obj` instead of `type(obj)` to get DataServiceList
# instead of list
dependency_value = getattr(obj, dependency)
@ -347,7 +359,8 @@ class DataService(rpyc.Service):
"""Handles registration of callbacks for DataService attributes"""
# as the DataService is an attribute of self, change the root object
nested_attr.__root__ = self.__root__
# use the dictionary to not trigger callbacks on initialised objects
nested_attr.__dict__["__root__"] = self.__root__
new_path = f"{parent_path}.{attr_name}"
self._register_DataService_callbacks(nested_attr, new_path)