d61e7e5e1f
The dhcp server is systemd-networkd, and the dhcp plugin can request an ip but can not renew it. The systemd-networkd just ignore the renew request. ``` 2024/09/14 21:46:00 no DHCP packet received within 10s 2024/09/14 21:46:00 retrying in 31.529038 seconds 2024/09/14 21:46:42 no DHCP packet received within 10s 2024/09/14 21:46:42 retrying in 63.150490 seconds 2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: no more tries 2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: renewal time expired, rebinding 2024/09/14 21:47:45 Link "eth1" down. Attempting to set up 2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: lease rebound, expiration is 2024-09-14 22:47:45.309270751 +0800 CST m=+11730.048516519 ``` Follow the https://datatracker.ietf.org/doc/html/rfc2131#section-4.3.6, following options must not be sent in renew - Requested IP Address - Server Identifier Since the upstream code has been inactive for 6 years, we should switch to another dhcpv4 library. The new selected one is https://github.com/insomniacslk/dhcp. Signed-off-by: Songmin Li <lisongmin@protonmail.com>
100 lines
2.3 KiB
Go
100 lines
2.3 KiB
Go
// Copyright 2015 CNI authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package main
|
|
|
|
import (
|
|
"net"
|
|
"reflect"
|
|
"testing"
|
|
|
|
dhcp4 "github.com/insomniacslk/dhcp/dhcpv4"
|
|
|
|
"github.com/containernetworking/cni/pkg/types"
|
|
)
|
|
|
|
func validateRoutes(t *testing.T, routes []*types.Route) {
|
|
expected := []*types.Route{
|
|
{
|
|
Dst: net.IPNet{
|
|
IP: net.IPv4(10, 0, 0, 0),
|
|
Mask: net.CIDRMask(8, 32),
|
|
},
|
|
GW: net.IPv4(10, 1, 2, 3),
|
|
},
|
|
{
|
|
Dst: net.IPNet{
|
|
IP: net.IPv4(192, 168, 1, 0),
|
|
Mask: net.CIDRMask(24, 32),
|
|
},
|
|
GW: net.IPv4(192, 168, 2, 3),
|
|
},
|
|
}
|
|
|
|
if len(routes) != len(expected) {
|
|
t.Fatalf("wrong length slice; expected %v, got %v", len(expected), len(routes))
|
|
}
|
|
|
|
for i := 0; i < len(routes); i++ {
|
|
a := routes[i]
|
|
e := expected[i]
|
|
|
|
if a.Dst.String() != e.Dst.String() {
|
|
t.Errorf("route.Dst mismatch: expected %v, got %v", e.Dst, a.Dst)
|
|
}
|
|
|
|
if !a.GW.Equal(e.GW) {
|
|
t.Errorf("route.GW mismatch: expected %v, got %v", e.GW, a.GW)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseRoutes(t *testing.T) {
|
|
data := []byte{10, 0, 0, 0, 10, 1, 2, 3, 192, 168, 1, 0, 192, 168, 2, 3}
|
|
routes := parseRoutes(data)
|
|
|
|
validateRoutes(t, routes)
|
|
}
|
|
|
|
func TestParseOptionName(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
option string
|
|
want dhcp4.OptionCode
|
|
wantErr bool
|
|
}{
|
|
{
|
|
"hostname", "host-name", dhcp4.OptionHostName, false,
|
|
},
|
|
{
|
|
"hostname in number", "12", dhcp4.GenericOptionCode(12), false,
|
|
},
|
|
{
|
|
"random string", "doNotparseMe", dhcp4.OptionPad, true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := parseOptionName(tt.option)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("parseOptionName() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("parseOptionName() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|