d61e7e5e1f
The dhcp server is systemd-networkd, and the dhcp plugin can request an ip but can not renew it. The systemd-networkd just ignore the renew request. ``` 2024/09/14 21:46:00 no DHCP packet received within 10s 2024/09/14 21:46:00 retrying in 31.529038 seconds 2024/09/14 21:46:42 no DHCP packet received within 10s 2024/09/14 21:46:42 retrying in 63.150490 seconds 2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: no more tries 2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: renewal time expired, rebinding 2024/09/14 21:47:45 Link "eth1" down. Attempting to set up 2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: lease rebound, expiration is 2024-09-14 22:47:45.309270751 +0800 CST m=+11730.048516519 ``` Follow the https://datatracker.ietf.org/doc/html/rfc2131#section-4.3.6, following options must not be sent in renew - Requested IP Address - Server Identifier Since the upstream code has been inactive for 6 years, we should switch to another dhcpv4 library. The new selected one is https://github.com/insomniacslk/dhcp. Signed-off-by: Songmin Li <lisongmin@protonmail.com>
73 lines
1.9 KiB
Go
73 lines
1.9 KiB
Go
// Copyright 2015 CNI authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"strconv"
|
|
|
|
dhcp4 "github.com/insomniacslk/dhcp/dhcpv4"
|
|
|
|
"github.com/containernetworking/cni/pkg/types"
|
|
)
|
|
|
|
var optionNameToID = map[string]dhcp4.OptionCode{
|
|
"dhcp-client-identifier": dhcp4.OptionClientIdentifier,
|
|
"subnet-mask": dhcp4.OptionSubnetMask,
|
|
"routers": dhcp4.OptionRouter,
|
|
"host-name": dhcp4.OptionHostName,
|
|
"user-class": dhcp4.OptionUserClassInformation,
|
|
"vendor-class-identifier": dhcp4.OptionClassIdentifier,
|
|
}
|
|
|
|
func parseOptionName(option string) (dhcp4.OptionCode, error) {
|
|
if val, ok := optionNameToID[option]; ok {
|
|
return val, nil
|
|
}
|
|
i, err := strconv.ParseUint(option, 10, 8)
|
|
if err != nil {
|
|
return dhcp4.OptionPad, fmt.Errorf("Can not parse option: %w", err)
|
|
}
|
|
return dhcp4.GenericOptionCode(i), nil
|
|
}
|
|
|
|
func classfulSubnet(sn net.IP) net.IPNet {
|
|
return net.IPNet{
|
|
IP: sn,
|
|
Mask: sn.DefaultMask(),
|
|
}
|
|
}
|
|
|
|
func parseRoutes(opt []byte) []*types.Route {
|
|
// StaticRoutes format: pairs of:
|
|
// Dest = 4 bytes; Classful IP subnet
|
|
// Router = 4 bytes; IP address of router
|
|
|
|
routes := []*types.Route{}
|
|
for len(opt) >= 8 {
|
|
sn := opt[0:4]
|
|
r := opt[4:8]
|
|
rt := &types.Route{
|
|
Dst: classfulSubnet(sn),
|
|
GW: r,
|
|
}
|
|
routes = append(routes, rt)
|
|
opt = opt[8:]
|
|
}
|
|
|
|
return routes
|
|
}
|