c347755f87
Using ptp plugin with non default routes, we get the following error
when cri-o call CheckNetworkList():
```
Expected Route {Dst:{IP:198.18.128.0 Mask:ffff8000} GW:<nil>} not found in routing table
```
Using cniVersion 0.3.1 to bypass the check, we can see that the
route is added with a gateway
```
$ ip r
198.18.0.0/17 via 198.18.0.1 dev eth0 src 198.18.3.102
198.18.0.1 dev eth0 scope link src 198.18.3.102
198.18.128.0/17 via 198.18.0.1 dev eth0
```
If GW is nil only check if we have a route with a DST that matches, and
ignore the GW.
Fixes #886
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
122 lines
3.3 KiB
Go
122 lines
3.3 KiB
Go
//go:build linux
|
|
// +build linux
|
|
|
|
// Copyright 2016 CNI authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package ip
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
|
|
"github.com/vishvananda/netlink"
|
|
|
|
"github.com/containernetworking/cni/pkg/types"
|
|
current "github.com/containernetworking/cni/pkg/types/100"
|
|
)
|
|
|
|
func ValidateExpectedInterfaceIPs(ifName string, resultIPs []*current.IPConfig) error {
|
|
// Ensure ips
|
|
for _, ips := range resultIPs {
|
|
ourAddr := netlink.Addr{IPNet: &ips.Address}
|
|
match := false
|
|
|
|
link, err := netlink.LinkByName(ifName)
|
|
if err != nil {
|
|
return fmt.Errorf("Cannot find container link %v", ifName)
|
|
}
|
|
|
|
addrList, err := netlink.AddrList(link, netlink.FAMILY_ALL)
|
|
if err != nil {
|
|
return fmt.Errorf("Cannot obtain List of IP Addresses")
|
|
}
|
|
|
|
for _, addr := range addrList {
|
|
if addr.Equal(ourAddr) {
|
|
match = true
|
|
break
|
|
}
|
|
}
|
|
if !match {
|
|
return fmt.Errorf("Failed to match addr %v on interface %v", ourAddr, ifName)
|
|
}
|
|
|
|
// Convert the host/prefixlen to just prefix for route lookup.
|
|
_, ourPrefix, err := net.ParseCIDR(ourAddr.String())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
findGwy := &netlink.Route{Dst: ourPrefix}
|
|
routeFilter := netlink.RT_FILTER_DST
|
|
|
|
family := netlink.FAMILY_V6
|
|
if ips.Address.IP.To4() != nil {
|
|
family = netlink.FAMILY_V4
|
|
}
|
|
|
|
gwy, err := netlink.RouteListFiltered(family, findGwy, routeFilter)
|
|
if err != nil {
|
|
return fmt.Errorf("Error %v trying to find Gateway %v for interface %v", err, ips.Gateway, ifName)
|
|
}
|
|
if gwy == nil {
|
|
return fmt.Errorf("Failed to find Gateway %v for interface %v", ips.Gateway, ifName)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func ValidateExpectedRoute(resultRoutes []*types.Route) error {
|
|
// Ensure that each static route in prevResults is found in the routing table
|
|
for _, route := range resultRoutes {
|
|
find := &netlink.Route{Dst: &route.Dst, Gw: route.GW}
|
|
routeFilter := netlink.RT_FILTER_DST
|
|
if route.GW != nil {
|
|
routeFilter |= netlink.RT_FILTER_GW
|
|
}
|
|
var family int
|
|
|
|
switch {
|
|
case route.Dst.IP.To4() != nil:
|
|
family = netlink.FAMILY_V4
|
|
// Default route needs Dst set to nil
|
|
if route.Dst.String() == "0.0.0.0/0" {
|
|
find = &netlink.Route{Dst: nil, Gw: route.GW}
|
|
routeFilter = netlink.RT_FILTER_DST
|
|
}
|
|
case len(route.Dst.IP) == net.IPv6len:
|
|
family = netlink.FAMILY_V6
|
|
// Default route needs Dst set to nil
|
|
if route.Dst.String() == "::/0" {
|
|
find = &netlink.Route{Dst: nil, Gw: route.GW}
|
|
routeFilter = netlink.RT_FILTER_DST
|
|
}
|
|
default:
|
|
return fmt.Errorf("Invalid static route found %v", route)
|
|
}
|
|
|
|
wasFound, err := netlink.RouteListFiltered(family, find, routeFilter)
|
|
if err != nil {
|
|
return fmt.Errorf("Expected Route %v not route table lookup error %v", route, err)
|
|
}
|
|
if wasFound == nil {
|
|
return fmt.Errorf("Expected Route %v not found in routing table", route)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|