deec68747e
Merge pull request #853 from mmorel-35/ginkgolinter
...
enable ginkgolinter linter
2023-04-04 15:24:20 +02:00
6f6345ca05
Merge pull request #871 from mlguerrero12/fixwastedassignlinter
...
Fix wastedassign linter errors
2023-04-04 15:23:28 +02:00
6c0d73ecc0
Fix wastedassign linter errors
...
Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com >
2023-03-27 18:42:49 +02:00
8813bfea7b
Merge pull request #855 from mmorel-35/linters
...
enable durationcheck, predeclared, unconvert, unused and wastedassign linters
2023-03-27 10:53:34 -05:00
16d05ec100
Merge pull request #867 from mlguerrero12/fixlinters
...
Fix revive linter errors
2023-03-27 10:49:33 -05:00
086f7eb7a1
build(deps): bump actions/stale from 7 to 8
...
Bumps [actions/stale](https://github.com/actions/stale ) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v7...v8 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-27 03:04:07 +00:00
d71d0f2da1
Fix revive linter errors
...
Golangci-lint is now running version 1.52.1. This introduced some errors.
Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com >
2023-03-24 21:04:39 +01:00
00e0d3b758
build(deps): bump actions/setup-go from 3 to 4
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](https://github.com/actions/setup-go/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-20 03:01:39 +00:00
2fb0efe8a3
enable durationcheck, predeclared, unconvert, unused and wastedassign linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-16 07:29:37 +01:00
3bc00017e3
Merge pull request #854 from mmorel-35/clean-linters
...
remove govet and gofmt from test_linux.sh
2023-03-14 11:49:37 +01:00
c0fe3b7bde
remove govet and gofmt from test_linux.sh
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-13 22:47:17 +00:00
09f36a295d
enable ginkgolinter linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-13 22:27:21 +00:00
d3ee71f240
Merge pull request #843 from mmorel-35/golangci-lint
...
ci(lint): setup golangci-lint
2023-03-13 22:26:32 +01:00
a02bf4b463
enable revive linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-13 17:59:41 +01:00
79f524689c
enable gocritic linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-13 17:59:33 +01:00
5a7619c019
enable gosimple linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-13 17:59:31 +01:00
709e775b13
enable nonamedreturns linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-13 17:59:28 +01:00
3a04eb00bb
enable ineffassign linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-06 11:51:40 +01:00
16ba4222bc
enable contextcheck linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-06 11:23:07 +01:00
177e0bf2d9
enable staticcheck linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-02 11:06:22 +01:00
d12b81dec5
ci(lint): setup golangci-lint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-03-01 06:55:40 +00:00
86e39cfe3c
Merge pull request #836 from mmorel-35/yamllint
...
ci(lint): setup yamllint linter
2023-02-28 16:35:10 +01:00
6223674f25
ci(lint): setup yamllint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-02-25 12:10:11 +00:00
36e1e162fa
Merge pull request #812 from liornoy/ginkgov2
...
Update ginkgo to v2
2023-02-20 10:58:24 -06:00
286064b9ec
Merge pull request #831 from mlguerrero12/fixerrorignored
...
Fix overwritten error var in getMTUByName
2023-02-20 10:13:34 -06:00
9ee4d3225d
Fix overwritten error var in getMTUByName
...
this prevents the error to be lost which was causing the
panic while accesing a nil var.
Fix #830
Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com >
2023-02-16 12:28:17 +01:00
2d1005ec02
Update tests to utilize ginkgo/v2
...
This commit updates the import of ginkgo to v2 in
all of the tests.
Signed-off-by: liornoy <lnoy@redhat.com >
Co-authored-by: Sascha Grunert <sgrunert@redhat.com >
2023-02-13 21:15:18 +02:00
23c2134110
Update ginkgo to v2 in go.mod, go.sum, vendor
...
This commit updates ginkgo to v2.
Note that because ginkgo/v2 requires go1.18, it was
updated as well.
Signed-off-by: liornoy <lnoy@redhat.com >
Co-authored-by: Sascha Grunert <sgrunert@redhat.com >
2023-02-13 21:15:18 +02:00
fb92605570
Merge pull request #784 from mmirecki/tap-plugin
...
Tap plugin
2023-02-13 17:26:06 +01:00
01d0031487
Tap plugin
...
This PR adds a plugin to create tap devices.
The plugin adds a tap device to the container.
The plugin has a workaround for a golang netlink library
which does not allow for tap devices with no owner/group
to be created. When no tap owner/group is requested, the
plugin will fall back to using the ip tool for creating
the tap device. A fix to the golang netlink lib is pending.
Signed-off-by: mmirecki <mmirecki@redhat.com >
2023-02-13 17:14:46 +01:00
98e01b7c80
Merge pull request #824 from containernetworking/dependabot/go_modules/github.com/onsi/gomega-1.26.0
...
build(deps): bump github.com/onsi/gomega from 1.24.2 to 1.26.0
2023-02-13 10:09:15 -06:00
9a2f763345
build(deps): bump github.com/onsi/gomega from 1.24.2 to 1.26.0
...
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega ) from 1.24.2 to 1.26.0.
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/gomega/compare/v1.24.2...v1.26.0 )
---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 10:23:59 +00:00
98359ff8b4
Merge pull request #828 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.5.0
...
build(deps): bump golang.org/x/sys from 0.4.0 to 0.5.0
2023-02-13 11:23:00 +01:00
29e6486154
build(deps): bump golang.org/x/sys from 0.4.0 to 0.5.0
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/golang/sys/releases )
- [Commits](https://github.com/golang/sys/compare/v0.4.0...v0.5.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 03:22:30 +00:00
bbf47c1083
Merge pull request #814 from mmirecki/macvlan_incontainermaster
...
Add support for in-container master for macvlans
2023-02-08 12:55:44 +01:00
5d02d91c96
Merge pull request #813 from mmirecki/ipvlan_incontainermaster
...
Add support for in-container master for ipvlan
2023-02-06 09:49:06 -06:00
755714d716
Merge pull request #781 from mmirecki/vlan_incontainermaster
...
Add support for in-container master for vlans
2023-02-06 09:47:58 -06:00
e2e14ee46f
Merge pull request #821 from mccv1r0/portmapCheck
...
Only check or del ipv6 when an IPv6 is configured
2023-02-01 14:02:07 -06:00
fb5d195fc5
Only check ipv6 when an IPv6 is configured
...
Signed-off-by: Michael Cambria <mccv1r0@gmail.com >
2023-01-27 20:22:11 -05:00
ac7cf82531
Add support for in-container master for macvlans
...
Signed-off-by: mmirecki <mmirecki@redhat.com >
2023-01-25 12:58:28 +01:00
c798f80912
Add support for in-container master for ipvlan
...
Signed-off-by: mmirecki <mmirecki@redhat.com >
2023-01-25 12:11:06 +01:00
9fa80036d3
Add support for in-container master for vlans
...
Signed-off-by: mmirecki <mmirecki@redhat.com >
2023-01-25 11:50:12 +01:00
c4d24e80d6
Merge pull request #809 from squeed/bridge-refresh-mac
...
bridge: refresh host-veth mac after port add
2023-01-16 10:56:47 -06:00
2c4c27eb17
bridge: re-fetch mac address
...
It was noticed that, sometimes, the mac of the host-side of the veth
changes after setting up the bridge. So, just refresh it.
Fixes: #805
Signed-off-by: Casey Callendrello <c1@caseyc.net >
2023-01-16 17:36:40 +01:00
0924b71fc8
Merge pull request #790 from austinvazquez/remove-ioutil-references
...
Remove references to io/ioutil package
2023-01-16 10:45:56 +01:00
0af8153e9b
Merge pull request #804 from mmorel-35/main
...
build(deps): bump github.com/safchain/ethtool to v0.2.0
2023-01-11 11:22:53 +01:00
83fe27748c
Merge pull request #803 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.4.0
...
build(deps): bump golang.org/x/sys from 0.3.0 to 0.4.0
2023-01-11 11:22:19 +01:00
bf9c25887a
Merge pull request #792 from EmilyShepherd/check-dhcp
...
Update Allocate method to reuse lease if present
2023-01-10 14:47:54 +01:00
0fc229df5e
Update Allocate method to reuse lease if present
...
Previously, the Allocate method of the daemon always created a new Lease
object. However, as both the CNI ADD and CHECK commands call Allocate,
and CHECK can be called multiple times, this resulted in multiple Lease
objects being created per pod.
Each of these leases was long lived with its own maintain() loop -
however the daemon only kept track of the most recent one, meaning any
old lease objects remained running forever (and held open their NetNS
files). After a long enough period, this resulted in the system crashing
out with "too many files" or a similar error limits-related error.
This commit updates the behaviour of Allocate() to first check if a
Lease already exists for the given clientID. If none is found, one is
created as before. If a Lease is found, a new Check() mechanism is
called, which simply wakes up the maintain() loop to cause it to check
the status of the lease.
This may fix #329 .
Signed-off-by: Emily Shepherd <emily@redcoat.dev >
2023-01-10 13:10:21 +00:00
ec924a4be2
build(deps): bump github.com/safchain/ethtool to v0.2.0
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2023-01-09 18:17:27 +00:00
