ITQC/containernetworking-plugins
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity
1,544 Commits 6 Branches 48 Tags
9dc2ed2c0aaf38eda386c840e0c41c478b7f6933
Commit Graph

567 Commits

Author SHA1 Message Date
Miguel Duarte Barroso
2052c30acd static ipam: improve error msgs when provisioning invalid CIDR 
This commit addresses the scenarios when the invalid CIDR is
provisioned via:
- CNI_ARGS
- RuntimeConfig

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
 2021-08-24 13:05:44 +02:00
Takuya Noguchi
24b3fbc635 bridge: Fix typo in error message for promiscuous mode 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
 2021-08-09 09:46:38 +00:00
Dan Williams
f14ff6687a Merge pull request #636 from EdDev/bridge-mac-specification 
bridge: Add mac field to specify container iface mac
 2021-06-30 10:57:09 -05:00
Edward Haas
a3cde17fc0 bridge: Add mac field to specify container iface mac 
Controlling the mac address of the interface (veth peer) in the
container is useful for functionalities that depend on the mac address.
Examples range from dynamic IP allocations based on an identifier (the
mac) and up to firewall rules (e.g. no-mac-spoofing).

Enforcing a mac address at an early stage and not through a chained
plugin assures the configuration does not have wrong intermediate
configuration. This is especially critical when a dynamic IP may be
provided already in this period.
But it also has implications for future abilities that may land on the
bridge plugin, e.g. supporting no-mac-spoofing.

The field name used (`mac`) fits with other plugins which control the
mac address of the container interface.

The mac address may be specified through the following methods:
- CNI_ARGS
- Args
- RuntimeConfig [1]

The list is ordered by priority, from lowest to higher. The higher
priority method overrides any previous settings.
(e.g. if the mac is specified in RuntimeConfig, it will override any
specifications of the mac mentioned in CNI_ARGS or Args)

[1] To use RuntimeConfig, the network configuration should include the
`capabilities` field with `mac` specified (`"capabilities": {"mac": true}`).

Signed-off-by: Edward Haas <edwardh@redhat.com>
 2021-06-29 10:50:19 +03:00
Miguel Duarte Barroso
a786b12b68 static ipam: decide wrong cidr error msg 
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
 2021-06-25 11:24:56 +01:00
Miguel Duarte Barroso
0db5882a12 static ipam: stop wrapping net.ParseCIDR errors 
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
 2021-06-25 11:24:56 +01:00
Miguel Duarte Barroso
5a408187d4 static ipam: show confusing error msg 
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
 2021-06-25 11:24:54 +01:00
Casey Callendrello
77233dd79d plugins: remove flannel 
Now that the flannel CNI plugin has been moved to
https://github.com/flannel-io/cni-plugin, we should remove it from here.

Signed-off-by: Casey Callendrello <cdc@redhat.com>
 2021-06-02 17:38:32 +02:00
thxcode
4b180a9d9c refactor(win-bridge): netconf 
- support v2 api
- unify v1 and v2 api

BREAKING CHANGE:
- remove `HcnPolicyArgs` field
- merge `HcnPolicyArgs` into `Policies` field

Signed-off-by: thxcode <thxcode0824@gmail.com>
 2021-05-27 23:49:16 +08:00
thxcode
ec75bb8587 chore(win-bridge): text related 
- format function names
- add/remove comments
- adjust message of error

Signed-off-by: thxcode <thxcode0824@gmail.com>
 2021-05-27 23:14:11 +08:00
Dan Williams
6618a0aba8 Merge pull request #623 from anuragensemble/multi-ip-intf 
Add multi IP support for SBR
 2021-05-19 10:33:40 -05:00
Bruce Ma
af26bab500 host-local: support ip/prefix in env args and CNI args 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
 2021-05-17 21:12:45 +08:00
Anurag Dwivedi
f72aa98629 [sbr]: Use different tableID for every ipCfg 
Check tableID not in use for every ipCfg

       This allows SBR plugin to accommodate for multi-ip interfaces

       Fixes #581

Signed-off-by: Anurag Dwivedi <anuragensemble1@gmail.com>
 2021-05-15 19:33:58 +05:30
Casey Callendrello
d917ab6b0c Merge pull request #599 from mars1024/feat/hostlocal-ips 
host-local: support custom IPs allocation through runtime configuraton
 2021-05-05 11:33:27 -04:00
Dan Williams
faf6d2629d Merge pull request #626 from Luap99/tuning-mac 
tuning: always update MAC in CNI result
 2021-05-05 10:24:13 -05:00
Paul Holzinger
bdaaa20ef2 tuning: always update MAC in CNI result 
Since the CNI Spec bump to v1.0 the tuning plugin no longer updates the
mac address in the cni result for 0.4.0 or below configs. I don't think
this ever worked when the cni result was converted to a different version.

A test has been added to ensure it is working for all spec versions.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
 2021-05-05 13:48:47 +02:00
Björn Svensson
820fee9c33 tuning: Add support of altering the allmulticast flag 
This adds support to allow the tuning plugin to enable/disable the
allmulticast mode of the interface. When enabled it instructs the
network driver to retrieve all multicast packets from the network.

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
 2021-04-28 10:20:04 +02:00
Anurag Dwivedi
f34c600ea4 [sbr]: Use different tableID for every ipCfg 
Move default table routes which  match the ipCfg config

    This allows SBR plugin to accommodate for multi-ip interfaces

    Fixes #581

Signed-off-by: Anurag Dwivedi <anuragensemble1@gmail.com>
 2021-04-27 12:34:30 +05:30
Casey Callendrello
b41052c547 Merge pull request #593 from thetechnick/ipam-static-nil-check-fix 
Fix nil-pointer check
 2021-04-14 18:00:42 +02:00
Nico Schieder
8f32968f73 Fix nil-pointer check 
Signed-off-by: Nico Schieder <nschieder@redhat.com>
 2021-04-13 13:42:23 +02:00
Bruce Ma
028fc2f219 host-local: support custom IPs allocation through runtime configuration 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
 2021-04-13 17:53:43 +08:00
Sebastiaan van Stijn
bc856372bb go.mod: godbus/dbus/v5 v5.0.3, coreos/go-systemd v22.2.0 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2021-04-09 00:07:25 +02:00
Kavya
5b02c2ab70 Fix broken links to online docs in plugin READMEs 
Signed-off-by: Kavya <kavya.g@ibm.com>
 2021-03-25 13:07:33 +05:30
Bruce Ma
b811967444 remove redundant startRange in RangeIter due to overlap check on multi ranges 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
 2021-03-04 11:50:54 +08:00
Dan Williams
d385120175 Merge pull request #537 from dcbw/100 
Port plugins to CNI 1.0.0 and increase old verison test coverage
 2021-03-03 10:51:56 -06:00
Dan Williams
1c1799ef39 Merge pull request #589 from mars1024/feat/sysctl 
portmap: use slashes in sysctl template to support interface names which separated by dots
 2021-03-03 10:19:02 -06:00
thxcode
178d7c0934 fix(win-bridge): panic while calling HNS api 
Signed-off-by: thxcode <thxcode0824@gmail.com>
 2021-02-26 10:49:02 +08:00
Bruce Ma
e09a17fe64 portmap: use slashes in sysctl template to support interface names which separated by dots 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
 2021-02-25 14:47:34 +08:00
Piotr Skamruk
e31cd2ce1a [macvlan] Stop setting proxy-arp on macvlan interface 
The original issue was: https://github.com/containernetworking/cni/issues/84
I've added "a fix" for it in
https://github.com/containernetworking/cni/pull/149 which then was
merged in https://github.com/containernetworking/cni/pull/177

The thing is that "the fix" was incorrect as it was setting 1 on
arp_proxy (I really don't recall why) instead of setting it on
arp_notify - which was my original suggestion in:
https://github.com/rkt/rkt/issues/1765#issuecomment-188776317
Setting apr_proxy can be harmfull and we have already support for
sending GratuitousArpOverIface after setting an IP address, so setting
any sysctl should not be needed.

Signed-off-by: Piotr Skamruk <piotr.skamruk@gmail.com>
 2021-02-21 11:34:12 +01:00
Dan Williams
8e540bf3dc tuning: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-15 10:25:20 -06:00
Dan Williams
d2e5b5decb portmap: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-15 10:08:24 -06:00
Dan Williams
8f7fe6d8e8 flannel: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 15:12:54 -06:00
Dan Williams
f33eedb6eb firewall: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 14:56:24 -06:00
Dan Williams
da52be35bc bandwidth: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 14:56:24 -06:00
Dan Williams
02cdaafe93 host-local: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 14:56:24 -06:00
Dan Williams
f534133ec7 static: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 14:41:38 -06:00
Dan Williams
932653fd3f dhcp: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 14:41:38 -06:00
Dan Williams
dd3f6064f6 dhcp: add -resendmax option to limit lease acquisition time for testcases 
The default lease acquisition timeout of 62 seconds is way too long when
running multiple testcases, overrunning the `go test` timeout of 10m. Let
testcases specify a shorter timeout.

Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-12 14:41:38 -06:00
Dan Williams
4ddc8ba460 vlan: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
f56545ca74 ptp: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
bbf7189c32 macvlan: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
5eae558a8e loopback: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
5096b53918 ipvlan: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
34cee8c758 host-device: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
c3c286c1c9 bridge: increase test coverage to 1.0.0 and older spec versions 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
c8f341dff9 bridge: simplify version-based testcase code 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Dan Williams
7d8c767622 plugins: update to spec version 1.0.0 
Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-02-11 23:27:08 -06:00
Micah Hausler
fa48f7515b ipam/dhcp: Add broadcast flag 
Signed-off-by: Micah Hausler <hausler.m@gmail.com>
 2021-02-05 16:38:32 +01:00
yaoice
8feef71fd3 add flannel to support dual stack ip 
support three mode ip stack:
- only ipv4 stack
- only ipv6 stack
- dual stack ip

Signed-off-by: yaoice <yao3690093@gmail.com>
 2021-01-27 17:18:02 +01:00
Shengjing Zhu
343d233b4f bandwidth: fix panic in tests 
Check error before using return value

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
 2021-01-25 01:13:27 +08:00