ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity
1,638 Commits 6 Branches 48 Tags
68a661999a558a4d022115efb053b451e5c3e45c
Commit Graph

1638 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Emily Shepherd
0fc229df5e Update Allocate method to reuse lease if present 
Previously, the Allocate method of the daemon always created a new Lease
object. However, as both the CNI ADD and CHECK commands call Allocate,
and CHECK can be called multiple times, this resulted in multiple Lease
objects being created per pod.

Each of these leases was long lived with its own maintain() loop -
however the daemon only kept track of the most recent one, meaning any
old lease objects remained running forever (and held open their NetNS
files). After a long enough period, this resulted in the system crashing
out with "too many files" or a similar error limits-related error.

This commit updates the behaviour of Allocate() to first check if a
Lease already exists for the given clientID. If none is found, one is
created as before. If a Lease is found, a new Check() mechanism is
called, which simply wakes up the maintain() loop to cause it to check
the status of the lease.

This may fix #329.

Signed-off-by: Emily Shepherd <emily@redcoat.dev>
 2023-01-10 13:10:21 +00:00
Matthieu MOREL
ec924a4be2 build(deps): bump github.com/safchain/ethtool to v0.2.0 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-01-09 18:17:27 +00:00
Casey Callendrello
d27fabcd83 Merge pull request #782 from mars1024/bugfix/next-ip 
fix bug on getting NextIP of addresses with first byte 0
 2023-01-09 18:02:45 +01:00
dependabot[bot]
20a92ff382 build(deps): bump golang.org/x/sys from 0.3.0 to 0.4.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/compare/v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-01-09 16:59:28 +00:00
Casey Callendrello
5c29eb7fb5 Merge pull request #801 from mmorel-35/main 
ci(deps): setup dependabot
 2023-01-09 17:58:48 +01:00
Casey Callendrello
f48a5ea512 Merge pull request #798 from mmirecki/pathissue_fix 
Fix tuning path validation
 2023-01-09 17:48:00 +01:00
Casey Callendrello
a3b678ee03 Merge pull request #772 from BSWANG/master 
`portmap` support masquerade all
 2023-01-09 17:41:52 +01:00
Casey Callendrello
87ccb8918b Merge pull request #802 from Y7n05h/main 
Add IPv6 support for AddDefaultRoute
 2023-01-09 17:38:37 +01:00
Y7n05h
fa2ed0fd6e Add IPv6 support for AddDefaultRoute 
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
 2022-12-28 15:37:29 +08:00
dependabot[bot]
b769956cf4 build(deps): bump github.com/containernetworking/cni from 1.0.1 to 1.1.2 
Bumps [github.com/containernetworking/cni](https://github.com/containernetworking/cni) from 1.0.1 to 1.1.2.
- [Release notes](https://github.com/containernetworking/cni/releases)
- [Commits](https://github.com/containernetworking/cni/compare/v1.0.1...v1.1.2)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/cni
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
df141fc722 build(deps): bump github.com/coreos/go-systemd/v22 from 22.3.2 to 22.5.0 
Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.3.2 to 22.5.0.
- [Release notes](https://github.com/coreos/go-systemd/releases)
- [Commits](https://github.com/coreos/go-systemd/compare/v22.3.2...v22.5.0)

---
updated-dependencies:
- dependency-name: github.com/coreos/go-systemd/v22
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
35047644a8 build(deps): bump github.com/onsi/ginkgo from 1.16.4 to 1.16.5 
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.16.4 to 1.16.5.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v1.16.4...v1.16.5)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
352f181ff1 build(deps): bump alpine in /.github/actions/retest-action 
Bumps alpine from 3.10 to 3.17.

---
updated-dependencies:
- dependency-name: alpine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
91b1a0e385 build(deps): bump github.com/godbus/dbus/v5 from 5.0.4 to 5.1.0 
Bumps [github.com/godbus/dbus/v5](https://github.com/godbus/dbus) from 5.0.4 to 5.1.0.
- [Release notes](https://github.com/godbus/dbus/releases)
- [Commits](https://github.com/godbus/dbus/compare/v5.0.4...v5.1.0)

---
updated-dependencies:
- dependency-name: github.com/godbus/dbus/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
648dd2e14c build(deps): bump github.com/vishvananda/netlink 
Bumps [github.com/vishvananda/netlink](https://github.com/vishvananda/netlink) from 1.2.0-beta to 1.2.1-beta.2.
- [Release notes](https://github.com/vishvananda/netlink/releases)
- [Commits](https://github.com/vishvananda/netlink/compare/v1.2.0-beta...v1.2.1-beta.2)

---
updated-dependencies:
- dependency-name: github.com/vishvananda/netlink
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
615420fa9f build(deps): bump github.com/alexflint/go-filemutex from 1.1.0 to 1.2.0 
Bumps [github.com/alexflint/go-filemutex](https://github.com/alexflint/go-filemutex) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/alexflint/go-filemutex/releases)
- [Commits](https://github.com/alexflint/go-filemutex/compare/v1.1...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/alexflint/go-filemutex
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
90ed30a55a build(deps): bump github.com/Microsoft/hcsshim from 0.8.20 to 0.9.6 
Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.8.20 to 0.9.6.
- [Release notes](https://github.com/Microsoft/hcsshim/releases)
- [Commits](https://github.com/Microsoft/hcsshim/compare/v0.8.20...v0.9.6)

---
updated-dependencies:
- dependency-name: github.com/Microsoft/hcsshim
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
020b8db6ab build(deps): bump github.com/onsi/gomega from 1.15.0 to 1.24.2 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.15.0 to 1.24.2.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.15.0...v1.24.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
Matthieu MOREL
c5e81e3c05 Update dependabot.yml 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
3be17f4af7 build(deps): bump actions/checkout from 2 to 3 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
f64652faf8 build(deps): bump actions/stale from 4 to 7 
Bumps [actions/stale](https://github.com/actions/stale) from 4 to 7.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/v4...v7)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
dependabot[bot]
edfd2274a5 build(deps): bump actions/setup-go from 2 to 3 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
Matthieu MOREL
d7efab18c0 Update dependabot.yml 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
Matthieu MOREL
12471312e1 Update dependabot.yml 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
Matthieu MOREL
c1e2be2765 ci(deps): setup dependabot 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2022-12-26 21:36:15 +00:00
mmirecki
fd9408bc97 Fix tuning path validation 
Signed-off-by: mmirecki <mmirecki@redhat.com>
 2022-12-16 11:55:33 +01:00
Dan Williams
ec76e3c35c Merge pull request #793 from EmilyShepherd/fix-ci 
Fix Tests: Update portmap test's iptables error check
 2022-12-12 10:48:32 -06:00
Dan Williams
c30b47a712 Merge pull request #795 from MikeZappa87/updateemailtogmail 
Update email to gmail
 2022-12-12 10:47:48 -06:00
Michael Zappa
9dc2ed2c0a Update email to gmail 
Signed-off-by: Michael Zappa <michael.zappa@gmail.com>
 2022-12-07 11:57:16 -07:00
Emily Shepherd
6b30e290d2 Update portmap test's iptables error check 
GitHub Actions recently updated ubuntu-latest to 22.04 [1], which now
defaults to nfttables (rather than iptables-legacy) [2]. The portmap
tests in this project are written with the expectation that expected
error message for one test is in the iptables-legacy format.

This commit updates the check to make it work for both the
iptables-legecy and iptables-nftables variants.

References:
[1]: 4aba37bd3b
[2]: https://ubuntu.com/blog/whats-new-in-security-for-ubuntu-22-04-lts

Signed-off-by: Emily Shepherd <emily@redcoat.dev>
 2022-12-06 18:56:59 +00:00
Austin Vazquez
1a6f478913 Remove references to io/ioutil package 
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
 2022-12-01 22:27:05 +00:00
Bruce Ma
63a6dbcfd6 fix bug on getting NextIP of addresses with first byte 0 
1. get the right next IP of addresses of first byte 0
2. refactor some methods to handle illegal IPs or IPNets
3. add some unit tests

Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
 2022-11-17 17:54:16 +08:00
Dan Williams
7e9ada51e7 Merge pull request #779 from mmirecki/sysctl_on_vlan 
Fix path substitution to enable setting sysctls on vlan interfaces
 2022-11-14 10:51:25 -06:00
mmirecki
198ab129a1 Fix path substitution to enable setting sysctls on vlan interfaces 
This commit changes the order of substituting sysctl path to first handle
. to / change, before substituting the interface name.
This is needed as vlan interfaces have a . in the name, which should not
be changed.

Signed-off-by: mmirecki <mmirecki@redhat.com>
 2022-11-09 11:31:58 +01:00
bingshen.wbs
0463fd19af support masquerade all config 
Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>
 2022-11-07 13:50:21 +08:00
Casey Callendrello
ac8673105a Merge pull request #743 from arista-eosplus/dummy-plugin 
dummy: Create a Dummy CNI plugin that creates a virtual interface.
 2022-10-10 17:51:00 +02:00
Dan Williams
fcf14d39fd Merge pull request #769 from jingyuanliang/main 
host-local: remove unused Release(ip) from type Store interface
 2022-09-19 10:55:33 -05:00
Dan Williams
54f69e0a59 Merge pull request #768 from EmilyShepherd/cleanup-socket-on-exit 
Cleanup Socket and Pidfile on exit
 2022-09-12 10:34:39 -05:00
Jingyuan Liang
87c3643d3c host-local: remove unused Release(ip) from type Store interface 
Signed-off-by: Jingyuan Liang <jingyuanliang@google.com>
 2022-09-06 21:39:54 +00:00
Emily Shepherd
f89a005740 Cleanup Socket and Pidfile on exit 
These were previously left intact, even when exiting gracefully. As the
daemon also fails if the socket already exists, it became the caller's
responsibilityto check for and cleanup old socket files when performing
graceful / deliberate restarts.

Signed-off-by: Emily Shepherd <emily@redcoat.dev>
 2022-09-06 15:11:57 +01:00
Mircea Iordache-Sica
7fcf8e4860 dummy: Create a Dummy CNI plugin that creates a virtual interface. 
Leverages the Linux dummy interface type to create network interfaces
that permists routing packets through the Linux kernel without
them being transmitted.

This solution allows use of arbitrary non-loopback IP addresses within
the container.

Related to #466

Signed-off-by: Mircea Iordache-Sica <mircea@arista.com>
 2022-08-11 13:50:37 +01:00
Dan Williams
8c3664b2b1 Merge pull request #742 from lx1036/patch-1 
bridge: update vlanFiltering variable to make code more readable
 2022-07-28 09:13:29 -05:00
Dan Williams
e2a71387ab Merge pull request #755 from akhilles/fix/dhcp-renew-hostname 
Use the same options for acquiring, renewing lease
 2022-07-27 10:37:31 -05:00
Akhil Velagapudi
c78e1e4656 Use the same options for acquiring, renewing lease 
Currently, hostname is set in the original DHCPREQUEST but not the
renewal. With some DHCP server implementations (such as FreeBSD dhcpd),
this leads to the hostname being cleared in the lease table.

This behavior is inconsistent with other DHCP clients such as dhclient
which set the hostname on the renewal request as well. To fix, use the
same options for acquire and renew.

This is compatible with RFC 2131 (see table 5).

Signed-off-by: Akhil Velagapudi <4@4khil.com>
 2022-06-23 17:47:37 -07:00
Xiang Liu
9f4090dabf bridge: update vlanFiltering variable to make code more readable 
Signed-off-by: Xiang Liu <lx1036@126.com>
 2022-05-21 14:37:36 +08:00
Dan Williams
9c59728d39 Merge pull request #730 from mmirecki/tuning_duplicate_check 
Check for duplicated sysctl keys
 2022-05-04 11:21:35 -05:00
Dan Williams
6a94696205 Merge pull request #712 from mesosphere/joe/add_error_output 
bug: return errors when iptables and ip6tables are unusable
 2022-05-04 11:01:41 -05:00
Dan Williams
356db54531 Merge pull request #740 from jpsim/patch-1 
ci: only rerun failed jobs on `/retest`
 2022-05-04 11:00:26 -05:00
Casey Callendrello
f7dfa0f600 Merge pull request #739 from AkihiroSuda/riscv64 
build: support riscv64
 2022-05-04 17:44:44 +02:00
JP Simard
f1aa6c2622 ci: only rerun failed jobs on /retest 
Unlike `rerun_url`, this endpoint isn't in the run API response,
but we can construct it manually easily.

Documentation for it is here:
https://docs.github.com/en/rest/actions/workflow-runs#re-run-failed-jobs-from-a-workflow-run

Signed-off-by: JP Simard <jp@jpsim.com>
 2022-04-28 22:13:02 -04:00