Michael Wyrick
1324428a9a
Ran go fmt so tests would pass
...
Signed-off-by: Michael Wyrick <Michael.Wyrick@caci.com >
2021-12-28 10:43:52 -05:00
Michael Wyrick
fd4c3350ae
Fixed DHCP problem that broke when fast retry was added.
...
Signed-off-by: Michael Wyrick <Michael.Wyrick@caci.com >
2021-12-27 13:48:44 -05:00
SilverBut
c9d0423023
dhcp ipam: adjust retry mechanism
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-11-28 06:41:53 +08:00
SilverBut
27fdec5cb9
dhcp ipam: fix client id
...
First byte of client ID is type, instead of value. See this from
RFC2132:
Code Len Type Client-Identifier
+-----+-----+-----+-----+-----+---
| 61 | n | t1 | i1 | i2 | ...
+-----+-----+-----+-----+-----+---
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-03 05:57:27 +08:00
SilverBut
a1051f3bf1
dhcp ipam: rename inconsistent options among files
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 23:49:59 +08:00
SilverBut
c627ea807c
dhcp ipam: add more options capable for sending
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 23:30:59 +08:00
SilverBut
4b216e9d9b
dhcp ipam: add fast retry
...
Almost every first retry of DHCP will fail due to interface is not up. Add a
fast retry to reduce unnecessary latency.
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 23:04:24 +08:00
SilverBut
2bebd89aa2
dhcp ipam: support customizing dhcp options
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 22:48:05 +08:00
SilverBut
be383cf30d
dhcp ipam: truncate client id to 254 bytes
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 22:41:05 +08:00
SilverBut
6d1f71e55a
dhcp ipam: print error correctly without format string
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 22:40:44 +08:00
SilverBut
24259e7d21
dhcp ipam: using full config to regular the code
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-10-02 22:40:19 +08:00
SilverBut
7cb3453c36
dhcp: remove implemented TODO
...
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com >
2021-09-30 13:10:45 +00:00
Sebastiaan van Stijn
bc856372bb
go.mod: godbus/dbus/v5 v5.0.3, coreos/go-systemd v22.2.0
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2021-04-09 00:07:25 +02:00
Kavya
5b02c2ab70
Fix broken links to online docs in plugin READMEs
...
Signed-off-by: Kavya <kavya.g@ibm.com >
2021-03-25 13:07:33 +05:30
Dan Williams
932653fd3f
dhcp: increase test coverage to 1.0.0 and older spec versions
...
Signed-off-by: Dan Williams <dcbw@redhat.com >
2021-02-12 14:41:38 -06:00
Dan Williams
dd3f6064f6
dhcp: add -resendmax option to limit lease acquisition time for testcases
...
The default lease acquisition timeout of 62 seconds is way too long when
running multiple testcases, overrunning the `go test` timeout of 10m. Let
testcases specify a shorter timeout.
Signed-off-by: Dan Williams <dcbw@redhat.com >
2021-02-12 14:41:38 -06:00
Dan Williams
7d8c767622
plugins: update to spec version 1.0.0
...
Signed-off-by: Dan Williams <dcbw@redhat.com >
2021-02-11 23:27:08 -06:00
Micah Hausler and Casey Callendrello
fa48f7515b
ipam/dhcp: Add broadcast flag
...
Signed-off-by: Micah Hausler <hausler.m@gmail.com >
2021-02-05 16:38:32 +01:00
toby lorne and bruce ma
a8d1f5cd1b
dhcp: default dhcp clien timeout is 10s
...
Consistent with https://github.com/d2g/dhcp4client/blob/ef524ad9cb076fe235ecc3c55913ef8445fa35fa/client.go#L39
Signed-off-by: toby lorne <toby@toby.codes >
Co-authored-by: bruce ma <brucema19901024@gmail.com >
2021-01-13 19:24:41 +00:00
toby lorne
25fc741e37
dhcp: daemon dhcp client timeout is configurable
...
Fixes #470
Signed-off-by: toby lorne <toby@toby.codes >
2021-01-11 22:13:54 +00:00
toby lorne
3161bb52e0
dhcp: timeout value is set in DHCP daemon
...
Eventually the timeout value will become a CLI argument
The default timeout was nestled all the way in the lease constructor
This commit is the first step in making the timeout configurable by
moving it to the DHCPLease constructor
Signed-off-by: toby lorne <toby@toby.codes >
2021-01-11 22:13:54 +00:00
Nate W and GitHub
cccf5395e8
Updating plugin README.md files ( #549 )
...
Removing content and pointing at the new website as a part of the CNI Documentation migration.
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com >
2020-11-18 17:38:45 +01:00
xieyanker
50a3aa6536
Xdhcp: fix example configuration
...
The current cni config has an extra comma and cannot be parsed normally, the kubelet will report an error as follows:
"Error loading CNI config file: error parsing configuration: invalid character '}' looking for beginning of object key string"
Signed-off-by: xieyanker <xjsisnice@gmail.com >
2020-11-10 07:48:36 +00:00
Aneesh Puttur
d4775ecff5
Fix handling of delay in acquiring lease with stp turned on
...
Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com >
2020-06-29 13:15:00 -04:00
Casey Callendrello
72f2a1ffd4
plugins: correctly output build version, cosmetic cleanups
...
Now that libcni has the ability to print a version message, plumb it
through correctly.
While we're at it,
- fix import paths
- run gofmt
- add some more comments to sample
- add container runtime swappability for release
2019-04-15 16:52:07 +02:00
Casey Callendrello and GitHub
fbd9accd14
Merge pull request #268 from s1061123/fix/dhcp_daemon_hostprefix
...
Fix -hostprefix option
2019-04-08 12:53:09 +02:00
Tomofumi Hayashi
8b53f80fa8
Incorporate with @bboreham comment
2019-04-05 03:38:20 +09:00
Dan Williams and GitHub
18874aac7d
Merge pull request #264 from mccv1r0/add-check
...
Add CHECK support for linux plugins
2019-04-03 12:58:41 -05:00
Michael Cambria
74a2596573
Add check support for: bridge, ipvlan, macvlan, p2p, vlan and host-device main plugins
...
host-local and static ipam plugins
tuning, bandwidth and portmap meta plugins
Utility functions created for common PrevResult checking
Fix windows build
2019-04-03 13:08:07 -04:00
Dan Williams and GitHub
8a3d149a60
Merge pull request #284 from francares/fmc_dhcp_subnetmask
...
IPAM/DHCP: include Subnet Mask option parameter in DHCPREQUEST
2019-04-01 14:56:13 -05:00
Casares, Francisco M
d577d9cc24
DHCP: include Subnet Mask option parameter in DHCPREQUEST
...
DHCP REQUEST from DHCP plugin does not include Subnet Mask option parameter (1). Some DHCP servers need that option to be explicit in order to return it in a DHCPACK message.
If not, DHCP plugin returns "DHCP option Subnet Mask not found in DHCPACK" error msg in this type of scenario.
2019-03-26 12:49:48 -07:00
Tomofumi Hayashi
4ec62ac295
Fix -hostprefix option
...
Fix #267
2019-03-26 18:27:46 +09:00
Tomofumi Hayashi
b1814d7f9a
Add systemd unit file to activate socket with systemd
...
This changes to add sample systemd unit files to activate socket
with systemd. Fix #156 .
2019-03-14 16:03:23 +09:00
Saravana Periyasamy
f891fd9e9a
some DHCP servers expect to request for explicit router options
2019-01-28 19:44:53 -06:00
JoeWrightss
f0208611ad
Fix some spelling errors
...
Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io >
2018-12-29 21:26:28 +08:00
Michael Cambria
0af31fc4d0
Change dhcp plugin to send ClientID allowing container to have multiple CNI
...
interfaces using dhcp ipam.
Vendor latest dhcp4server, dhcp4client, dhcp4
Added additional tests for new functionality in dhcp2_test.go
Wrap d2g dhcp4client calls with our own which add clientID to packet.
2018-11-15 11:31:56 -05:00
Michael Cambria
227a4c15fa
Add container ifName to the dhcp clientID, making the clientID value
...
now equal to: ContainerID / Host Network / ifname inside container
Use clientID as a key for the lease
2018-11-09 17:27:05 -05:00
Michael Cambria
22b11bb367
Keep defaultSocketPath the same as before
2018-10-10 11:35:57 -04:00
Michael Cambria
73106f0ece
Remove unused pidfilePath const
...
Moved global var's to BeforeEach()
2018-10-09 16:57:58 -04:00
Michael Cambria
ef913eadd5
Took out os.Remove() for socketPath and pidfilePath now that os.RemoveAll() is used
2018-10-08 16:01:31 -04:00
Michael Cambria
3d349e4645
Ensure /run/cni exists in the filesystem before running dhcp tests
2018-10-08 14:08:37 -04:00
Michael Cambria
5fd849ac6d
Use tempDir in socket path for ginkgo parallelization
2018-10-08 11:31:03 -04:00
Michael Cambria
6d3215a256
Allow socket path used by dhcp plugin to be supplied via dhcp ipam configuration
...
Allow socket path to be supplied as flag when starting dhcp daemon
2018-10-08 11:30:01 -04:00
Michal Rostecki
1a3f49c7ae
plugins/ipam: Add missing error check
...
Signed-off-by: Michal Rostecki <mrostecki@suse.de >
2018-09-20 11:05:58 +02:00
Casey Callendrello
68b4efb405
plugins/* stub-out GET functions so plugins build with v0.7
2018-06-15 15:28:53 +02:00
Luca Bruno
475fdb8a0a
plugins/dhcp: update to new go-systemd
2018-05-28 12:35:04 +00:00
Dan Williams
731298003c
plugins/testutils: pass CNI_CONTAINERID to plugins in testcases
...
Recent CNI specification changes require the container ID on ADD/DEL,
which the testcases were not providing. Fix that up so things work
when this repo gets CNI revendored.
2018-04-26 11:24:30 -05:00
Casey Callendrello
aade7b93ee
build: some small improvements; bump to go1.10
...
- bump to go 1.10
- Add a linker tag with the build version
- Remove fastbuild, go builds are cached now
- Use better ginkgo suite names
2018-04-12 16:59:51 +02:00
Casey Callendrello
a0eac8d7d9
pkg/ns: remove namespace creation (and move to testutils)
...
Namespace creation had an unergonomic interface and isn't used, except
for testing code. Remove it; downstream users should really be creating
their own namespaces
2018-04-03 18:56:25 +02:00
Dan Williams and GitHub
372bb5e826
Merge pull request #119 from jzwlqx/master
...
dhcp: clean duplicated error message
2018-02-21 11:09:15 -06:00