ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity
1,818 Commits 6 Branches 48 Tags
Commit Graph

1818 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthieu MOREL
6b7876125d fix workflow warnings 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-10-31 09:07:15 +01:00
Casey Callendrello
2f0faf6721
Merge pull request #967 from squeed/fix-lint 
fix lint errors
 2023-10-31 08:40:30 +01:00
Casey Callendrello
37531cdaf5 fix lint errors 
Fix a small ginkgo compare issue, and ignore dot imports.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
 2023-10-30 17:55:55 +01:00
Casey Callendrello
a8d4e0a7dd
Merge pull request #949 from containernetworking/dependabot/go_modules/github.com/onsi/gomega-1.28.0 
build(deps): bump github.com/onsi/gomega from 1.27.8 to 1.28.0
 2023-10-17 12:31:08 +02:00
cyclinder
845ef62b74 macvlan cmdDel: replace the loadConf function with json.unmarshal 
When the master interface on the node has been deleted, and loadConf tries
to get the MTU, This causes cmdDel to return a linkNotFound error to the
runtime. The cmdDel only needs to unmarshal the netConf. No need to
get the MTU. So we just replaced the loadConf function with
json.unmarshal in cmdDel.

Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
 2023-10-17 10:26:18 +08:00
dependabot[bot]
691186ca7f
build(deps): bump github.com/onsi/gomega from 1.27.8 to 1.28.0 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.27.8 to 1.28.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.27.8...v1.28.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-10-16 15:44:53 +00:00
Casey Callendrello
adaeedd6af
Merge pull request #955 from containernetworking/dependabot/go_modules/golang.org/x/net-0.17.0 
build(deps): bump golang.org/x/net from 0.10.0 to 0.17.0
 2023-10-16 17:43:46 +02:00
dependabot[bot]
19e5747a8c
build(deps): bump golang.org/x/net from 0.10.0 to 0.17.0 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.10.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-10-16 15:26:26 +00:00
Casey Callendrello
4cf3da4ae3
Merge pull request #948 from twz123/posix-sh 
build: Use POSIX sh for shell scripts
 2023-10-16 17:25:04 +02:00
Casey Callendrello
c20da1521f
Merge pull request #952 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.13.0 
build(deps): bump golang.org/x/sys from 0.10.0 to 0.13.0
 2023-10-16 17:24:51 +02:00
Casey Callendrello
b66b5dd85f
Merge pull request #945 from containernetworking/dependabot/github_actions/actions/checkout-4 
build(deps): bump actions/checkout from 3 to 4
 2023-10-16 17:23:45 +02:00
Casey Callendrello
e727ad6697
Merge pull request #946 from containernetworking/dependabot/go_modules/github.com/Microsoft/hcsshim-0.11.1 
build(deps): bump github.com/Microsoft/hcsshim from 0.9.9 to 0.11.1
 2023-10-16 17:23:25 +02:00
dependabot[bot]
18172539d8
build(deps): bump github.com/Microsoft/hcsshim from 0.9.9 to 0.11.1 
Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.9 to 0.11.1.
- [Release notes](https://github.com/Microsoft/hcsshim/releases)
- [Commits](https://github.com/Microsoft/hcsshim/compare/v0.9.9...v0.11.1)

---
updated-dependencies:
- dependency-name: github.com/Microsoft/hcsshim
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-10-16 15:11:01 +00:00
Casey Callendrello
f20b8408a4
Merge pull request #937 from containernetworking/dependabot/go_modules/github.com/coreos/go-iptables-0.7.0 
build(deps): bump github.com/coreos/go-iptables from 0.6.0 to 0.7.0
 2023-10-16 17:10:05 +02:00
Dan Williams
6ff8e5eb86
Merge pull request #950 from ricky-rav/OCPBUGS-16788 
Create IPAM files with 0600 permissions
 2023-10-12 09:13:05 -05:00
dependabot[bot]
61fa963636
build(deps): bump golang.org/x/sys from 0.10.0 to 0.13.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.10.0 to 0.13.0.
- [Commits](https://github.com/golang/sys/compare/v0.10.0...v0.13.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-10-09 02:20:37 +00:00
Riccardo Ravaioli
33ccedc66f Create IPAM files with 0600 permissions 
Conform to CIS Benchmarks "1.1.9 Ensure that the Container Network Interface file permissions are set to 600 or more restrictive"
https://www.tenable.com/audits/items/CIS_Kubernetes_v1.20_v1.0.1_Level_1_Master.audit:f1717a5dd65d498074dd41c4a639e47d

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
 2023-10-02 11:59:31 +02:00
Tom Wieczorek
853b82d19f
build: Use POSIX sh for shell scripts 
The scripts didn't really use any bash specific features. Convert
them to POSIX shell scripts, so that the plugins can be built without
requiring bash.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
 2023-09-29 16:57:19 +02:00
dependabot[bot]
d216b0c39b
build(deps): bump actions/checkout from 3 to 4 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-09-11 02:11:46 +00:00
Casey Callendrello
f95505231a
Merge pull request #942 from mmorel-35/patch-1 
ci(lint) extend timeout to 5 min
 2023-09-04 17:18:17 +02:00
Matthieu MOREL
5f25a93a47 ci(lint) extend timeout to 5 min 
This extends the timeout or golangci-lint execution to 5 min as it is only one minute now it fails for several PR.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-09-01 20:45:00 +00:00
dependabot[bot]
7c11d48630
build(deps): bump github.com/coreos/go-iptables from 0.6.0 to 0.7.0 
Bumps [github.com/coreos/go-iptables](https://github.com/coreos/go-iptables) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/coreos/go-iptables/releases)
- [Commits](https://github.com/coreos/go-iptables/compare/v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: github.com/coreos/go-iptables
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-08-07 02:47:30 +00:00
Casey Callendrello
9d9ec6e3e1
Merge pull request #927 from sockmister/vrf_filter_fix 
vrf: fix route filter to use output iface
 2023-07-21 13:49:33 +02:00
Casey Callendrello
8fd63065a6
Merge pull request #913 from AlinaSecret/dhcp/fix-race-test 
Fix race conditions in DHCP test
 2023-07-21 12:55:01 +02:00
Poh Chiat Koh
c1a7948b19 vrf: fix route filter to use output iface 
current route filter uses RT_FILTER_IIF in conjunction with LinkIndex.
This combination is ignored by netlink, rendering the filter
ineffective

Signed-off-by: Poh Chiat Koh <poh@inter.link>
 2023-07-21 12:50:21 +02:00
Casey Callendrello
1561794ae9
Merge pull request #924 from SirPhuttel/go-iptables_review 
Review code using go-iptables module
 2023-07-21 12:23:08 +02:00
Casey Callendrello
fb8ca5d31e
Merge pull request #918 from SirPhuttel/rawhide_testing 
Two minor testsuite fixes
 2023-07-21 12:22:46 +02:00
Casey Callendrello
f2574a7cb1
Merge pull request #926 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.10.0 
build(deps): bump golang.org/x/sys from 0.9.0 to 0.10.0
 2023-07-21 11:56:30 +02:00
Casey Callendrello
438548a9dd
Merge pull request #902 from SirPhuttel/applyconfigecho 
spoofcheck: Make use of go-nft's ApplyConfigEcho()
 2023-07-20 12:01:18 +02:00
Phil Sutter
8e69e38d51 test_linux.sh: Do not fail if called twice 
The script is set to exit on error, so mkdir failing because
/tmp/cni-rootless already exists aborts the test run. Call 'mkdir -p' to
avoid the spurious error.

Signed-off-by: Phil Sutter <psutter@redhat.com>
 2023-07-20 11:34:34 +02:00
Phil Sutter
0a100e5d8f meta: firewall: Fix firewalld test with non-abstract sockets 
On a recent Fedora Rawhide, dbus-daemon-1.14.8-1 prints a string
prefixed by 'unix:path' instead of the expected 'unix:abstract', thereby
failing the test. Allowing this alternate prefix fixes the test, so for
communication with the daemon it is not relevant.

Signed-off-by: Phil Sutter <psutter@redhat.com>
 2023-07-20 11:34:34 +02:00
Phil Sutter
3eb775c5e6 plugins: meta: portmap: Implement a teardown() fast path 
Just attempt to delete the known rules referring to the custom chain,
then flush and delete it. If the latter succeeds, no referencing rules
are left and the job is done.

If the final flush'n'delete fails, fall back to the referencing rule
search which is slow with large rulesets.

Signed-off-by: Phil Sutter <psutter@redhat.com>
 2023-07-20 11:34:02 +02:00
Phil Sutter
719f60bb91 utils: iptables: Use go-iptables' ChainExists() 
Starting with v0.5.0, go-iptables exports a fast ChainExists() which
does not rely upon listing all chains and searching the results but
probes chain existence by listing its first rule. This should make a
significant difference in rulesets with thousands of chains.

Signed-off-by: Phil Sutter <psutter@redhat.com>
 2023-07-20 11:34:02 +02:00
Phil Sutter
2ba7f1608f spoofcheck: Make use of go-nft's ApplyConfigEcho() 
Store the relevant applied config part for later to extract the rule to
delete from there instead of having to list the ruleset. This is much
faster especially with large rulesets.

Signed-off-by: Phil Sutter <psutter@redhat.com>
 2023-07-20 11:32:09 +02:00
Casey Callendrello
bf79945c70
Merge pull request #929 from squeed/fix-ci-cnitool-version 
test: install binaries using `go install`
 2023-07-20 11:26:31 +02:00
Casey Callendrello
ba41448fe6 test: install binaries using go install 
We were getting tip- versions of all the tools, and this was unstable.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
 2023-07-20 11:15:41 +02:00
dependabot[bot]
13fd3de77f
build(deps): bump golang.org/x/sys from 0.9.0 to 0.10.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.9.0 to 0.10.0.
- [Commits](https://github.com/golang/sys/compare/v0.9.0...v0.10.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-07-10 02:29:05 +00:00
Casey Callendrello
283f200489
Merge pull request #897 from containernetworking/dependabot/docker/dot-github/actions/retest-action/alpine-3.18 
build(deps): bump alpine from 3.17 to 3.18 in /.github/actions/retest-action
 2023-07-03 17:05:49 +02:00
Casey Callendrello
a7e8db00cb
Merge pull request #911 from containernetworking/dependabot/go_modules/golang.org/x/sys-0.9.0 
build(deps): bump golang.org/x/sys from 0.7.0 to 0.9.0
 2023-07-03 17:05:17 +02:00
Casey Callendrello
ffb2e2d7d1
Merge pull request #912 from containernetworking/dependabot/go_modules/github.com/onsi/ginkgo/v2-2.11.0 
build(deps): bump github.com/onsi/ginkgo/v2 from 2.9.2 to 2.11.0
 2023-07-03 17:05:02 +02:00
Casey Callendrello
d03b84d8f2
Merge pull request #874 from travelping/vrf-add-routes 
Add routes propagation for VRF plugin
 2023-06-27 12:20:45 +02:00
Casey Callendrello
1512d727cb
Merge pull request #914 from tariq1890/tx-qlen 
[tuning] add ability to set tx queue len
 2023-06-26 17:47:01 +02:00
Tariq Ibrahim
470eee1385 [tuning]add ability to set tx queue len 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
 2023-06-25 23:28:48 -07:00
dependabot[bot]
2216cff9e8
build(deps): bump github.com/onsi/ginkgo/v2 from 2.9.2 to 2.11.0 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.9.2 to 2.11.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.9.2...v2.11.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-06-19 02:58:59 +00:00
dependabot[bot]
83029befef
build(deps): bump golang.org/x/sys from 0.7.0 to 0.9.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.7.0 to 0.9.0.
- [Commits](https://github.com/golang/sys/compare/v0.7.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-06-19 02:58:45 +00:00
Alina Sudakov
48aa2f4eef Fix race conditions in DHCP test 
The test named "correctly handles multiple DELs for the same container" in the ipam/dhcp package experiences race conditions when multiple goroutines concurrently access and modify the Args struct (of type CmdArgs).
To address these issues, a copy of the CmdArgs struct is now created in each function to eliminate data races.

Also, the test-linux.sh and test-windows.sh scripts have been updated to include the '-race' flag, enabling race detection during testing. This change helps prevent future race conditions by activating the Go race detector.

Signed-off-by: Alina Sudakov <asudakov@redhat.com>
 2023-06-14 17:57:46 +03:00
Artur Korzeniewski
ca12d49b41 Add routes propagation for VRF plugin 
Up until now, if previous plugin assigned routes to interface, movement of
this interface to new VRF cause routes to be deleted.

This patch adds funtionality to VRF plugin to save the routes before
interface is assgined to VRF, and then re-apply all saved routes to new VRF.

Signed-off-by: Artur Korzeniewski <artur.korzeniewski@travelping.com>
 2023-06-02 14:21:28 +02:00
Casey Callendrello
2b097c5a62
Merge pull request #900 from squeed/disable-stale 
github: remove stale issue cleanup
 2023-05-25 10:32:04 +02:00
Casey Callendrello
0389a29052 github: remove stale issue cleanup 
In retrospect, this was a bad idea. It's closing too many valid issues.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
 2023-05-25 10:31:15 +02:00
Dan Williams
6265f4e4ca
Merge pull request #832 from maiqueb/tap-plugin-set-as-bridge-port 
tap: allow for a tap device to be created as a bridge port
 2023-05-22 10:59:28 -05:00