ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity

pkg/utils: split and unexport constants

Browse Source
This commit is contained in:
Stefan Junker 2016-03-31 10:08:52 +02:00
parent f429750105
commit d4e088aad4
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
utils/utils.go
View File

@ -5,16 +5,17 @@ import (
"fmt" "fmt"
) )
const ChainCNIPrefix = ("CNI-") const (
const MaxChainLength = 29 - len(ChainCNIPrefix) maxChainLength = 28
chainPrefix = "CNI-"
prefixLength = len(chainPrefix)
)
// Generates a chain name to be used with iptables. // Generates a chain name to be used with iptables.
// Ensures that the generated chain name is less than // Ensures that the generated chain name is less than
// 29 chars in length // maxChainLength chars in length
func FormatChainName(name string, id string) string { func FormatChainName(name string, id string) string {
chain := fmt.Sprintf("%x", sha512.Sum512([]byte(name+id))) chainBytes := sha512.Sum512([]byte(name + id))
if len(chain) > MaxChainLength { chain := fmt.Sprintf("%s%x", chainPrefix, chainBytes)
chain = chain[:MaxChainLength] return chain[:maxChainLength]
}
return fmt.Sprintf("%s%s", ChainCNIPrefix, chain)
} }

13
utils/utils_test.go
View File

@ -8,32 +8,31 @@ import (
var _ = Describe("Utils", func() { var _ = Describe("Utils", func() {
It("must format a short name", func() { It("must format a short name", func() {
chain := FormatChainName("test", "1234") chain := FormatChainName("test", "1234")
Expect(len(chain) == 29).To(Equal(true)) Expect(len(chain)).To(Equal(maxChainLength))
Expect(chain).To(Equal("CNI-2bbe0c48b91a7d1b8a6753a8b")) Expect(chain).To(Equal("CNI-2bbe0c48b91a7d1b8a6753a8b"))
}) })
It("must truncate a long name", func() { It("must truncate a long name", func() {
chain := FormatChainName("testalongnamethatdoesnotmakesense", "1234") chain := FormatChainName("testalongnamethatdoesnotmakesense", "1234")
Expect(len(chain) == 29).To(Equal(true)) Expect(len(chain)).To(Equal(maxChainLength))
Expect(chain).To(Equal("CNI-374f33fe84ab0ed84dcdebe38")) Expect(chain).To(Equal("CNI-374f33fe84ab0ed84dcdebe38"))
}) })
It("must be predictable", func() { It("must be predictable", func() {
chain1 := FormatChainName("testalongnamethatdoesnotmakesense", "1234") chain1 := FormatChainName("testalongnamethatdoesnotmakesense", "1234")
chain2 := FormatChainName("testalongnamethatdoesnotmakesense", "1234") chain2 := FormatChainName("testalongnamethatdoesnotmakesense", "1234")
Expect(len(chain1) == 29).To(Equal(true)) Expect(len(chain1)).To(Equal(maxChainLength))
Expect(len(chain2) == 29).To(Equal(true)) Expect(len(chain2)).To(Equal(maxChainLength))
Expect(chain1).To(Equal(chain2)) Expect(chain1).To(Equal(chain2))
}) })
It("must change when a character changes", func() { It("must change when a character changes", func() {
chain1 := FormatChainName("testalongnamethatdoesnotmakesense", "1234") chain1 := FormatChainName("testalongnamethatdoesnotmakesense", "1234")
chain2 := FormatChainName("testalongnamethatdoesnotmakesense", "1235") chain2 := FormatChainName("testalongnamethatdoesnotmakesense", "1235")
Expect(len(chain1) == 29).To(Equal(true)) Expect(len(chain1)).To(Equal(maxChainLength))
Expect(len(chain2) == 29).To(Equal(true)) Expect(len(chain2)).To(Equal(maxChainLength))
Expect(chain1).To(Equal("CNI-374f33fe84ab0ed84dcdebe38")) Expect(chain1).To(Equal("CNI-374f33fe84ab0ed84dcdebe38"))
Expect(chain2).NotTo(Equal("CNI-374f33fe84ab0ed84dcdebe38")) Expect(chain2).NotTo(Equal("CNI-374f33fe84ab0ed84dcdebe38"))
Expect(chain1).NotTo(Equal(chain2)) Expect(chain1).NotTo(Equal(chain2))
}) })
}) })