ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity

libcni: Fixed tests that were checking error strings.

Browse Source 
Checking error strings makes these tests flaky, especially if the
error string is changed in libcni. Have gone ahead an introduced a new
error type `NoConfigsFoundError` and the Match is against the error
type making it more deterministic.
This commit is contained in:
Avinash Sridharan 2017-04-04 16:49:48 +00:00
parent 5b0d6a0c8f
commit d427963784
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcni/conf_test.go
View File

@ -61,7 +61,7 @@ var _ = Describe("Loading configuration from disk", func() {
It("returns a useful error", func() { It("returns a useful error", func() {
_, err := libcni.LoadConf(configDir, "some-plugin") _, err := libcni.LoadConf(configDir, "some-plugin")
Expect(err).To(MatchError("no net configurations found")) Expect(err).To(MatchError(libcni.NoConfigsFoundError{Dir: configDir}))
}) })
}) })
@ -244,7 +244,7 @@ var _ = Describe("Loading configuration from disk", func() {
It("returns a useful error", func() { It("returns a useful error", func() {
_, err := libcni.LoadConfList(configDir, "some-plugin") _, err := libcni.LoadConfList(configDir, "some-plugin")
Expect(err).To(MatchError("no net configurations found")) Expect(err).To(MatchError(libcni.NoConfigsFoundError{Dir: configDir}))
}) })
}) })