ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity

Merge pull request #486 from Metaswitch/bring-down-interfaces

Browse Source 
host-device: Bring interfaces down before moving.
This commit is contained in:
Casey Callendrello 2020-05-27 17:37:31 +02:00 committed by GitHub
commit b76fdd7c03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/main/host-device/host-device.go
View File

@ -193,6 +193,10 @@ func moveLinkIn(hostDev netlink.Link, containerNs ns.NetNS, ifName string) (netl
if err != nil { if err != nil {
return fmt.Errorf("failed to find %q: %v", hostDev.Attrs().Name, err) return fmt.Errorf("failed to find %q: %v", hostDev.Attrs().Name, err)
} }
// Devices can be renamed only when down
if err = netlink.LinkSetDown(contDev); err != nil {
return fmt.Errorf("failed to set %q down: %v", hostDev.Attrs().Name, err)
}
// Save host device name into the container device's alias property // Save host device name into the container device's alias property
if err := netlink.LinkSetAlias(contDev, hostDev.Attrs().Name); err != nil { if err := netlink.LinkSetAlias(contDev, hostDev.Attrs().Name); err != nil {
return fmt.Errorf("failed to set alias to %q: %v", hostDev.Attrs().Name, err) return fmt.Errorf("failed to set alias to %q: %v", hostDev.Attrs().Name, err)