From 66837d6f3b7817c840e8fcec162a8e28d1aa5c60 Mon Sep 17 00:00:00 2001 From: Michael Cambria Date: Mon, 1 Oct 2018 16:12:07 -0400 Subject: [PATCH] Remove -p from test.sh Running ginkgo tests in parallel causes problems with dhcp_test.go. BeforeEach() is run once for each spec before any actual dhcp test starts. This results in setting up two dhcp4servers that run concurrently. Both try to Listen and use unix socketPath file /run/cni/dhcp.sock at the same time. AfterEach() for one test runs when test completes, deleting /run/cni/dhcp.sock. But other test still needs the file resulting in test failing. Often, the next dhcp test hasn't started yet. When test does start it waits 15 seconds for dhcp4server to create /run/cni/dhcp.sock (which has just been deleted) so test fails. Other times dhcp tests fail because /run/cni/dhcp.sock is deleted while still being used. --- test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test.sh b/test.sh index 0c48852d..ccc1068b 100755 --- a/test.sh +++ b/test.sh @@ -10,7 +10,7 @@ source ./build.sh echo "Running tests" -GINKGO_FLAGS="-p --randomizeAllSpecs --randomizeSuites --failOnPending --progress" +GINKGO_FLAGS="-nodes=1 --randomizeAllSpecs --randomizeSuites --failOnPending --progress" # user has not provided PKG override if [ -z "$PKG" ]; then