From 7bbd4d19e908af6ce23923265484c16adb33c799 Mon Sep 17 00:00:00 2001 From: Miguel Duarte Barroso Date: Tue, 4 Apr 2023 16:08:58 +0200 Subject: [PATCH] linter: fix ginkgolinter errors Use: - `BeEmpty` instead of `HaveLen(0)` - `Expect(x).To(BeZero())` instead of `Expect(x == 0).To(BeTrue())` Signed-off-by: Miguel Duarte Barroso --- pkg/ip/link_linux_test.go | 2 +- plugins/meta/tuning/tuning_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/ip/link_linux_test.go b/pkg/ip/link_linux_test.go index 67976a99..2d980fd6 100644 --- a/pkg/ip/link_linux_test.go +++ b/pkg/ip/link_linux_test.go @@ -283,7 +283,7 @@ var _ = Describe("Link", func() { // this will delete the host endpoint too addr, err := ip.DelLinkByNameAddr(containerVethName) Expect(err).NotTo(HaveOccurred()) - Expect(addr).To(HaveLen(0)) + Expect(addr).To(BeEmpty()) return nil }) }) diff --git a/plugins/meta/tuning/tuning_test.go b/plugins/meta/tuning/tuning_test.go index 1e5a2c1f..9df0950a 100644 --- a/plugins/meta/tuning/tuning_test.go +++ b/plugins/meta/tuning/tuning_test.go @@ -914,7 +914,7 @@ var _ = Describe("tuning plugin", func() { link, err := netlink.LinkByName(IFNAME) Expect(err).NotTo(HaveOccurred()) - Expect(link.Attrs().RawFlags&unix.IFF_ALLMULTI != 0).To(BeTrue()) + Expect(link.Attrs().RawFlags & unix.IFF_ALLMULTI).NotTo(BeZero()) if testutils.SpecVersionHasCHECK(ver) { n := &TuningConf{} @@ -995,7 +995,7 @@ var _ = Describe("tuning plugin", func() { link, err := netlink.LinkByName(IFNAME) Expect(err).NotTo(HaveOccurred()) - Expect(link.Attrs().RawFlags&unix.IFF_ALLMULTI != 0).To(BeTrue()) + Expect(link.Attrs().RawFlags & unix.IFF_ALLMULTI).NotTo(BeZero()) err = testutils.CmdDel(originalNS.Path(), args.ContainerID, "", func() error { return cmdDel(args) })