ITQC/containernetworking-plugins
24
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 34 Wiki Activity

enable gosimple linter

Browse Source 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This commit is contained in:
Matthieu MOREL
2023-03-11 22:43:45 +01:00
parent 709e775b13
commit 5a7619c019
6 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/meta/firewall/ingresspolicy.go
View File

@ -167,7 +167,7 @@ func isolationStage2BridgeRule(bridgeName string) []string {
}
func withDefaultComment(rule []string) []string {
defaultComment := fmt.Sprintf("CNI firewall plugin rules (ingressPolicy: same-bridge)")
defaultComment := "CNI firewall plugin rules (ingressPolicy: same-bridge)"
return withComment(rule, defaultComment)
}

6
plugins/meta/tuning/tuning.go
View File

@ -369,7 +369,7 @@ func cmdAdd(args *skel.CmdArgs) error {
updateResultsMacAddr(tuningConf, args.IfName, tuningConf.Mac)
}
if tuningConf.Promisc != false {
if tuningConf.Promisc {
if err = changePromisc(args.IfName, true); err != nil {
return err
}
@ -514,7 +514,7 @@ func validateSysctlConf(tuningConf *TuningConf) error {
return err
}
if !match {
return errors.New(fmt.Sprintf("Sysctl %s is not allowed. Only the following sysctls are allowed: %+v", sysctl, allowlist))
return fmt.Errorf("Sysctl %s is not allowed. Only the following sysctls are allowed: %+v", sysctl, allowlist)
}
}
return nil
@ -579,7 +579,7 @@ func validateSysctlConflictingKeys(data []byte) error {
func validateArgs(args *skel.CmdArgs) error {
if strings.Contains(args.IfName, string(os.PathSeparator)) {
return errors.New(fmt.Sprintf("Interface name (%s) contains an invalid character %s", args.IfName, string(os.PathSeparator)))
return fmt.Errorf("Interface name (%s) contains an invalid character %s", args.IfName, string(os.PathSeparator))
}
return nil
}