Add simple testing infrastructure

plugins/sample/main.go

@@ -116,6 +116,9 @@ func cmdAdd(args *skel.CmdArgs) error {
 			containerIPs = append(containerIPs, ip.Address.IP)
 		}
 	}
+	if len(containerIPs) == 0 {
+		return fmt.Errorf("got no container IPs")
+	}
 
 	// Pass through the result for the next plugin
 	return types.PrintResult(conf.PrevResult, conf.CNIVersion)

plugins/sample/sample_suite_test.go

@@ -0,0 +1,15 @@
+// The boilerplate needed for Ginkgo
+
+package main
+
+import (
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	"testing"
+)
+
+func TestSample(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "sample suite")
+}

plugins/sample/sample_test.go

@@ -0,0 +1,138 @@
+// Copyright 2017 CNI authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"fmt"
+
+	"github.com/containernetworking/cni/pkg/ns"
+	"github.com/containernetworking/cni/pkg/skel"
+	"github.com/containernetworking/cni/pkg/testutils"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("sample test", func() {
+	var targetNs ns.NetNS
+
+	BeforeEach(func() {
+		var err error
+		targetNs, err = ns.NewNS()
+		Expect(err).NotTo(HaveOccurred())
+	})
+
+	AfterEach(func() {
+		targetNs.Close()
+	})
+
+	It("Works with a 0.3.0 config", func() {
+		ifname := "eth0"
+		conf := `{
+	"cniVersion": "0.3.0",
+	"name": "cni-plugin-sample-test",
+	"type": "sample",
+	"anotherAwesomeArg": "awesome",
+	"prevResult": {
+		"interfaces": [
+			{
+				"name": "%s",
+				"sandbox": "%s"
+			}
+		],
+		"ips": [
+			{
+				"version": "4",
+				"address": "10.0.0.2/24",
+				"gateway": "10.0.0.1",
+				"interface": 0
+			}
+		],
+		"routes": []
+	}
+}`
+		conf = fmt.Sprintf(conf, ifname, targetNs.Path())
+		args := &skel.CmdArgs{
+			ContainerID: "dummy",
+			Netns:       targetNs.Path(),
+			IfName:      ifname,
+			StdinData:   []byte(conf),
+		}
+		_, _, err := testutils.CmdAddWithResult(targetNs.Path(), "eth0", []byte(conf), func() error { return cmdAdd(args) })
+		Expect(err).NotTo(HaveOccurred())
+
+	})
+
+	It("fails an invalid config", func() {
+		conf := `{
+	"cniVersion": "0.3.0",
+	"name": "cni-plugin-sample-test",
+	"type": "sample",
+	"prevResult": {
+		"interfaces": [
+			{
+				"name": "eth0",
+				"sandbox": "/var/run/netns/test"
+			}
+		],
+		"ips": [
+			{
+				"version": "4",
+				"address": "10.0.0.2/24",
+				"gateway": "10.0.0.1",
+				"interface": 0
+			}
+		],
+		"routes": []
+	}
+}`
+
+		args := &skel.CmdArgs{
+			ContainerID: "dummy",
+			Netns:       targetNs.Path(),
+			IfName:      "eth0",
+			StdinData:   []byte(conf),
+		}
+		_, _, err := testutils.CmdAddWithResult(targetNs.Path(), "eth0", []byte(conf), func() error { return cmdAdd(args) })
+		Expect(err).To(MatchError("anotherAwesomeArg must be specified"))
+
+	})
+
+	It("works with a 0.2.0 config", func() {
+		conf := `{
+	"cniVersion": "0.2.0",
+	"name": "cni-plugin-sample-test",
+	"type": "sample",
+	"anotherAwesomeArg": "foo",
+	"prevResult": {
+		"ip4": {
+			"ip": "10.0.0.2/24",
+			"gateway": "10.0.0.1",
+			"routes": []
+		}
+	}
+}`
+
+		args := &skel.CmdArgs{
+			ContainerID: "dummy",
+			Netns:       targetNs.Path(),
+			IfName:      "eth0",
+			StdinData:   []byte(conf),
+		}
+		_, _, err := testutils.CmdAddWithResult(targetNs.Path(), "eth0", []byte(conf), func() error { return cmdAdd(args) })
+		Expect(err).NotTo(HaveOccurred())
+
+	})
+
+})