From 1c1424c4726bbb35fa76d0f8a9e3d18504f920bd Mon Sep 17 00:00:00 2001
From: Minhan Xia <mixia@google.com>
Date: Tue, 3 May 2016 15:47:28 -0700
Subject: [PATCH] add tests for generateHardwardAddr

---
 pkg/ipam/ipam_suite_test.go | 27 ++++++++++++++++
 pkg/ipam/ipam_test.go       | 62 +++++++++++++++++++++++++++++++++++++
 test                        |  2 +-
 3 files changed, 90 insertions(+), 1 deletion(-)
 create mode 100644 pkg/ipam/ipam_suite_test.go
 create mode 100644 pkg/ipam/ipam_test.go

diff --git a/pkg/ipam/ipam_suite_test.go b/pkg/ipam/ipam_suite_test.go
new file mode 100644
index 00000000..e80c8675
--- /dev/null
+++ b/pkg/ipam/ipam_suite_test.go
@@ -0,0 +1,27 @@
+// Copyright 2016 CNI authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package ipam_test
+
+import (
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	"testing"
+)
+
+func TestIpam(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Ipam Suite")
+}
diff --git a/pkg/ipam/ipam_test.go b/pkg/ipam/ipam_test.go
new file mode 100644
index 00000000..0cacd08f
--- /dev/null
+++ b/pkg/ipam/ipam_test.go
@@ -0,0 +1,62 @@
+// Copyright 2016 CNI authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package ipam
+
+import (
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"net"
+)
+
+var _ = Describe("ipam utils", func() {
+	Context("Generate Hardware Addrress", func() {
+		It("generate hardware address based on ipv4 address", func() {
+			testCases := []struct {
+				ip          net.IP
+				expectedMAC string
+			}{
+				{
+					ip:          net.ParseIP("10.0.0.2"),
+					expectedMAC: privateMACPrefix + ":0a:00:00:02",
+				},
+				{
+					ip:          net.ParseIP("10.250.0.244"),
+					expectedMAC: privateMACPrefix + ":0a:fa:00:f4",
+				},
+				{
+					ip:          net.ParseIP("172.17.0.2"),
+					expectedMAC: privateMACPrefix + ":ac:11:00:02",
+				},
+			}
+
+			for _, tc := range testCases {
+				mac, err := generateHardwareAddr(tc.ip)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(mac.String()).To(Equal(tc.expectedMAC))
+			}
+		})
+
+		It("return error if input is not ipv4 address", func() {
+			testCases := []net.IP{
+				net.ParseIP(""),
+				net.ParseIP("2001:db8:0:1:1:1:1:1"),
+			}
+			for _, tc := range testCases {
+				_, err := generateHardwareAddr(tc)
+				Expect(err.Error()).To(Equal("generateHardwareAddr only support valid ipv4 address as input"))
+			}
+		})
+	})
+})
diff --git a/test b/test
index 91220800..9cd43e03 100755
--- a/test
+++ b/test
@@ -12,7 +12,7 @@ set -e
 source ./build
 
 TESTABLE="libcni plugins/ipam/dhcp plugins/ipam/host-local plugins/main/loopback pkg/invoke pkg/ns pkg/skel pkg/types pkg/utils plugins/main/ipvlan plugins/main/macvlan plugins/main/bridge plugins/main/ptp plugins/test/noop"
-FORMATTABLE="$TESTABLE libcni pkg/ip pkg/ipam pkg/testutils plugins/meta/flannel plugins/meta/tuning"
+FORMATTABLE="$TESTABLE pkg/ip pkg/testutils plugins/meta/flannel plugins/meta/tuning"
 
 # user has not provided PKG override
 if [ -z "$PKG" ]; then