ELOG/elog
0
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use strdup instead of manual calloc/memcpy. This fixes issue #1.

Browse Source
This commit is contained in:
Jan Christoph Terasa
2019-03-16 13:20:21 +01:00
parent 93e092db13
commit e9d3b82ddb
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/auth.c
+5 -4
View File
@@ -445,11 +445,12 @@ int elog_conv(int num_msg, const struct pam_message **mess, struct pam_response
if((*resp = calloc(num_msg, sizeof(struct pam_response))) == NULL)
return (PAM_BUF_ERR);
/* this is the password we got through the UI, copy it to the heap, since
* pam_authenticate will free() the response, give error if calloc fails */
if((resptok = calloc(strlen(my_data)+1, sizeof(char))) == NULL)
/* this is the password we got through the UI, this is put into the
* response, and given to pam_authenticate */
if(!(resptok = strdup(my_data))) {
free(resp);
return (PAM_BUF_ERR);
memcpy(resptok, my_data, strlen(my_data)+1);
}
/* set the response to our auth token (password) */
(*resp)->resp = resptok;