From f7e1c31550f416f3c32412d6e06868a44a768b5c Mon Sep 17 00:00:00 2001 From: simon_l Date: Wed, 21 May 2025 16:35:50 +0200 Subject: [PATCH 1/4] added len(interpolated_cpc) --- pipelines/steps/generate_flags.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pipelines/steps/generate_flags.py b/pipelines/steps/generate_flags.py index dd56015..3eb571c 100644 --- a/pipelines/steps/generate_flags.py +++ b/pipelines/steps/generate_flags.py @@ -264,7 +264,7 @@ def generate_species_flags(data_table : pd.DataFrame, calib_param_dict : dict, f numflag_columns = [col for col in data_table.columns if 'numflag_' in col] - if interpolated_cpc_flags: + if len(interpolated_cpc_flags)>0: data_table = reconcile_flags(data_table, interpolated_cpc_flags, 0, interpolated_cpc_flags.size, numflag_columns) From 7a0ce9584887ccf5af00d199d0b759159b12ced8 Mon Sep 17 00:00:00 2001 From: simon_l Date: Wed, 21 May 2025 17:22:09 +0200 Subject: [PATCH 2/4] Changed the originator address --- campaignDescriptor.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/campaignDescriptor.yaml b/campaignDescriptor.yaml index 9739a70..1444f52 100644 --- a/campaignDescriptor.yaml +++ b/campaignDescriptor.yaml @@ -30,8 +30,10 @@ originator: email: leila.simon@psi.ch affiliation: Paul Scherrer Institute, PSI department: Laboratory of Atmospheric Chemistry - city: Villigen PSI + address_line_1: "" + address_line_2: "" postal_code: 5232 + city: Villigen PSI country: Switzerland submitter: @@ -39,6 +41,8 @@ submitter: email: leila.simon@psi.ch affiliation: Paul Scherrer Institute, PSI department: Laboratory of Atmospheric Chemistry - city: Villigen PSI + address_line_1: "" + address_line_2: "" postal_code: 5232 + city: Villigen PSI country: Switzerland From e22321f823b459cb081ce88de44f689935c2d177 Mon Sep 17 00:00:00 2001 From: simon_l Date: Wed, 21 May 2025 18:59:19 +0200 Subject: [PATCH 3/4] Updated to do list --- TODO.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/TODO.md b/TODO.md index 9b25023..ea9a15e 100644 --- a/TODO.md +++ b/TODO.md @@ -1,8 +1,9 @@ # TODO -* [from Leïla] Add flagging based on CPC flags -* [from Leïla] Correct calibration_params copying -* [from Leïla] Plot for auto flags visualization should be able to zoom in vertically -* [from Leïla] Remove inletP column in level 2 .nas data +* [from Leïla] Correct error when flags are loaded in the flagging app +* [from Leïla] Change "9999.999" to "9999999.9999" in header +* [from Leïla] Update Detection limit values in L2 header: take the ones (1h) from limits_of_detection.yaml +* [from Leïla] For PAY, calculate error as 50% of concentration +* [from Leïla] Correct errors (uncertainties) that they can't be lower than 0.0001 * [from Leïla] Change flow rate values to 10% of flow rate ref * [New] Create data flows to validate and replace existing data chain params. data/campaignData/param/ -> pipelines/params and campaignDescriptor.yaml -> acsm data converter. * [New] DIMA. Add dictionaries to explain variables at different levels. From f8ee5b1ce4545d17d651d61fcbc33c081edd58ec Mon Sep 17 00:00:00 2001 From: simon_l Date: Mon, 26 May 2025 11:59:56 +0200 Subject: [PATCH 4/4] Added a todo --- TODO.md | 1 + 1 file changed, 1 insertion(+) diff --git a/TODO.md b/TODO.md index ea9a15e..ce05f0a 100644 --- a/TODO.md +++ b/TODO.md @@ -1,5 +1,6 @@ # TODO * [from Leïla] Correct error when flags are loaded in the flagging app +* [from Leïla] End the file at end of year (or filter only current year) * [from Leïla] Change "9999.999" to "9999999.9999" in header * [from Leïla] Update Detection limit values in L2 header: take the ones (1h) from limits_of_detection.yaml * [from Leïla] For PAY, calculate error as 50% of concentration